diff --git a/src/accountlistmodel.cpp b/src/accountlistmodel.cpp index bd6bdf4a42a0202e1c7f39dab56ca1fd7887ac1c..f332dec185c98c9e79abf99df0494943a2399866 100644 --- a/src/accountlistmodel.cpp +++ b/src/accountlistmodel.cpp @@ -241,13 +241,12 @@ void AccountListModel::slotVoiceMailNotify(const QString &accountID, int count) void AccountListModel::update() { ConfigurationManagerInterface & configurationManager = DBus::ConfigurationManager::instance(); - Account* current; QList<Account*> tmp; for (int i = 0; i < m_lAccounts.size(); i++) tmp << m_lAccounts[i]; for (int i = 0; i < tmp.size(); i++) { - current = tmp[i]; + Account* current = tmp[i]; if (!current->isNew() && (current->state() != Account::AccountEditState::NEW && current->state() != Account::AccountEditState::MODIFIED && current->state() != Account::AccountEditState::OUTDATED)) @@ -297,7 +296,6 @@ void AccountListModel::save() //create or update each account from accountList for (int i = 0; i < size(); i++) { Account* current = (*this)[i]; - //current->save(); current->performAction(Account::AccountEditAction::SAVE); } @@ -406,9 +404,8 @@ QVector<Account*> AccountListModel::getAccountsByState(const QString& state) ///Get the first registerred account (default account) Account* AccountListModel::firstRegisteredAccount() const { - Account* current; for (int i = 0; i < m_lAccounts.count(); ++i) { - current = m_lAccounts[i]; + Account* current = m_lAccounts[i]; if(current && current->registrationStatus() == Account::State::REGISTERED && current->isEnabled()) return current; else if (current && (current->registrationStatus() == Account::State::READY) && m_lAccounts.count() == 1) diff --git a/src/call.cpp b/src/call.cpp index 1c88adc4d1fe0df2cde3e9ac2baf06e29ceebd59..4849390b25cd10b5ee3e8b5dd05db12ad15edeb6 100644 --- a/src/call.cpp +++ b/src/call.cpp @@ -808,7 +808,7 @@ Call::State Call::performAction(Call::Action action) try { changeCurrentState(actionPerformedStateMap[previousState][action]); } - catch(Call::State state) { + catch(Call::State& state) { qDebug() << "State change failed (actionPerformedStateMap)" << state; m_CurrentState = Call::State::ERROR; emit stateChanged(); diff --git a/src/contactproxymodel.cpp b/src/contactproxymodel.cpp index b25522c93aa8c8533becd7f17bb91134f0e98a78..b96f4de6463706125875212f6312fe9f6c1f3376 100644 --- a/src/contactproxymodel.cpp +++ b/src/contactproxymodel.cpp @@ -70,7 +70,7 @@ TopLevelItem::~TopLevelItem() { } ContactTreeNode::ContactTreeNode(Contact* ct, ContactProxyModel* parent) : CategorizedCompositeNode(CategorizedCompositeNode::Type::CONTACT), - m_pContact(ct) + m_pContact(ct),m_pParent3(nullptr) { m_pBinder = new ContactTreeBinder(parent,this); } diff --git a/src/numbercompletionmodel.cpp b/src/numbercompletionmodel.cpp index 19b39c01a7e926a50eac8a1193de81d785f83518..e7729ba50ccee0388a6d744af14cac385d167d8e 100644 --- a/src/numbercompletionmodel.cpp +++ b/src/numbercompletionmodel.cpp @@ -217,8 +217,8 @@ void NumberCompletionModel::getRange(QMap<QString,PhoneDirectoryModel::NumberWra int toAdd = size-1; mid = iBeg; while (toAdd && mid != map.end()) { - mid++; - toAdd--; + ++mid; + --toAdd; } } if (mid != map.end() && mid.key().left(prefixLen) == pref && iBeg.key().left(prefixLen) < pref) { @@ -236,7 +236,7 @@ void NumberCompletionModel::getRange(QMap<QString,PhoneDirectoryModel::NumberWra } while ((iEnd).key().left(prefixLen) == pref && iEnd+1 != map.end()) { - iEnd++; + ++iEnd; } endOk = (iEnd.key().left(prefixLen) == pref); @@ -245,7 +245,7 @@ void NumberCompletionModel::getRange(QMap<QString,PhoneDirectoryModel::NumberWra } while (iBeg.key().left(prefixLen) != pref && iBeg != iEnd) - iBeg++; + ++iBeg; if (iEnd == iBeg && iBeg.key().left(prefixLen) != pref) { iEnd = map.end(); @@ -257,7 +257,7 @@ void NumberCompletionModel::getRange(QMap<QString,PhoneDirectoryModel::NumberWra set << n; } } - iBeg++; + ++iBeg; } }