missing edit in d57d2748 make the next bug still present :
the vcard sent was obtained trough a Person object returned by
contact() from a ContactMethod. But this Person may be never set.

fix : now we use the profile to get the vcard to send within the
ContactRequest.

Change-Id: I150715b45bf564fa7e0fb3fae5b186375dfe0ec1
Reviewed-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>

bug : the vcard sent was obtained trough a Person object returned by
contact() from a ContactMethod. But this Person may be never set.

fix : now we use the profile to get the vcard to send within the
ContactRequest.

[SS: improve ci msg; use Account's profile, rather than selected profile]

Change-Id: I21ef691e3fdd96a6e504989a1178444c0d4b90ef
Signed-off-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>
Reviewed-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>

Also adopt an exit early code style to make it more readable.

Change-Id: I51333e202244fbf14769507696ffae0c3807cc2b
Reviewed-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>

When the user enters a string, it isn't always yet known if it is a
search for registered name, a SIP URI or some local DNS names.

However at some point the choice can be noarrowed down. This is a good
time to set the scheme. This help later on top pick the right account
and hopefully resolve the RingId before placing the call.

Change-Id: Iad8283fc4c6ff2e4cfe189bf216f00720202ce92
Reviewed-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>

There is a code path combination (that should not happen, but is
reachable) that could cause a null dereference.

[SS: add warning log in case it happens to make it easier to track down]

Change-Id: I1c2c2b5be417e9ec74e0ab157c9aadcd0ec4a613
Signed-off-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>
Reviewed-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>

Change-Id: I59a0dd2d74c10479c97292919736f2db5bdcfab2
Reviewed-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>

A missing `break`.

Change-Id: I194ea1446627f2bc862f0309f83076abdde34aff
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

Make sure child Calls of a ContactMethod node are moved to the
Person node when a Person node replaces a CM node.

This should prevent two bugs. One is Calls not appearing in the
smart list. The second is the model not properly signaling the
tree view about the child rows moving.

Change-Id: Ibff9186e8494d930726ccb0e8a0e61d2119bc315
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

Emmanuel Lepage Vallée authored 8 years ago and Adrien Béraud committed 7 years ago

Early versions of the Ring protocol generated a mandatory self
signed CA cert. This isn't true anymore. The error is just noise.

This also fixes the error message. The enum to string mapping was
in the wrong order.

Change-Id: I0ca67b7185065e12a44c15dd5bbd4fdf170a8ec3

Check account new state and update prior Account only in case when
current prior Account became unavailable.

Change-Id: I74fcc1e056a4afc20fe923789be21c17806cc112
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

- mapToPersonFromIncomingContactRequest : this function creates a
Person from a vCard stored by the daemon; we make sure to ignore any
ContactMethods which might be contained in the vCard and only use
the CM from which we receive it.

- PendingContactRequestModel::data now can return :
  * PEER_ID : get the username if possible or ring Id if not.
  * FORMATTED_NAME : get the profile name stored in the vCard.
  * COUNT__ : used to get the number of elements in the enum.

- ContactRequest now store a person. This person matches the vCard.

- PeerProfileCollection updates the CM(s) of the vCards it stores
with the last modified date of the vCard in to get the date at which
the contact request was accepted.

[SS: update commit message]
[SS: change how we restore the ContactRequest accept date]

Change-Id: I3bafda5b38d5e2332e095cd5f1f1d0b101847f86
Signed-off-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>
Reviewed-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>

When a contact is removed we need to remove it from personmodel and update
recentmodel & categorizedcontactmodel.

Change-Id: I09694a901278cdd01f771ea83498613159180e8d
Tuleap: #1050
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

Change-Id: If958f6aa7a89ca3878482b60be5c3905502cac3e
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

And make another method invokable (for the bindings).

Change-Id: If8a1758db5afb0356b9f4891aee30eabe9c25cb3
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

Allows accounts to be created using bindings other than C++ and
also allow the "GammaRay" introspection debugger to work.

Change-Id: I8fe0235e99896699da05bc9f9b0e168dc33fe2af
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

All other variable and argument names start with a lower case
letter.

Change-Id: I3b57208dab0f7afa7969d65ecdc0e098a5d7a48c
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

Change-Id: Ie71c85e220c98df3df6cf0ba76579ae5abc09785
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

Should not happen, but is technically possible.

Change-Id: Icfc4015267fd5d023e45f558f07e974a380b2859
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

Change-Id: Ib5af845fbdc039a8986c680ad650ce04aed66bcc
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

The directory could be read-only and it would create a silent
issue.

Change-Id: I9bff74bcaf0006d59417b0656658fc568b7c425f
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

Minor one. Call has multiple constructor and all of them init
the pointer to nullptr in the constructor body. Still enough
to fire a CI warning.

Change-Id: Ia1a9c532262cf6b1b28dc1bd95090a4d54bcb4da

Change-Id: Iedf125f04c86ba0981693d6592ce91ccf7e00f88
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

Change-Id: I1afb94da51718177ab661f706c7364fa858a6fc7
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

Change-Id: I59c299a00e3bc13bbe85f749a85cbb3ab314e0e3
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

If there are any ongoing calls during the construction of the
RecentModel we want to make sure to sync the selection with the
CallModel, which will normally select the most recent Call.

This is mostly important for clients which run as seperate processes
from the daemon, and so its possible to have ongoing calls at the
time the client is initialized.

Change-Id: I1edd595ee77c03ca294baf44802f00065e8bca2b
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

Never filter out top level items which have an active Call. Most
users will not have more than one Call at a time and they should not
have to take any action in order to interact with the Call.

Change-Id: I1b94f02a51a0ce864397126deaff20821c1d6bf1
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

- return the best Id for the last ContactMethod used with Person.

Change-Id: I015f276074b6d39ddee7d727c3dd09cb7f6e6696
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

To reduce log spam.

Change-Id: I6cc6d49079384f80d8d129e9600ab34a25de3c77
Reviewed-by: Kateryna Kostiuk <kateryna.kostiuk@savoirfairelinux.com>

Only log registered name lookup failures, to reduce log spam.

Change-Id: I4fa65294942a082177587841c91ed89f12acff18
Reviewed-by: Kateryna Kostiuk <kateryna.kostiuk@savoirfairelinux.com>

Change-Id: I84687733c1907fdeab19c2bc6e265807b4a7ff8a
Reviewed-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>

Make sure the "show chat" button is enabled when really available.

When this code was written, the chat was only available during a
call. Later, it was extended to keed some logs of existing
conversations.

However, since Alpha1, it is also possible to send offline messages
to Ring accounts. To properly determine the state of the "show chat"
button, this also has to be taken into account. This commits adds
an URI type check to the automata. This requires having optional
CM support in one of the reducing pass, which create some patch
noise, but should not destabilize anything.

This commit also fixes 2 compilation warnings introduced by a
trust request commit earlier this week.

Change-Id: I839ac17330bcfcd98fea687b8bcaf96eb7669957
Reviewed-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>

Since IP2IP was removed, this corner case wasn't correctly detected.

Any SIP account should be able to call IP address, so better use
the same code path.

Change-Id: I74ea80e1bd91caf8e75357391c6673a69667f6fe
Reviewed-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>

Since the filterAcceptsRow filtering depends on the account
selection we should automatically re-filter when it changes; the
clients shouldn't be responsible for this.

Change-Id: I94dce4eaa5fe77aec1cfa4efa5a6fbc75dce7584

Use the DRring::Presence constants insead of hardcoding the presence
key values

Change-Id: I987349797c981d0be2ef2478b001738cd62ab132
Tuleap: #1379

Load track buddies when creating an account. We do this so that the
state of contactmethods is as up to date as possible.

Otherwise, restarting the client would show the contacts as offline
because we wait for callbacks of the daemon to set the presence status.

This loads the status of all currently tracked buddies.

Tuleap: #1379
Change-Id: I047900bcbec9196f66d0d425e573f64090e3eba7

This adds the new IsPresent Ring Item Data Role so that clients do not
need additional logic when trying to extract the presence of the
different LRC models.

Tuleap: #1379
Change-Id: If1f0130ecd13b3fc57071dcce40d2d71079ad94d

- Track Ring ContactMethods as soon as they have an account
  associated to them.

- Fix setTracked's subscribeBuddyto call include the USER_INFO, which
  is absolutely necessary for it to work.

Tuleap: #1379
Change-Id: I0e82021a3aac9cac1b3a4e0e2352d9859168c4b4

This commit fix value of startTimeStamp in Call.cpp when a new
contactMethod is created. It fix two problems:
-filter rows in SmartView
-update contactMethod lastUsedTime

Tuleap: #1585
Change-Id: I6f03db26e844531ee6954c835e43d19f24e16633
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

This method was added to `AccountModel` a few days ago. This adds it
to PhoneDirectoryModel too. Assuming this is the direction the
maintainer wish to go with these functional patterns.

Change-Id: Icd1998d2fe52d6675aa6a219b5db159811600af0
Reviewed-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>

To will be used by the UserActionModel to correctly detect when
the chat is available.

Change-Id: Ic9c9def76e7f63d02b6805be78455b1b026afdba
Reviewed-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>