**WARNING** This makes the setRegisteredName method private and
thus break the API. That method could not stay public as this
would potentially corrupt the indexes.

This patch adds the registered names to the global name
directory. If `::getNumber()` is used with a known registered
name, no new CM are created.

This patch fixes the "most common" case, but doesn't implement the
following corner cases:

 * If the registered name is already part of the directory, but
   not fully linked to an account and/or RingId.
 * If there is multiple name service

For the multiple name service, the
`NameDirectory::registeredNameFound` signal will need to use full
URIs for the names (ring:foo@ns.ring.cx). This is out of this
patch scope and will have side effects that needs to be addressed
in each clients.

Change-Id: If06561dc4cb56453cc77092f4c30c633e852b7fd
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

First of all, [begin/end][Insert/Remove][Rows/Columns] is a
flat transaction and can only exist once per model. The code
was calling begin in other begin section due to some
lazy-loading code. This could result in SIGSEGV if the model
had active proxies.

More importantly, this code is called from the collections.
Some collections run in different threads. The class had a
mutex, but only used it in half the places it should have
been used. This caused a crash on the macOS and KDE client.
I could not manage to crash the Gnome client, but it is
probably possible. ASAN also got asserted due to this even
when it would have otherwise not crashed.

The commit alse fix a memory leak when the ID was duplicated
by the race condition. This is a band-aid on the problem: IDs
potentially not unique. However a band-aid is better than
acrash and the patch to fix this would be too invasive to get
past Gerrit.

Change-Id: I92e313d0243659b6af374a0cbf8bab18c3f6ba76
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

I forgot to remove this qDebug before submitting the patch which
introduced it.

Change-Id: I14cf6b6ae9b5b3689a38d8947547b08d5a25fa19
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

Change-Id: I2e1a5299956fb9218d03e6429c98fbe15ce22cf0
Reviewed-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>

For QML and tests

Change-Id: I5957cc0e96a8476e60b1d325f00c49d425270bf0
Reviewed-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>

Allows accounts to be created using bindings other than C++ and
also allow the "GammaRay" introspection debugger to work.

Change-Id: I20af7073c01d3002463908daff97073f3fd23a8d
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

It *is* initialized, but some compilers fail to see that and
print a scary warning.

Change-Id: I2f92767f6c0e5186112e814c160841523dbdac5e
Reviewed-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>

Also change a proxy model property to a model interface. The
bindings have trouble exporting the proxies. This is probably a
Qt bug. This has no side effect I am aware of. They both share
the same interface.

Also remove commented out code which inits the role names.

[SS: add change missing from commit msg]

Change-Id: Ib3d2e3ed3b96d9d83a711a9005235d886840dfe5
Signed-off-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>
Reviewed-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>

Make it accessible to QML

Change-Id: Id3d88a1c56a48c8614d56ad80471a7833b1679e0
Reviewed-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>

For the bindings

Change-Id: I90572880acd3b96ec6442f2ad08024909f2c10a5
Reviewed-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>

missing edit in d57d2748 make the next bug still present :
the vcard sent was obtained trough a Person object returned by
contact() from a ContactMethod. But this Person may be never set.

fix : now we use the profile to get the vcard to send within the
ContactRequest.

Change-Id: I150715b45bf564fa7e0fb3fae5b186375dfe0ec1
Reviewed-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>

bug : the vcard sent was obtained trough a Person object returned by
contact() from a ContactMethod. But this Person may be never set.

fix : now we use the profile to get the vcard to send within the
ContactRequest.

[SS: improve ci msg; use Account's profile, rather than selected profile]

Change-Id: I21ef691e3fdd96a6e504989a1178444c0d4b90ef
Signed-off-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>
Reviewed-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>

Also adopt an exit early code style to make it more readable.

Change-Id: I51333e202244fbf14769507696ffae0c3807cc2b
Reviewed-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>

When the user enters a string, it isn't always yet known if it is a
search for registered name, a SIP URI or some local DNS names.

However at some point the choice can be noarrowed down. This is a good
time to set the scheme. This help later on top pick the right account
and hopefully resolve the RingId before placing the call.

Change-Id: Iad8283fc4c6ff2e4cfe189bf216f00720202ce92
Reviewed-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>

There is a code path combination (that should not happen, but is
reachable) that could cause a null dereference.

[SS: add warning log in case it happens to make it easier to track down]

Change-Id: I1c2c2b5be417e9ec74e0ab157c9aadcd0ec4a613
Signed-off-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>
Reviewed-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>

Change-Id: I59a0dd2d74c10479c97292919736f2db5bdcfab2
Reviewed-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>

A missing `break`.

Change-Id: I194ea1446627f2bc862f0309f83076abdde34aff
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

Make sure child Calls of a ContactMethod node are moved to the
Person node when a Person node replaces a CM node.

This should prevent two bugs. One is Calls not appearing in the
smart list. The second is the model not properly signaling the
tree view about the child rows moving.

Change-Id: Ibff9186e8494d930726ccb0e8a0e61d2119bc315
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

Emmanuel Lepage Vallée authored 8 years ago and Adrien Béraud committed 7 years ago

Early versions of the Ring protocol generated a mandatory self
signed CA cert. This isn't true anymore. The error is just noise.

This also fixes the error message. The enum to string mapping was
in the wrong order.

Change-Id: I0ca67b7185065e12a44c15dd5bbd4fdf170a8ec3

Check account new state and update prior Account only in case when
current prior Account became unavailable.

Change-Id: I74fcc1e056a4afc20fe923789be21c17806cc112
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

- mapToPersonFromIncomingContactRequest : this function creates a
Person from a vCard stored by the daemon; we make sure to ignore any
ContactMethods which might be contained in the vCard and only use
the CM from which we receive it.

- PendingContactRequestModel::data now can return :
  * PEER_ID : get the username if possible or ring Id if not.
  * FORMATTED_NAME : get the profile name stored in the vCard.
  * COUNT__ : used to get the number of elements in the enum.

- ContactRequest now store a person. This person matches the vCard.

- PeerProfileCollection updates the CM(s) of the vCards it stores
with the last modified date of the vCard in to get the date at which
the contact request was accepted.

[SS: update commit message]
[SS: change how we restore the ContactRequest accept date]

Change-Id: I3bafda5b38d5e2332e095cd5f1f1d0b101847f86
Signed-off-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>
Reviewed-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>

When a contact is removed we need to remove it from personmodel and update
recentmodel & categorizedcontactmodel.

Change-Id: I09694a901278cdd01f771ea83498613159180e8d
Tuleap: #1050
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

Change-Id: If958f6aa7a89ca3878482b60be5c3905502cac3e
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

And make another method invokable (for the bindings).

Change-Id: If8a1758db5afb0356b9f4891aee30eabe9c25cb3
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

Allows accounts to be created using bindings other than C++ and
also allow the "GammaRay" introspection debugger to work.

Change-Id: I8fe0235e99896699da05bc9f9b0e168dc33fe2af
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

All other variable and argument names start with a lower case
letter.

Change-Id: I3b57208dab0f7afa7969d65ecdc0e098a5d7a48c
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

Change-Id: Ie71c85e220c98df3df6cf0ba76579ae5abc09785
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

Should not happen, but is technically possible.

Change-Id: Icfc4015267fd5d023e45f558f07e974a380b2859
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

Change-Id: Ib5af845fbdc039a8986c680ad650ce04aed66bcc
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

The directory could be read-only and it would create a silent
issue.

Change-Id: I9bff74bcaf0006d59417b0656658fc568b7c425f
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

Minor one. Call has multiple constructor and all of them init
the pointer to nullptr in the constructor body. Still enough
to fire a CI warning.

Change-Id: Ia1a9c532262cf6b1b28dc1bd95090a4d54bcb4da

Change-Id: Iedf125f04c86ba0981693d6592ce91ccf7e00f88
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

Change-Id: I1afb94da51718177ab661f706c7364fa858a6fc7
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

Change-Id: I59c299a00e3bc13bbe85f749a85cbb3ab314e0e3
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

If there are any ongoing calls during the construction of the
RecentModel we want to make sure to sync the selection with the
CallModel, which will normally select the most recent Call.

This is mostly important for clients which run as seperate processes
from the daemon, and so its possible to have ongoing calls at the
time the client is initialized.

Change-Id: I1edd595ee77c03ca294baf44802f00065e8bca2b
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

Never filter out top level items which have an active Call. Most
users will not have more than one Call at a time and they should not
have to take any action in order to interact with the Call.

Change-Id: I1b94f02a51a0ce864397126deaff20821c1d6bf1
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

- return the best Id for the last ContactMethod used with Person.

Change-Id: I015f276074b6d39ddee7d727c3dd09cb7f6e6696
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

To reduce log spam.

Change-Id: I6cc6d49079384f80d8d129e9600ab34a25de3c77
Reviewed-by: Kateryna Kostiuk <kateryna.kostiuk@savoirfairelinux.com>

Only log registered name lookup failures, to reduce log spam.

Change-Id: I4fa65294942a082177587841c91ed89f12acff18
Reviewed-by: Kateryna Kostiuk <kateryna.kostiuk@savoirfairelinux.com>

Change-Id: I84687733c1907fdeab19c2bc6e265807b4a7ff8a
Reviewed-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>