Skip to content
Snippets Groups Projects
Select Git revision
  • 44dcaf01fd73256ae2d826fc3124d41650b81d9f
  • master default protected
  • release/202005
  • release/202001
  • release/201912
  • release/201911
  • release/releaseWindowsTestOne
  • release/releaseTest
  • release/releaseWindowsTest
  • release/windowsReleaseTest
  • release/201910
  • release/qt/201910
  • release/windows-test/201910
  • release/201908
  • release/201906
  • release/201905
  • release/201904
  • release/201903
  • release/201902
  • release/201901
  • release/201812
  • 1.0.0
  • 0.3.0
  • 0.2.1
  • 0.2.0
  • 0.1.0
26 results

jami-libclient

  • Open with
  • Download source code
  • Your workspaces

      A workspace is a virtual sandbox environment for your code in GitLab.

      No agents available to create workspaces. Please consult Workspaces documentation for troubleshooting.

  • Emmanuel Lepage Vallee's avatar
    Emmanuel Lepage Vallée authored
    First of all, [begin/end][Insert/Remove][Rows/Columns] is a
    flat transaction and can only exist once per model. The code
    was calling begin in other begin section due to some
    lazy-loading code. This could result in SIGSEGV if the model
    had active proxies.
    
    More importantly, this code is called from the collections.
    Some collections run in different threads. The class had a
    mutex, but only used it in half the places it should have
    been used. This caused a crash on the macOS and KDE client.
    I could not manage to crash the Gnome client, but it is
    probably possible. ASAN also got asserted due to this even
    when it would have otherwise not crashed.
    
    The commit alse fix a memory leak when the ID was duplicated
    by the race condition. This is a band-aid on the problem: IDs
    potentially not unique. However a band-aid is better than
    acrash and the patch to fix this would be too invasive to get
    past Gerrit.
    
    Change-Id: I92e313d0243659b6af374a0cbf8bab18c3f6ba76
    Reviewed-by: default avatarNicolas Jäger <nicolas.jager@savoirfairelinux.com>
    44dcaf01
    History
    Name Last commit Last update