From a5d29c904c74264bbe16a4860bbf901652e91f11 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adrien=20B=C3=A9raud?= <adrien.beraud@savoirfairelinux.com>
Date: Sat, 16 Feb 2019 18:01:46 -0500
Subject: [PATCH] op cache: optimize cache insertion

---
 src/op_cache.cpp | 2 +-
 src/op_cache.h   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/op_cache.cpp b/src/op_cache.cpp
index eadb3705..b9aa9bcb 100644
--- a/src/op_cache.cpp
+++ b/src/op_cache.cpp
@@ -25,7 +25,7 @@ bool
 OpValueCache::onValuesAdded(const std::vector<Sp<Value>>& vals) {
     std::vector<Sp<Value>> newValues;
     for (const auto& v : vals) {
-        auto viop = values.emplace(v->id, OpCacheValueStorage{v});
+        auto viop = values.emplace(v->id, v);
         if (viop.second) {
             newValues.emplace_back(v);
         } else {
diff --git a/src/op_cache.h b/src/op_cache.h
index 112d5ea5..79cd8f14 100644
--- a/src/op_cache.h
+++ b/src/op_cache.h
@@ -27,7 +27,7 @@ struct OpCacheValueStorage
 {
     Sp<Value> data {};
     unsigned refCount {1};
-    OpCacheValueStorage(Sp<Value> val = {}) : data(val) {}
+    OpCacheValueStorage(Sp<Value> val) : data(val) {}
 };
 
 class OpValueCache {
-- 
GitLab