Account migration will report success, even though migration failed
Issue generated from Tuleap's migration script. Originally submitted by: Nicolas Juneau (njuneau)
Summary
When upgrading an account from a previous version, the wizard can report a successful migration even though it was not a success.
Steps to reproduce
* Have an old Ring account (pre-20170119 build)
* Update Ring through the Google Play Store
* Start Ring
* Enter any password to unlock the Ring account
* Complete the migration
Current behavior
No matter what password was entered, Ring will tell the user that the migration was successful. However, if Ring is restarted, the user will be told that account migration is needed when managing accounts.
Expected behavior
If a failure is encountered, the user must be notified accordingly. Showing a success message misleads the user.
Tested platform
* OnePlus X (Onyx) phone
* Stock Android 6 OS (6.0.1) / Oxygen OS 3.1.4
* Ring installed and updated using Google Play Store
* Ring version : 20170119