GitLab

+ Add backup page
+ Separate PIN/backup
+ Some renames
+ Add connect to JAMS

Change-Id: Ia173231837d6ef560957d99728f1b87447319ccc

Change-Id: I7f132d4c5d7a1e68463cd065015e2639664250f6
Gitlab: #947

Change-Id: Iedda0244d82dd8bdb203fb6f27a7dac115fbca9a

A regression occured with the patch to fix the creation of the
chatview (when reparenting). This patch fix it.

Change-Id: I26a97812e65311619964898d646052d7f8482669

Change-Id: I3cf17e7e508c0abf27400839bedf60e7db3e79b5
Gitlab: #1038

Change-Id: I0fd34b2777bbf7c1ebd26e96ea4fcbb86ac55ad5

Change-Id: I5ce8f86371ac870a0be34098473f88c71214ff3d

Change-Id: Ief3d0ad0d7ce6299c738dbfab80a1d3baa8242b0

Change-Id: I03c19f1e5cafb39ac63e27b4eba26498b71a9076
Reviewed-by: Andreas Traczyk <andreas.traczyk@savoirfairelinux.com>

If the account could not send a text message, the sendMessage bar
will be hidden. Moreover, a SIP account can send a message outside
a call, so this line is totally wrong.

Change-Id: I941b074c94c4f1438e5bcad79344792145f2b652
Reviewed-by: Philippe Gorley <philippe.gorley@savoirfairelinux.com>

Change-Id: I30996659ce276647c216e69e5392ea8e7214ac6e
Reviewed-by: Sebastien Blin <sebastien.blin@savoirfairelinux.com>

Better UI reactivity on account state change:

+ Do not show audio and video call options in the conversationsview's
  popup menu when account is disabled (this doesn't make sense,
  account is not able to place a call)
+ Refresh popup menu on account state change (list of options
  has to be updated)
+ Refresh chatview on account state change (some elements of the
  chatview require update, e.g. message bar)
+ Fix broken display property update in hideControls()

Misc code cleanup, add a few helpers to avoid code duplication.

Change-Id: I212a47566bd65687e5ed61ec56087a4e1f3166bd
Gitlab: #929Reviewed-by: Sebastien Blin <sebastien.blin@savoirfairelinux.com>

Add duplicate number after filename, but before extension, and start
count at 1 instead of 0.

Before, it would be '(0)file.jpg', now it is 'file (1).jpg'.

Change-Id: I8bb35cfce63447cf024e5b5dfb18a0410b507ef6

Do not display both alias and id if they are identical.

Change-Id: I460781e80339e29b55de6b2074e5825f110f712f
Gitlab: #926

g_filename_from_uri can be null and can cause a segfault.
We should avoid this case.

Change-Id: Ie2e52b4c6112ab1a1ee59f641f6752b8feb9ca0b
Reviewed-by: Hugo Lefeuvre <hle@owl.eu.com>
Gitlab: #921

Change-Id: I0cfd9bca1d77a4ab52eda092457d86e7c132d201
Gitlab: #890

Change-Id: Iacc77f28f77fef4da0a315063b1d8abe3ef9ed99
Reviewed-by: Andreas Traczyk <andreas.traczyk@savoirfairelinux.com>

- fix timestamp efficiency issue.
- fix message bar size which was blocked at bigger size when using
  send button instead of return key.
- fix invitation text selection.
- fix bad handling of broken images / paths.
- fix navbar present during call because of WebKit crashes.
- fix ghost navbar during call.
- fix buggy ellipsis due to duplicate ids.
- fix duplicate retry in file transfer ellipsis.
- fix bug where ellipsis was placed at the right side of newly uploaded
  images.
- fix various issues in removeInteraction.
- fix wrapping issues in navbar.

Change-Id: If2f67090c889c1b0efaf21d6f00c72471752b9f8
Reviewed-by: Sebastien Blin <sebastien.blin@savoirfairelinux.com>
Gitlab: #833
Gitlab: #838
Gitlab: #839
Gitlab: #843
Gitlab: #845
Gitlab: #849
Gitlab: #861
Gitlab: #862

The GNOME client should be able to see a conversation even if the
account is disabled. This patch prepares the UI to remove buttons
and the message bar if the account is disabled.

Change-Id: Ic71d6c2b61afb77a7ac9acdeae7de527efaf265b
Reviewed-by: Andreas Traczyk <andreas.traczyk@savoirfairelinux.com>

Change-Id: Ic56f2a360af2f64ab04d7be214ef0f7d73c06196
Reviewed-by: Hugo Lefeuvre <hugo.lefeuvre@savoirfairelinux.com>
Gitlab: #835

Add the ability to send files by dragging a file uri into the
chatview.

Note: clean some warnings

Change-Id: Ia27663e9544462fa897c27d53dfaa274839d23c4
Reviewed-by: Philippe Gorley <philippe.gorley@savoirfairelinux.com>

Add a retry button for failed file transfers and text messages

Change-Id: I29cf6ee87a747855515a6da384a6ef6b5aa82e5e
Reviewed-by: Philippe Gorley <philippe.gorley@savoirfairelinux.com>

Change-Id: I27a0ec40c3215f966a3637f681845b196f5418d7
Reviewed-by: Philippe Gorley <philippe.gorley@savoirfairelinux.com>

Despite of the recent optimization commits, the chatview is still
affected by a significant number of performance issues. This commit
tries to address some of them:

* Use getElementById instead of querySelector, when possible.
* Use getElementByClassName instead of querySelector, when possible.

(querySelector is in average 2x slower than getElementById or
getElementByClassName!)

In this commit we also address the following bugs:

* printHistoryPart: it doesn't make any sense to call
  addOrUpdateMessage if we are at the end of the buffer.
* the bottom padding of the body isn't updated with the size of
  the #message textarea, leading to an annoying overlap when writing
  large messages.
* selection highlighting in the chatview is crappy. The user should
  not be able to highlight the background because it doesn't make
  any sense. Only meaningful elements should be highlightable.
* The first time a message fails to be sent, the cross 'X' icon
  is displayed with a very bad looking shift to the right. This is
  because the 'sending' icon is still displayed, with visibility
  hidden.
* Many variables were not declared / using some broken, ancient
  JavaScript Sith magic we don't want to mess with. In order to make
  sure we are not going to rely on such mechanisms anymore, add
  "use strict" stanza.

In addition to that we also fix a _very_ large number of style issues
(semicolons, indentation, comments) and define a clear style policy
for the JS code.

A code audit revealed several small bugs which we are not going to
address in this commit. Add FIXME comments.

Also, remove some useless debug warnings from the GTK side chatview
code.

Change-Id: If6b605868ba6b0b9623ae01c5293064211b58327
Reviewed-by: Sebastien Blin <sebastien.blin@savoirfairelinux.com>

Currently the navbar is implemented in native GTK, and has a pretty
bad integration with the chatview. In this patch we implement a
modern navbar *in* the chatview and remove the old GTK bar.

*Changes summary*

chatview, HTML/JS/CSS side:
- Remove useless function setSendIcon from the chatview
- Simplify setTemporary in the chatview
- Use only one single showInvitation function instead of two
  showInvitation and hideInvitation functions.
- Remove pointless/copy&pasted comments

chatview, GTK side:
- Simplify chatview update methods: instead of providing several
separate functions to update the invitation/banned status of the chat
view, only provide one (update_chatview_frame). This should have a
good impact on the performances and simplify webkit crash handling.

Change-Id: I6959240efd357fedb07d3c60d551efc8fca84812
Reviewed-by: Sebastien Blin <sebastien.blin@savoirfairelinux.com>

Whenever the chat view has to display a banned contact, it should:
- Make place call, add to contacts and place audio call buttons
  unclickable
- Hide the send message bar
- Display the banned contact as such in the smart list results (grey bg,
  bold "Banned contact", etc.)

This patch implements this behavior in the GNU/Linux GNOME client.

For the moment the conversation popup is still mentioning invalid
options such as «block contact» or «place call», but since fixing it
requires LRC side changes we will address this issue in a separate
commit.

Change-Id: Ibc8da7d755319acae59a807cc248e3a87bd9d6da
Reviewed-by: Sebastien Blin <sebastien.blin@savoirfairelinux.com>

Before:

 - RingMainWindow has an unique_ptr to an AccountContainer
   accountContainer_.

 - each view / secondary class has its own *copy* of the account
   container pointer (given by ringmainwindow using
   accountContainer_.get()).

 - each time the reference to the struct Info is updated,
   accountContainer_ has to be reset()-ed and and the account
   container re-created by the RingMainWindow. This makes *all*
   copies of the account container pointer invalid (hence all
   view / secondary classes trying to access the account container
   before getting updated perform use-after-free / NULL pointer
   dereference).

 - These copies have to be manually updated ! (well, currently they
   are not updated at all)

After:

 - RingMainWindow has a pointer to a struct Info from LRC.

 - Each view / secondary class has a pointer pointing to
   the struct Info pointer of RingMainWindow

 - Each time the reference to the struct Info is updated, the
   RingMainWindow updates its pointer. Since secondary classes and
   views hold a pointer to this pointer, they are automatically
   updated and there is no dangling pointer anymore.

This requires no lrc side changes.

Change-Id: I1329721920a3d42ad623f9fd7202b43700713eed
Reviewed-by: Sebastien Blin <sebastien.blin@savoirfairelinux.com>
Reviewed-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

This patch also removes the pop up file chooser when accepting files.

Change-Id: I3d767a22726017a2fb5210df07894b316db216c3
Reviewed-by: Philippe Gorley <philippe.gorley@savoirfairelinux.com>

Change-Id: Ie2ef8df3a4f348c646d8cb8465e6852267ec8c08
Reviewed-by: Philippe Gorley <philippe.gorley@savoirfairelinux.com>

Change-Id: I3b1abc6432901caec56f6d6147bfefa1de844844
Reviewed-by: Philippe Gorley <philippe.gorley@savoirfairelinux.com>

Change-Id: I404b1d14854c16e32330f024e683db8b88a28868

Add the ability to send and receives files via the chatview.

Change-Id: I529b3e1c75030c3bc2c5e535e9e9584dde9bb4cb
Reviewed-by: Philippe Gorley <philippe.gorley@savoirfairelinux.com>

When rendering large history, the webkitprocess is using a lot of
ressources and freeze during a few seconds.

This patch allows the user to directly have the ability to see
previous history and send messages while history is rendering.

Change-Id: I921070439328f7bfecb57bfbaec43c3dd88d2d14
Reviewed-by: Philippe Gorley <philippe.gorley@savoirfairelinux.com>

Change-Id: Ifb26147e6faf37f5ac4f5ffac582ee069902d382
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

- following lrc modification.

Change-Id: I6710bf59c2b1213c6b1a92b9ddc71d8528f9b7a2
Reviewed-by: Anthony Léonard <anthony.leonard@savoirfairelinux.com>

This method throws an std::out_of_range exception when
given URI argument doesn't exit in current Account.
This exception is almost not handled by the client,
resulting in application crashes.

Change-Id: I1aea181c238c15ab16d51b8477a7779ce3c82a03
Reviewed-by: Sébastien Blin <sebastien.blin@savoirfairelinux.com>

- add a new button inside the chatview for audio-only call.
- add ic_audio_only_call_black_24px.svg for the button.

note: this patch does not affect the behaviour. We still open the
      video page when the call is in progress.

Change-Id: I49afea09c572093ee370752df6df56c3ddda7eb1
Reviewed-by: Guillaume Roguez <guilaume.roguez@savoirfairelinux.com>

We used the registeredname as the best id, but it's not the case, we
need to get the best id from the registeredname or the uri.
note, remove useless TODO linked to the quality.

Change-Id: I1339d20ee1e4dd96c5c53b932b1fe262b6a53783
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

Change-Id: I5ff45632943d09f26ce8c027db3f1e756c990f0c

- change all components of the client to use new models from the lrc.
- remove dead code.

Change-Id: Idb705df6f63fd90de7fdded6c38288dab6ffe31e
Reviewed-by: Adrien Béraud <adrien.beraud@savoirfairelinux.com>