1. 11 Nov, 2019 1 commit
  2. 30 Oct, 2019 2 commits
  3. 29 Oct, 2019 1 commit
  4. 25 Oct, 2019 1 commit
  5. 24 Oct, 2019 2 commits
  6. 10 Sep, 2019 1 commit
  7. 23 Aug, 2019 1 commit
  8. 22 Aug, 2019 1 commit
  9. 21 Aug, 2019 1 commit
  10. 12 Jul, 2019 1 commit
  11. 22 Jun, 2019 1 commit
  12. 02 Jan, 2019 1 commit
  13. 26 Dec, 2018 1 commit
  14. 14 Dec, 2018 1 commit
  15. 05 Dec, 2018 2 commits
  16. 29 Nov, 2018 1 commit
    • Hugo Lefeuvre's avatar
      refresh popupmenu/chatview on account state change · 7e259ac4
      Hugo Lefeuvre authored
      Better UI reactivity on account state change:
      
      + Do not show audio and video call options in the conversationsview's
        popup menu when account is disabled (this doesn't make sense,
        account is not able to place a call)
      + Refresh popup menu on account state change (list of options
        has to be updated)
      + Refresh chatview on account state change (some elements of the
        chatview require update, e.g. message bar)
      + Fix broken display property update in hideControls()
      
      Misc code cleanup, add a few helpers to avoid code duplication.
      
      Change-Id: I212a47566bd65687e5ed61ec56087a4e1f3166bd
      Gitlab: #929Reviewed-by: Sébastien Blin's avatarSebastien Blin <sebastien.blin@savoirfairelinux.com>
      7e259ac4
  17. 07 Nov, 2018 1 commit
    • Philippe Gorley's avatar
      file transfer: rename duplicate files · fe850695
      Philippe Gorley authored
      Add duplicate number after filename, but before extension, and start
      count at 1 instead of 0.
      
      Before, it would be '(0)file.jpg', now it is 'file (1).jpg'.
      
      Change-Id: I8bb35cfce63447cf024e5b5dfb18a0410b507ef6
      fe850695
  18. 21 Oct, 2018 1 commit
  19. 03 Oct, 2018 1 commit
  20. 09 Aug, 2018 1 commit
  21. 24 Jul, 2018 1 commit
  22. 12 Jul, 2018 1 commit
    • Hugo Lefeuvre's avatar
      chatview: fix multiple perfs/style related issues · 61cd0798
      Hugo Lefeuvre authored
      - fix timestamp efficiency issue.
      - fix message bar size which was blocked at bigger size when using
        send button instead of return key.
      - fix invitation text selection.
      - fix bad handling of broken images / paths.
      - fix navbar present during call because of WebKit crashes.
      - fix ghost navbar during call.
      - fix buggy ellipsis due to duplicate ids.
      - fix duplicate retry in file transfer ellipsis.
      - fix bug where ellipsis was placed at the right side of newly uploaded
        images.
      - fix various issues in removeInteraction.
      - fix wrapping issues in navbar.
      
      Change-Id: If2f67090c889c1b0efaf21d6f00c72471752b9f8
      Reviewed-by: Sébastien Blin's avatarSebastien Blin <sebastien.blin@savoirfairelinux.com>
      Gitlab: #833
      Gitlab: #838
      Gitlab: #839
      Gitlab: #843
      Gitlab: #845
      Gitlab: #849
      Gitlab: #861
      Gitlab: #862
      61cd0798
  23. 06 Jul, 2018 1 commit
  24. 05 Jul, 2018 1 commit
  25. 14 Jun, 2018 1 commit
  26. 06 Jun, 2018 2 commits
  27. 01 Jun, 2018 1 commit
    • Hugo Lefeuvre's avatar
      chatview: major cleanup · 368c47c5
      Hugo Lefeuvre authored
      Despite of the recent optimization commits, the chatview is still
      affected by a significant number of performance issues. This commit
      tries to address some of them:
      
      * Use getElementById instead of querySelector, when possible.
      * Use getElementByClassName instead of querySelector, when possible.
      
      (querySelector is in average 2x slower than getElementById or
      getElementByClassName!)
      
      In this commit we also address the following bugs:
      
      * printHistoryPart: it doesn't make any sense to call
        addOrUpdateMessage if we are at the end of the buffer.
      * the bottom padding of the body isn't updated with the size of
        the #message textarea, leading to an annoying overlap when writing
        large messages.
      * selection highlighting in the chatview is crappy. The user should
        not be able to highlight the background because it doesn't make
        any sense. Only meaningful elements should be highlightable.
      * The first time a message fails to be sent, the cross 'X' icon
        is displayed with a very bad looking shift to the right. This is
        because the 'sending' icon is still displayed, with visibility
        hidden.
      * Many variables were not declared / using some broken, ancient
        JavaScript Sith magic we don't want to mess with. In order to make
        sure we are not going to rely on such mechanisms anymore, add
        "use strict" stanza.
      
      In addition to that we also fix a _very_ large number of style issues
      (semicolons, indentation, comments) and define a clear style policy
      for the JS code.
      
      A code audit revealed several small bugs which we are not going to
      address in this commit. Add FIXME comments.
      
      Also, remove some useless debug warnings from the GTK side chatview
      code.
      
      Change-Id: If6b605868ba6b0b9623ae01c5293064211b58327
      Reviewed-by: Sébastien Blin's avatarSebastien Blin <sebastien.blin@savoirfairelinux.com>
      368c47c5
  28. 30 May, 2018 1 commit
    • Hugo Lefeuvre's avatar
      chatview: implement navbar · edad8832
      Hugo Lefeuvre authored
      Currently the navbar is implemented in native GTK, and has a pretty
      bad integration with the chatview. In this patch we implement a
      modern navbar *in* the chatview and remove the old GTK bar.
      
      *Changes summary*
      
      chatview, HTML/JS/CSS side:
      - Remove useless function setSendIcon from the chatview
      - Simplify setTemporary in the chatview
      - Use only one single showInvitation function instead of two
        showInvitation and hideInvitation functions.
      - Remove pointless/copy&pasted comments
      
      chatview, GTK side:
      - Simplify chatview update methods: instead of providing several
      separate functions to update the invitation/banned status of the chat
      view, only provide one (update_chatview_frame). This should have a
      good impact on the performances and simplify webkit crash handling.
      
      Change-Id: I6959240efd357fedb07d3c60d551efc8fca84812
      Reviewed-by: Sébastien Blin's avatarSebastien Blin <sebastien.blin@savoirfairelinux.com>
      edad8832
  29. 07 May, 2018 1 commit
    • Hugo Lefeuvre's avatar
      chatview: clearly display banned contacts as such · 6bbfd876
      Hugo Lefeuvre authored
      Whenever the chat view has to display a banned contact, it should:
      - Make place call, add to contacts and place audio call buttons
        unclickable
      - Hide the send message bar
      - Display the banned contact as such in the smart list results (grey bg,
        bold "Banned contact", etc.)
      
      This patch implements this behavior in the GNU/Linux GNOME client.
      
      For the moment the conversation popup is still mentioning invalid
      options such as «block contact» or «place call», but since fixing it
      requires LRC side changes we will address this issue in a separate
      commit.
      
      Change-Id: Ibc8da7d755319acae59a807cc248e3a87bd9d6da
      Reviewed-by: Sébastien Blin's avatarSebastien Blin <sebastien.blin@savoirfairelinux.com>
      6bbfd876
  30. 01 May, 2018 1 commit
    • Hugo Lefeuvre's avatar
      Refactoring of the accountContainer logic · 6f2ceb12
      Hugo Lefeuvre authored
      Before:
      
       - RingMainWindow has an unique_ptr to an AccountContainer
         accountContainer_.
      
       - each view / secondary class has its own *copy* of the account
         container pointer (given by ringmainwindow using
         accountContainer_.get()).
      
       - each time the reference to the struct Info is updated,
         accountContainer_ has to be reset()-ed and and the account
         container re-created by the RingMainWindow. This makes *all*
         copies of the account container pointer invalid (hence all
         view / secondary classes trying to access the account container
         before getting updated perform use-after-free / NULL pointer
         dereference).
      
       - These copies have to be manually updated ! (well, currently they
         are not updated at all)
      
      After:
      
       - RingMainWindow has a pointer to a struct Info from LRC.
      
       - Each view / secondary class has a pointer pointing to
         the struct Info pointer of RingMainWindow
      
       - Each time the reference to the struct Info is updated, the
         RingMainWindow updates its pointer. Since secondary classes and
         views hold a pointer to this pointer, they are automatically
         updated and there is no dangling pointer anymore.
      
      This requires no lrc side changes.
      
      Change-Id: I1329721920a3d42ad623f9fd7202b43700713eed
      Reviewed-by: Sébastien Blin's avatarSebastien Blin <sebastien.blin@savoirfairelinux.com>
      Reviewed-by: Guillaume Roguez's avatarGuillaume Roguez <guillaume.roguez@savoirfairelinux.com>
      6f2ceb12
  31. 12 Mar, 2018 1 commit
  32. 28 Feb, 2018 2 commits
  33. 27 Feb, 2018 1 commit
  34. 26 Feb, 2018 1 commit
  35. 21 Feb, 2018 1 commit