1. 24 Oct, 2019 1 commit
  2. 01 May, 2019 1 commit
    • Sébastien Blin's avatar
      mainwindow: add some accelerators · e23740ac
      Sébastien Blin authored
      Add shortcuts to perform a lot of actions without the mouse. Also
      add a Keyboard shortcuts window.
      
      Change-Id: If3fe70a27696b03bf4a067d7bbf004116d4ed97c
      e23740ac
  3. 02 Jan, 2019 1 commit
  4. 01 May, 2018 1 commit
    • Hugo Lefeuvre's avatar
      Refactoring of the accountContainer logic · 6f2ceb12
      Hugo Lefeuvre authored
      Before:
      
       - RingMainWindow has an unique_ptr to an AccountContainer
         accountContainer_.
      
       - each view / secondary class has its own *copy* of the account
         container pointer (given by ringmainwindow using
         accountContainer_.get()).
      
       - each time the reference to the struct Info is updated,
         accountContainer_ has to be reset()-ed and and the account
         container re-created by the RingMainWindow. This makes *all*
         copies of the account container pointer invalid (hence all
         view / secondary classes trying to access the account container
         before getting updated perform use-after-free / NULL pointer
         dereference).
      
       - These copies have to be manually updated ! (well, currently they
         are not updated at all)
      
      After:
      
       - RingMainWindow has a pointer to a struct Info from LRC.
      
       - Each view / secondary class has a pointer pointing to
         the struct Info pointer of RingMainWindow
      
       - Each time the reference to the struct Info is updated, the
         RingMainWindow updates its pointer. Since secondary classes and
         views hold a pointer to this pointer, they are automatically
         updated and there is no dangling pointer anymore.
      
      This requires no lrc side changes.
      
      Change-Id: I1329721920a3d42ad623f9fd7202b43700713eed
      Reviewed-by: Sébastien Blin's avatarSebastien Blin <sebastien.blin@savoirfairelinux.com>
      Reviewed-by: Guillaume Roguez's avatarGuillaume Roguez <guillaume.roguez@savoirfairelinux.com>
      6f2ceb12
  5. 31 Jan, 2018 1 commit
  6. 16 Oct, 2017 2 commits