1. 02 Jan, 2019 1 commit
  2. 12 Dec, 2018 1 commit
  3. 31 Jan, 2018 1 commit
  4. 19 Oct, 2017 1 commit
  5. 19 Jul, 2017 1 commit
  6. 27 Apr, 2017 1 commit
    • Stepan Salenikovich's avatar
      prevent crash during Qt model layout change · 3026bb31
      Stepan Salenikovich authored
      Now that we handle the layout change by removing and then
      re-inserting all of the rows in the GTK model wrapper, we need to
      be careful how we handle the selection changes in the tree view.
      The selection will be lost during the handling of the layout change
      so we must ignore this.
      
      This patch adds a way to check if we're in the middle of a layout
      change. Then we use this in the handlers to the selection change
      and other relevant signals to make sure we don't lose the selection
      during this.
      
      This prevents us destroying the call / chat view prematurely while
      sending a text message which caused a crash in some cases.
      
      Change-Id: Ic46a8d9cda718c4c8058918067593ed1734f471b
      Reviewed-by: default avatarNicolas Jäger <nicolas.jager@savoirfairelinux.com>
      3026bb31
  7. 26 Apr, 2017 2 commits
  8. 19 Apr, 2017 1 commit
    • Stepan Salenikovich's avatar
      prevent crash when searching contacts · f842c8b5
      Stepan Salenikovich authored
      We add a check in the GtkQTreeModel api to make sure that the
      GtkTreeIter passed is a valid one for the given model.
      
      For some reason, it seems that in the ContactsView, the GtkTreeView
      sometimes gives us an invalid GtkTreeIter in the GtkTreeCellDataFunc
      callback (eg: render_contact_photo()). This patch prevents the
      client from crashing due to a bad QModelIndex. However, it would
      be worth invesgitating why we're receving an invalid GtkTreeIter
      in the first place.
      
      Change-Id: I0c00f22ea5adbf877b73e2cedb7eacbc20b3f3b6
      Tuleap: #1448
      f842c8b5
  9. 28 Mar, 2017 1 commit
  10. 31 Oct, 2016 1 commit
    • Stepan Salenikovich's avatar
      Filter contacts and history using search entry · dcfb5033
      Stepan Salenikovich authored
      This filters the contacts and history view with the text in the search entry,
      the same way the conversations are filtered.
      
      The new NameNumberFilterProxyModel is used to do this.
      
      Tuleap: #651
      Change-Id: I4a5129a6bd5b495446b5637c069ba87e62d1fb5e
      dcfb5033
  11. 28 Oct, 2016 2 commits
    • Stepan Salenikovich's avatar
      GtkQTreeModel: insert all children on rowsInserted · 4f922f70
      Stepan Salenikovich authored
      In the case of a QSortFilterProxy model, when rows which were
      previously filtered are re-inserted, no rowsInserted signal is
      emitted on their children. To handle this case, we need to
      explicitly re-insert any children.
      
      Change-Id: If46288356a8697477643671d142fe846aa656ae1
      Tuleap: #651
      4f922f70
    • Stepan Salenikovich's avatar
      restore drag&drop conference creation · 1e738fe2
      Stepan Salenikovich authored
      The drag&drop functionality was lost due to the removal of the
      GtkQSortFilterTreeModel in commit
      f6078223
      
      Its restored by adding the drag&drop interface to the GtkQTreeModel.
      
      Change-Id: Icbf8761f6b5a851bff35759b23fac9538e796439
      Tuleap: #1105
      1e738fe2
  12. 26 Oct, 2016 2 commits
    • Stepan Salenikovich's avatar
      Handle layoutChanged signal · 2d4b4728
      Stepan Salenikovich authored
      This implements basic handling of the layoutChanged signal that may
      be emitted by some Q models in LRC. This does not handle all the
      cases, but it should not cause any crashes.
      
      This should allow us to use the filtering and sorting features of
      QSortFilterProxyModels.
      
      Change-Id: I4ae590b6ab9adea75335d6fd4eb71354168e0ba1
      Tuleap: #651
      2d4b4728
    • Stepan Salenikovich's avatar
      Prevent crash if rows moved are inconsistent · ede936f5
      Stepan Salenikovich authored
      Detect when a QAbstratItemModel emits rows moved signals which are
      inconsistent with the model and emit a critical message instead of
      a crash.
      
      Tuleap: #651
      Change-Id: I6edd9fa6a12bab32f484623b3a318fe568bfa6f6
      ede936f5
  13. 04 Oct, 2016 2 commits
    • Stepan Salenikovich's avatar
      GtkQTreeModel: remove warning about multiple columns · a647bcf3
      Stepan Salenikovich authored
      This warning is useless and the wrapper works for models with
      multiple columns, at least in the cases currently implemented in
      LRC.
      
      Change-Id: If0bfb819f77099946df9d87ad54820562ddf9993
      a647bcf3
    • Stepan Salenikovich's avatar
      remove GtkQSortFilterTreeModel · f6078223
      Stepan Salenikovich authored
      This Qt model wrapper class was added because GtkQTreeModel didn't
      seem to work for QSortFilterProxy models; however this does not seem
      to be the case any longer. Either something was fixed in the
      GtkQTreeModel code, or else the initial problem was due to another
      bug. Either way this reduces and simplifies the code base.
      
      Change-Id: I8d1f7bb83c17708e2ef3c544ee32c13a4b2b3e7d
      f6078223
  14. 27 May, 2016 2 commits
  15. 25 Jan, 2016 1 commit
    • Stepan Salenikovich's avatar
      update copyright headers · be87d2c7
      Stepan Salenikovich authored
      Update for 2016. Remove OpenSSL clause since we don't use OpenSSL.
      Fix instances of capitalized 'f' in 'Savoir-faire Linux'.
      
      Change-Id: I92daa0021a25b2af992de3da5b4448e5295c1a3f
      Tuleap: #218
      be87d2c7
  16. 09 Nov, 2015 1 commit
    • Stepan Salenikovich's avatar
      model bindings: add drag and drop interface · c6e9c0fe
      Stepan Salenikovich authored
      This interface allows the GtkTreeView using this model to
      perform drag and drop actions on individual rows in the tree.
      This implementation doesn't perform any drag and drop logic itself,
      that must be implemented by handling the drag and drop related
      signals emitted by the tree view.
      
      Change-Id: If42a89b6d72db542afe3d2a391e39b2a306df812
      Tuleap: #95
      c6e9c0fe
  17. 22 Oct, 2015 1 commit
  18. 21 Oct, 2015 4 commits
    • Stepan Salenikovich's avatar
      compilation: fix compatibility with older gcc · 365dfd1f
      Stepan Salenikovich authored
      Older gcc produces an error during compilation if the array is
      initialized with "int array[x] = {};"
      
      Issue: #80698
      Change-Id: I8be213327cc15e1fff8548a21fdfa47a00b49ceb
      365dfd1f
    • Stepan Salenikovich's avatar
      q tree model bindings: use rows reordered · 0ba98100
      Stepan Salenikovich authored
      Use gtk_tree_model_rows_reordered(), instead of deleting and then
      re-inserting the moved rows, when possible to handle the rowsMoved
      signal as this will keep the slection in the GtkTreeView when one
      of the moved rows is selected. It also prevents us from having to
      re-insert all the children recursively. However, the old technique
      must be kept as this API doesn't handle the case when the parent
      node of the moved rows changes.
      
      Issue: #80698
      Change-Id: I8c7924f8c25a425958adcc6d6bf1554f32dabf20
      0ba98100
    • Stepan Salenikovich's avatar
      q tree model bindings: recursively insert rows · 22de059c
      Stepan Salenikovich authored
      On rowsMoved and modelReset recursively insert all the existing children
      of the top nodes. This is because rowsMoved is handled by deleting
      all of the moved rows during the rowsAboutToBeMoved signal and then
      re-inserting them on the rowsMoved signal. In this case, any children
      of the moved rows must be re-inserted as well.
      
      Issue: #80698
      Change-Id: Ice7c8d453039acd91a55652c802fdf3e427f96e0
      22de059c
    • Stepan Salenikovich's avatar
      q tree model bindings: add missing stamp · fcf8fc6d
      Stepan Salenikovich authored
      The stamp is used to mark the GtkTreeIter as valid.
      
      Issue: #80698
      Change-Id: I1f0d9ad0c655682573a948184287342967e35664
      fcf8fc6d
  19. 17 Aug, 2015 2 commits
  20. 12 Jun, 2015 1 commit
    • Stepan Salenikovich's avatar
      gnome: delete gtk rows on rowsRemoved · e17a2937
      Stepan Salenikovich authored
      This patch modifies the gtk q model bindings to
      delete rows in the gtk model on the rowsRemoved signal
      instead of the rowsAboutToBeRemoved signal. This
      seems to improve the call model view behaviour and
      gets rid of the issue (in some cases) where calls which
      are "over" are wrongfully selected and displayed.
      
      Refs #75435
      
      Change-Id: If0213f6c2112eec719063cab1e79fdf9d8e73c4a
      e17a2937
  21. 19 May, 2015 1 commit
  22. 13 Apr, 2015 1 commit
    • Stepan Salenikovich's avatar
      gnome: add contacts treeview · 6f68707b
      Stepan Salenikovich authored
      Added dependency on libebook1.2-dev in order to fetch
      contacts using evolution-data-server.
      
      Contacts from enabled addressbooks are shown in contacts
      tree view with photos (if available). The same image is
      also shown in the call views.
      
      Double clicking on a contact method should call that
      contact.
      
      Refs #69856
      
      Change-Id: I6bd394a1fa23f6e62dd6e0017bff5050584538f8
      6f68707b
  23. 26 Mar, 2015 1 commit
  24. 20 Mar, 2015 1 commit
  25. 17 Mar, 2015 1 commit
  26. 27 Feb, 2015 1 commit
  27. 26 Feb, 2015 2 commits
    • Stepan Salenikovich's avatar
      gnome: outgoing calls · 297b5d19
      Stepan Salenikovich authored
      Can now place outgoing calls. Can end outgoing
      and in progress calls.
      
      Refs #66962
      
      Change-Id: Ic132533d120e9582e58954c947af4cafd793b6fa
      297b5d19
    • Stepan Salenikovich's avatar
      gnome: incoming call view · 6977184b
      Stepan Salenikovich authored
      Can now accept or reject incoming calls.
      
      Refs #66962
      Refs #67159
      
      Change-Id: Ia68a37efdd71735623e7ef013092450102426d68
      6977184b
  28. 25 Feb, 2015 1 commit