Skip to content
  • Anthony Léonard's avatar
    video: save codec bitrate when quality is not auto · dffb0d6d
    Anthony Léonard authored and Guillaume Roguez's avatar Guillaume Roguez committed
    Commit 1ed6a0fe
    
     revealed a
    case where codec quality is not saved and restored correctly
    when holding/un-holding if quality is not set to auto.
    
    The videoBitrateInfo_ struct of the VideoRtpSession is left to its
    default value where quality is equal to 0. When un-holding a call,
    the quality value to be used by the codec is then equal to 0 which
    put the codec in CBR mode. As the default bitrate on H.264 codec is
    very low (250 kbits/s), very poor quality was noticed on average resolution.
    
    We now initialize videoBitrateInfo_ with the default quality settings
    which makes the restored quality consistent on un-hold.
    
    Change-Id: I23ef27cae953bcf60f1f90b18e042c3affd8ecd0
    Reviewed-by: default avatarGuillaume Roguez <guillaume.roguez@savoirfairelinux.com>
    dffb0d6d