GitLab

Change-Id: I6f1ebfc9d967452fe7d7c7e72e32cf795ae2d85a
Reviewed-by: Sebastien Blin <sebastien.blin@savoirfairelinux.com>

Compresses audio to Ogg/Opus.

Refactors audio recording to use MediaFilter (audio mixing) and
MediaEncoder.

Change-Id: Ib8ee63ac71910782fb21d73d7da5fa5d19893b8e
Reviewed-by: Sebastien Blin <sebastien.blin@savoirfairelinux.com>

Filters were reverted for the release so the binaries wouldn't include
libavfilter (which wasn't yet used).

This reverts commit 1e6a4716.

Change-Id: Ib9790a544b442066265b3fe1ea96313be35eff62
Reviewed-by: Sebastien Blin <sebastien.blin@savoirfairelinux.com>

Change-Id: I0c696b635bd7940d9d9803ecb577ef436943ded3
Reviewed-by: Sebastien Blin <sebastien.blin@savoirfairelinux.com>

Change-Id: I227431a381626abc410dc1f3c06063b39f9200e9
Reviewed-by: Sebastien Blin <sebastien.blin@savoirfairelinux.com>

As contributed by Uwe Kleine-König <uwe@kleine-koenig.org>:
 - https://bugs.debian.org/884249

The compat code needs atleast upnp 1.6.25

Change-Id: Ia5e50dc362a64b4acd252dac5137e2aba4795064

Change-Id: I04466980b941dd943637b1a0002997de7a77114f
Reviewed-by: Andreas Traczyk <andreas.traczyk@savoirfairelinux.com>

FFmpeg may check channels instead of channel_layout, so set both.

Change-Id: I25094b104529e7d5ce3476d580a43fc5a445f48d

Refactors the MediaEncoder class so it can be reused elsewhere in the
codebase.

Concretely, MediaEncoder now supports multiple streams and file formats.

Adds a unit test for MediaEncoder.

Change-Id: I27d6f2e8538809e01fef5c35978a0c35dcf8cae4
Reviewed-by: Sebastien Blin <sebastien.blin@savoirfairelinux.com>

- https://bugs.eclipse.org/bugs/show_bug.cgi?id=518765#c2
  describes a bug that seems to occur during concurrent Jenkins
  builds when /Zi (complete debug information) flag is enabled.
  This patch changes the flag to "C7 Compatible (/Z7)" in an
  attempt to prevent these failed concurrent builds.

Change-Id: I0a777c66651463488352d3e3797b89d5ed1b1791
Reviewed-by: Philippe Gorley <philippe.gorley@savoirfairelinux.com>

Refactors out the common code from video and audio encoding/flushing
into a single method. This reuses code instead of duplicating it.

The method is public in the hopes of being able to reuse MediaEncoder
elsewhere in the codebase.

Allow caller to specify the stream index for the future case that the
AVFormatContext contains multiple streams (recording video and audio).

Change-Id: Ieae52bc453ef66d141a40819ca10fedbd38d9a86
Reviewed-by: Sebastien Blin <sebastien.blin@savoirfairelinux.com>

Change-Id: Ie1c2699f547c78a8c1840ee48f23668848cd13b8

Change-Id: I1bca9d53ed50bb2ff5ca3109fd839a04627c5f03

Changes sip and turn test executable names to match gitignore rules.

Removes dring-sample.yml that is created and modified each time the sip
test runs.

Ignore generated configuration files.

Change-Id: I5e6cc760183763a3448f2d35bd0bf55ba765f746
Reviewed-by: Sebastien Blin <sebastien.blin@savoirfairelinux.com>

Change-Id: I7af53fd3b0f76a9652c8fb4d1faceffefe3a4d1f
Reviewed-by: Sebastien Blin <sebastien.blin@savoirfairelinux.com>

Change-Id: Ib2526273a70c21734fe3e5b12297b1dfdfdc0207
Reviewed-by: Sebastien Blin <sebastien.blin@savoirfairelinux.com>

This reverts commit ea2933d4.

Change-Id: I624c07255f60186a0d1e6610a58956775f91b342

permitPeer was failing because of a bad parsing.
Here we should use the ipv4 mapped address.

Change-Id: If286afc54efc99f8828c6379a6264c9da4285d75
Reviewed-by: Philippe Gorley <philippe.gorley@savoirfairelinux.com>

Change-Id: I1a8f5973cbb5027f4a1ccc3d51029a034bd5c988
Reviewed-by: Sebastien Blin <sebastien.blin@savoirfairelinux.com>

Change-Id: Ia84ed72a0ba48778fcdef404d87fd35f717f64ab

Adds dependency to libavfilter, which provides many useful utilities
such as hardware encoding, mixing audio or rotating video.

Access to libavfilter is done through the MediaFilter class, which takes
a filter graph string and AVFrames as input and outputs filtered
AVFrames.

Adds unit tests for MediaFilter.

Change-Id: I0bf3869a9f19ad9cbbe1fc5e2d37eb83ece66ccc
Reviewed-by: Sebastien Blin <sebastien.blin@savoirfairelinux.com>

Some unit tests generate a dring configuration file. Have git ignore it
so it is not accidentally added to the repo.

Change-Id: I6f491d1c4f49606e9fa4d0dc42324919cd88c7ce

Change-Id: I6ab8a0078f7b67b2342859e216ab4ff02d721736
Reviewed-by: Sebastien Blin <sebastien.blin@savoirfairelinux.com>

Allows to get PJSIP logs on Android, where stdout is not logged.

Change-Id: I6db7734dd608f3c8085bc7ed6cf0341ff3c9c787
Reviewed-by: Sebastien Blin <sebastien.blin@savoirfairelinux.com>

Currently, when a file is sent, the peer needs to accept the transfer.
So, connections with this peer will be opened until the peer accepts or
not the file. Since the multi-device support, it's a problem because
the peer has to accept/refuse the transfer on each devices.

To avoid to leave unused connections while we are using the turn,
we need to close these connections. This patch add a timeout to
outgoing file transfers. So, after 10 minutes with the status
awaiting peer, the connection is closed and the transfer canceled.

NOTE: the peer will still see the awaiting_host status even if the
connection is closed, but it's a known bug and it will need a major
change of the blocking startNewFile function in FtpServer.

Change-Id: Ic6e3a2bfebad92cc5c64f5ac2355c3c3765752c9
Reviewed-by: Philippe Gorley <philippe.gorley@savoirfairelinux.com>

With the current implementation, when a user send a file to a contact
who got several devices connected, a request will be sent to all of
these devices and the first which answer will get the transfer. So,
a user can't know on which device they will get the file.

With this patch, in the same configuration the peer will receives
the file on all of its devices and add the possibility to accept
or refuse the file. To avoid to see multiple file transfers because
a peer has several devices, I introduced a OptimisticMetaOutgoingInfo
which represents the best current state of the transfer (for example,
if one subtransfer is ongoing and one failed (cause refused) it will
show the outgoing one).

This is an ongoing work, in the near future we must:
+ Give the ability to clients to see the real status of each
subtransfer (with the ability to cancel/retry transfer by devices)
+ Add a timer to close awaiting transfers to avoid to let a unused
connection for too long.

Change-Id: I84eb243bff2bfdc087a83dd7eced45c361f27d16
Reviewed-by: Philippe Gorley <philippe.gorley@savoirfairelinux.com>

Change-Id: I97bc9a5c10f08a8b109fd1add0a5ff7ac1024ef5
Reviewed-by: Sebastien Blin <sebastien.blin@savoirfairelinux.com>

Second attempt to fix a heap-use-after-free found with ASAN.
First attempt is broken (commit b2e56f84)

Change-Id: I923963ec0a25d768c69c76d506d5bc5dedb6181f
Reviewed-by: Sebastien Blin <sebastien.blin@savoirfairelinux.com>

This reverts commit b2e56f84.

Change-Id: I832bcfe0e2994e82d33951a6499ba43345db1a69

Change-Id: I86d2bfcf88a2a2b0eac50e4bb2b1c74359f84f76

FFmpeg has the convenient macro av_err2str, but it cannot compile using
g++ (https://ffmpeg.org/pipermail/libav-user/2013-January/003440.html).
Adds an equivalent function for C++.

Change-Id: Ie9eb2c0dfe68c58fd6a5ff82a3729ff63b736a69

it points to an element of the servers_ map. When we call
servers_.erase(it), we free this element. Currently this is done
before calling connectedPeers_.erase(it->first.second) and
turnEndpoints_.erase(it->first.second) hence resulting in heap use
after free.

In this patch we change the order of operation so that
servers_.erase(it) is done at the end.

Change-Id: Ie1b87ebc83e39db189ed651690e9e1dce3496b41

Change-Id: Icce9d2e5a126421e853463a05538d4e75184ab75
Reviewed-by: Andreas Traczyk <andreas.traczyk@savoirfairelinux.com>

Change-Id: I03397f2a9c558b2969f4ce1d177b4905aff6b584

Change-Id: I3b0e6d5c6dde3f3258663e899c20f955796cf018

Change-Id: I18bc747595054ef3228194c694530ba5899d4ff9

Before this patch a message got a failed status after 3 minutes
(3 retries x 1 min). Moreover, if no devices was found, the message
is keeped in the cache and wait for the next reboot. So it results in
extremely long sending status, which is not really useful for the user.

With this patch, the message fails to send after approximately one
minute, if the user is connected and we do not receive an answer
or if no device is found.

Change-Id: I41171be2ebfebc424f96b4a4d42c360ad35ede86

Refer to the actual gnome-ring executable name
in the dring manpage.

Change-Id: I8a32c1c1124f10532fc824cafeb0a820cf01e571

Change-Id: I57b749e9f7819710a691eaa2839092e04dc86fcc

Do not delete an object of derived class type through a pointer to
its base class type that has a non-virtual destructor. Instead, the
base class should be defined with a virtual destructor. Deleting an
object through a pointer to a type without a virtual destructor
results in undefined behavior.

Change-Id: I5a9f1ade5d67056f9ebc2865bd3c1c17fe197fcf
Reviewed-by: Sebastien Blin <sebastien.blin@savoirfairelinux.com>