GitLab

Many function/method pass shared_ptr by copy and not by (const) reference.
As explained here [1], if the smast pointer is not supposed to be modified
and used as an output argument, it's a bad usage as we cause
an uneeded copy. As this copy causes a memory lock this lead to CPU
and memory cache lock bad usage.

This patch converts all these by-value into by-const-reference
on all shared_ptr arguments over the daemon sources.

[1] https://herbsutter.com/2013/06/05/gotw-91-solution-smart-pointer-parameters/

Change-Id: Ic1e68d93a6917f5e2865b6818b7c1210ff98b1a8

Some builds, like OSX and Debian 8, fails to build the daemon
as a patch has recently introduced a C++14 feature, but we don't
support C++14 by default on all platforms.

This patch changes the code to require only a C++11 compiler.

Change-Id: Ib858a6abddb610b6f94cedc01945c0de92f00687

- adds fetch scripts for gmp, nettle, iconv, and zlib
- adds fetch script all contribs

Change-Id: If54204187c546b22a1a209747bce64f0fafac1fe
Tuleap: #790

Add support for Ring device revocation.
Each device manages a local revocation list, synced with
other devices linked with the account.
When a device is revoked, its certificate is added to the
local certificate revocation list (standard x509 CRL).
CRL support from the trust store and OpenDHT is used.

Tuleap: #1457
Change-Id: I227e21afb3234e70ad562a5a4d0cf1084d61f174

Change-Id: Icfaf6afb1813619ce8119cc4bb1d224db55e9976
Tuleap: #790

Change-Id: I1ab520134eb09f6801e820b5ec87967b14056027

- uses a signal that is emitted when retrieving various folders
  used by Ring.

- uses CreateFile2 in the writeTime function, in accordance with
  the Windows UWP API.

Change-Id: Ie03255fd8d9d5bd298a17025a8110852ec573aa1
Tuleap: #790

Change-Id: Ic39556204f2724e7b33d3055b58e184030a245aa
Tuleap: #790

- adds a video device implementation and a barebones video device
  montior implementation for UWP.

Change-Id: I69108c688f0e55fea1776708919b881afae42552
Tuleap: #790

Change-Id: I86c52900c2e20be5f7c331126180c37f0e17719c

Remove the RING_ERR call with directory argument doesn't exist
when fileutils::readDirectory() is called.

This function returns an empty result if such case that's enough
for callers to log something if they want. but not log (as error)
by default, more annoying!

Change-Id: I0f1fff604de70997f3f6419ccd050687629e10d4

This prevents collisions when two different archives
due to hash update are downloaded.
This is great help for build system with a dl cache.

Change-Id: I9ed5e53d54dca69f07f2d315aba9c20c71d41688
Reviewed-by: Romain Bertozzi <romain.bertozzi@savoirfairelinux.com>

Previous implementation was duplicating authorization
checks between incoming call and message.
Add two methods to factorize the checks:
* foundPeerDevice will check the validity of the peer certificate chain
* onPeerMessage will check the validity of the peer certificate chain,
  perform authorization checks using the account trust store (async),
  and call the provided callback if the peer is authorized.

Change-Id: I80833a73c6842c9e84677fcaaef2a543745e005b

Change-Id: I622bf805664ce788209ff49e2c7850fbf1cb5687
Tuleap: #790

Change-Id: I6dbc51dd41c1f44d1446fe7365026af037bc86d9
Reviewed-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>

Change-Id: I89d72ed0225f351b0d72c0d9084926d52551f45a

Change-Id: I7de7dda5f11e0a86a6335e8806c4f2dfd79caa9f

Change-Id: I894dafe7f91f6232e2123a372feef614049b5e59

Add certificate revocation list support to the
CertificateStore.

* Uses new OpenDHT CRL crypto API (bump to new version).
* Stores CRLs in .local/share/ring/crls/{cert_id}/{crl_number}
* CRLs are associated to the corresponding certificate authority.
* CRLs are used in certificate checks.

Change-Id: I1aa86d9bbd5631f5c38bccc69e1e9125b8f8b2cc

Multi-device account migration used a certificate without the CA flag
to sign the device certificate, preventing to properly validate the
device certificate chain.
Fix this by reusing the existing account migration API to ask for the
account password when the case is detected, placing the account in the
ERROR_NEED_MIGRATION state.
ERROR_NEED_MIGRATION could also be used for future account migrations,
when the password is needed to unlock the archive.

Bump OpenDHT to check the certificate expiration date.

Tuleap: #1434
Change-Id: I5527cf5bd31310d969819570cd984e622029fa71

This functionality of RingAccount exposes methods to "track" a buddy with it's
ringid. The RingAccount keeps a map of BuddyInfo for all buddies to track. The
BuddyInfo struct contains the last time the device has been seen online.
RingAccount exposes the following methods:

* ::trackBuddyPresence which will look for a buddy's DeviceAnnouncement on the
  DHT to deduce the buddy's presence. This will be done each 10 minutes
  (DeviceAnnouncement expiration time).
* ::getTrackedBuddyPresence which returns the relevant content from the map of
  BuddyInfo, i.e. if each of the buddy is online or not.

Change-Id: Ib149585c4835da88b0b0248b4a866770d35afe90

Change-Id: I648876cae97267cbc2eac2343f5fcde6970a487f
Tuleap: #790

Do not depends on build system to have valid
definition of strings used for library version.
Define defaults values in such case.

Change-Id: I4512bb0815fe6a875bab96395bfcc83a344ef69e

- defines ssize_t in ice_socket.h and utf8_utils.cpp for
  Microsofts compiler.

Change-Id: I46131f613a35cabae9df7749221ba2f30d7fd888
Tuleap: #790

- Removes the usage of getenv for log levels on UWP apps, as
  the notion of environment variables doesn't exist for apps, and
  getenv is not included in the UWP API.

Change-Id: Ifd1e981d9c3fafd64422251a38d991150e8a6fb8
Tuleap: #790

- adds compiler_intrinsics.h to MSVC project and replaces
  reference to WIN32_NATIVE with RING_UWP

Change-Id: I4ab3c1e849488f75043e28ed56763a87c62757e5
Tuleap: #790

Ant 1.9.7 is not needed anymore in our build process and since it is not
distributed anymore by apache, instead of bumping to 1.9.8, remove it.

Change-Id: Iac91d47aa74bbba5161d641b7f19564a517f89bf

Add method to retreive the hostname,
to fill the default device name.

Change-Id: I5aafe8d0413caa13c4fdf720f6f3ce8b0577d238

- system is not supported in the UWP API

Change-Id: I884e998f499a8c19aa52db1d67df5b90ac890587
Tuleap: #790

- Adds #pragma message to replace #warning directive

- Defines _WIN32_WINNT to windows 10 (0x0A00) which allows
  IN6_IS_ADDR_UNSPECIFIED to be defined in ws2tcpip.h

Change-Id: Id2406815830f24bbed744cbaca98dbd4fbcf515d
Tuleap: #790

- prevents error C2910 which disallows explicit specialization of
  a member function outside the class if the function has already
  been explicitly specialized via a template class specialization.

Tuleap: #790

Change-Id: Idde2413707abf0ef65a3445ea1d577c0394c7121

- Causes the UWP build condition to use thread_local when
  registering threads with pj_thread_register(), as __thread is
  not available. Note: __declspec(thread) is also equivalent.

Change-Id: Ibee418d4c7084264acb0591015cdb8f72abc50ba
Tuleap: #790

- replaces the WIN32_NATIVE flags from older patches with RING_UWP

Change-Id: I7e49006189111c7d05f547dc783d34703ae80f40
Tuleap: #790

- Microsoft's compiler doesn't support C99 designated initializers.
  Hopefully this we be added in the future, but for now we can
  comment the '.fieldname =' to achieve the same initialization,
  as long as all the elements are initialized in the fixed order
  that they were declared.

Change-Id: I38af2eb66d583ef8f280ff8b4c7065c7d8229c02
Tuleap: #790

This factorization decreases code lines and increases
maintainance factor.

Change-Id: If79a20594ccbfbab0ced400d5fff606afa6474dd

- includes <functional> in media_buffer.h for std::function.

- forward declare AudioFrame and DeviceParams as structs in
  media_decoder.h, as they are both defined as such.

- remove AVRational compound literal from media_encoder.cpp.

- use a #pragma message instead of a #warning in Visual Studio

Change-Id: If32cfbb7504d65c9687814dcc3b5dfa859017fc5
Tuleap: #790
Reviewed-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

- Notification tones for calls incoming when there is a call already
  in progress were using time_t objects to calculate the passage of
  time. This patch implements time_point objects instead, thus
  removing a dependency on sys/time.h which is not available on
  all platforms.
Reviewed-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>
Change-Id: I3850706e2f6ddb3fd5d308148883031a9cd0cb6b
Tuleap: #790

Use many C++11 stuffs to make the code clearer and well strutured:

* pimpl idiom to remove the portaudio.h dependency from header file
* array and for-range
* algorithm

(And various little changes for coding rules compliance)
Reviewed-by: Andreas Traczyk <andreas.traczyk@savoirfairelinux.com>
Change-Id: Iaa11e16aecb1bd36200c820e4cb1aa657479eb60

fix warnings generated by our files.
Reviewed-by: Andreas Traczyk <andreas.traczyk@savoirfairelinux.com>
Change-Id: I8b5b4d4c74ddfac6b3e40ae79f7382133632f9f2

Modifying accounts order now triggers an "accounts changed" signal.
It seems a more consistent behavior with others accounts modifications
and is now used by the android client.

Change-Id: Id74c5d03d624690f6506b04aebb58c997bc8f9d4
Tuleap: #1367
Reviewed-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>