Commit 0fb5dd82 authored by Guillaume Roguez's avatar Guillaume Roguez Committed by Alexandre Lision

call: append override keyword to virtual methods where needed

This good practice prevents against silent API changes that cause
wrong method resolution.

Issue: #79703
Change-Id: Ic71e3d6e590106cfae439c4db3a874c5e51ec7d0
parent 31d39a79
......@@ -121,19 +121,19 @@ class IAXCall : public Call
int format;
iax_session* session;
void answer();
void answer() override;
void hangup(int reason);
void hangup(int reason) override;
void refuse();
void refuse() override;
void transfer(const std::string& to);
void transfer(const std::string& to) override;
bool attendedTransfer(const std::string& to);
bool attendedTransfer(const std::string& to) override;
bool onhold();
bool onhold() override;
bool offhold();
bool offhold() override;
//TODO: implement mute for IAX
void muteMedia(const std::string& /*mediaType*/, bool /*isMuted*/) {}
......@@ -141,14 +141,13 @@ class IAXCall : public Call
//TODO: implement restartMedia for IAX
void restartMediaSender() override {}
void peerHungup();
void peerHungup() override;
void carryingDTMFdigits(char code);
void carryingDTMFdigits(char code) override;
#if HAVE_INSTANT_MESSAGING
virtual void sendTextMessage(const std::map<std::string, std::string>& messages,
const std::string &from);
void sendTextMessage(const std::map<std::string, std::string>& messages,
const std::string &from) override;
#endif
void putAudioData(AudioBuffer& buf);
......
......@@ -146,29 +146,29 @@ class SIPCall : public Call
void sendSIPInfo(const char *const body, const char *const subtype);
void answer();
void answer() override;
void hangup(int reason);
void hangup(int reason) override;
void refuse();
void refuse() override;
void transfer(const std::string& to);
void transfer(const std::string& to) override;
bool attendedTransfer(const std::string& to);
bool attendedTransfer(const std::string& to) override;
bool onhold();
bool onhold() override;
bool offhold();
bool offhold() override;
void switchInput(const std::string& resource);
void switchInput(const std::string& resource) override;
void peerHungup();
void peerHungup() override;
void carryingDTMFdigits(char code);
void carryingDTMFdigits(char code) override;
#if HAVE_INSTANT_MESSAGING
virtual void sendTextMessage(const std::map<std::string, std::string>& messages,
const std::string &from);
void sendTextMessage(const std::map<std::string, std::string>& messages,
const std::string &from) override;
#endif
SIPAccountBase& getSIPAccount() const;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment