GitLab

GTK client uses D-Bus, so is unable to forward exceptions.
This causes crashes of daemon (unhandled exception).

This patch changes DataTransfer API to not throw (noexcept).
This is an important changes, not backware compatible,
so the API version has been modified consequently.

Change-Id: I9f2a2fe1732b2622ace16225b6e792dc15383ba1
Reviewed-by: Anthony Léonard <anthony.leonard@savoirfairelinux.com>

- I'm not sure why this was done, but it will cause a deadlock now
  as doUnregister is locked to prevent asynchronous calls.

Change-Id: Ia98c3265313bc000992c5afa8fc737bdd5b35dcd

When the TLS session was closed during path mtu discovery,
the EINTR signal was captured by the retry loop, causing
it to loop indefinitelly as the state of the session was
TlsSessionState::SHUTDOWN ; each retry triggering another EINTR
from TlsSessionImpl::waitForRawData, making gnutls_heartbeat_ping
to return GNUTLS_E_INTERRUPTED on the pong wait).
the guard to this loop was modified to take into account the state
of the session on GNUTLS_E_ITERRUPTED.

Another do/while loop was guarded by the same condition in
TlsSessionImpl::send, the same countermeasures have been
put in place.

Change-Id: Ib2ab8975c8044d9bac0abdcace94d79b5eeb75b9
Reviewed-by: Philippe Gorley <philippe.gorley@savoirfairelinux.com>

Due to restbed attempting to download tarballs at the time it is
unpacked.

Change-Id: I468c5035ea1351264a6040a7fd86df48ee1fc4c9

Use of an invalid ringId could lead to adding
an invalid contact to the account.
Prevent this with a check in addContact and updateContact

Change-Id: I2e396425cf0283e63c2262d8aca6724edf1d9f17
Reviewed-by: Andreas Traczyk <andreas.traczyk@savoirfairelinux.com>

Include the fix for the 2038 bug.

Change-Id: I1a5f37ea4fe15bc0bd4c3949f913c3498b74c1f6

Change-Id: I5cd9cc6dd57d3c6447b397cc486cb82c48b2ea85

- with upnp enabled, calls to doRegister_ are threaded, and multiple
  calls to setAccountDetails could trigger an access violation
- this patch adds locking at the beginning of doRegister_ and
  doUnregister

Change-Id: I8e5af60b319b6a823044a1e202af5f5af9d9b166

Change-Id: I538d3a777380d8c8c55c0999705a957a522a4a86
Reviewed-by: Andreas Traczyk <andreas.traczyk@savoirfairelinux.com>

- adds rfc6062 patch for pjsip 2.5.5 for uwp
- updates files built by the vs project (adds some related to file
  transfer, removes those that are deprecated)
- corrects native build problems
- simplifies project layout
- links the minimal client with libdl(temp fix)

Change-Id: Ib82b0470f568cb79dc1f4353cb5a5ef20de93033

These files comes from sflphone ages, are not relevant, not working and
may confuse people who read them.

Change-Id: I8186c35a36665ef077df38d508e6977e1f833bc9
Reviewed-by: Anthony Léonard <anthony.leonard@savoirfairelinux.com>

Merges setupFromAudioData and setupFromVideoData to reduce redundancy

Change-Id: Id543d0775a7803b778796b9abc02c9decd2c7e15
Reviewed-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

rxQueue_ was not protected on one place causing troubles
and crashes in case of conccurent accesses.
Add a mutex lock to protect it.

Change-Id: Icca7516c325d321a1d8773dbb9e1cd2a18036c41
Reviewed-by: Adrien Beraud <adrien.beraud@savoirfairelinux.com>

* declare NDEBUG for library and contrib
* activate pjsip extra checks as all PJ_ASSERT's are deactivated

Side effect: pjsip does not call abort() due to disabled assertions.

If debug is required:
* contrib: call bootstrap with --enable-debug
* libring: call configure with --enable-debug

Change-Id: I47b104c0f32352f0503457a9d419c4ed5db4e126

Change-Id: I727797f8ee048cf23c70c54293b5cd8035206245
Reviewed-by: Anthony Léonard <anthony.leonard@savoirfairelinux.com>

Change-Id: I2e23a83ae992c4ed0063dafff34d3a49ee006681
Reviewed-by: Andreas Traczyk <andreas.traczyk@savoirfairelinux.com>

PeerConnection eventloop was blocked on receiver side
on a read() call.
Use a polling method to let possiblity to event msg to
be handled.
This fix non-working data transfer cancelation.

Change-Id: I602b6ba27091e59ad0978f4e4023204d39ee8223
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

* protect against write() call on a closed incoming stream.
* Use DataTransferEventCode::closed_by_peer when
data are not completly received, else ataTransferEventCode::finished
is emitted.

Change-Id: I15f2518f70afbe1bfe8aa8813cbca676dec4360a
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

OpenDHT 1.6.0 unifies its API so users don't need to use
extra build flags.

Change-Id: Iea965def553a1a059cc9c41d3ff15ab96b2a8f31

At reception, output file was not closed due to silented exception
before the close() call.

Change-Id: I9f2bb2dd29db74391fb95acfa97863b4a118189f

Change-Id: Ic2e8c8feb5e29f5c8787c0b9520f060cf20e917d

remove inexistant variable

Change-Id: I86db7aedb7151b508b4d52ad6bc8224d7386810a
Reviewed-by: Maxim Cournoyer <maxim.cournoyer@savoirfairelinux.com>

* Bump restbed for OpenDHT, update patch and add patch to react
  to timeout and socket closed in restbed.
* Bump OpenDHT to support push notifications
* Add DRing APIs to support setting a client push notification token
  and to retransmit push notifications to dring
* Implement proxy support in RingAccount

Change-Id: I8d3a02cf54a9666a94ab992ee3fa2958e82aa7ad

some devices are providing their framerate ratios in a format
incompatible with FFmpeg encoder.
This patch sanitizes these entries to fit the FFmpeg code.

Change-Id: Ib25c33699749ddcdfdf9cefc853f24caae433609
Reviewed-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

- Seperates coreaudio implementations for iOS and OS X.
- Manages input/ouput port overrides when layer is reset via calls
  to Dring::setAudioOutputDevice in response to an audio route override
  event listened for by the iOS client.
- TODO: use AVAudioSession API with graphs in Objective-C++, or
  optimally, in Swift in the iOS/OS X clients.

Change-Id: I6ba34a8bdce7bedd3b9e9ca9bbcd2cc8caccf3f4

TLS session was busy in handleStateEstablished()
during a data-transfer in "wait_host_acceptance" state.
Use a simple thread sleep instead of waitForData() to solve the issue.

Change-Id: I38b7a036863da950202597d52debbfff3329b875
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

Trigger "created" signal of data transfer after
the id is registred, not before.
This fix getTransfer() called in the created emit call scope.

Change-Id: I0d02a3902c56fd60fced60d90248c6ac5e13ae41
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

To dectect TCP RST event at initiator side this patch does
following actions:

* add waitForData() implementation everywhere
* forward transport errors by TLS session.
* use waitForData()/read() inside PeerImplementation eventloop
  to detect read() broken pipe error transmitted by TLS.
* ignore SIGPIPE signal (detected by read now) to not stop the application.

Change-Id: Ia5721e11ce52ba606a5395ecda3122b64f4afa6d
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

remove a start done right after file accepted.

Change-Id: Ia0be8f08de627041c3d5e07478922fb59c2d0be2

when the remote (server) has a IPV6 interface selected by ICE,
and local (client) has a IPV4 selected, the path MTU discovery triggers
errors for packets too big on server side because of different
IP headers overhead.
Hence we have to signal to the TLS session to reduce the MTU discovery
packets payload size on client side accordingly.

[GR: use GenericSocket class to export local/remote address]

Change-Id: I724b97c9ccd5e7240a87fb60ef000b4485710131
Signed-off-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>
Reviewed-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

Implementation based on dht::crypto::TrustList was not able
to remove the disconnected peer (API to do so doesn't exist).
Re-implement another system to check incoming TLS certificates.

Change-Id: I230775d22dde0b4b0a6768b7db3c94faef56634b
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

FTP/IncomingFileTransfer classes were not designed correctly
to talk between them.
This patch moves the file handling into IncomingFileTransfer class
and FtpServer only handles FTP protocol.

Change-Id: Ia12777dcb064b69b04bd5b6b3defc3ba3e84b2c3
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

This fixes the Debian stable build.

Change-Id: I5a59beb34e3379c8e950a4325ef62d3810be84f4

Change-Id: I2c08bb0bc21384bffeb03abea453ceae4928767d

Change-Id: Ib623f8b1cd90f0cfac28409da72e992de9d11548

Change-Id: I7428bbc065224cdb5c46b6d8aceeab3c28d848ba

AVBufferRef leaked its contents after call to openDevice.
- openDevice renamed to initDevice to better reflect its purpose
- initDevice now responsible for all setup and cleanup of device

Change-Id: I2fc36b6b0fe84158bb62fa2dac0cf441716ac540
Reviewed-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

Change-Id: I1ef88bc640f79790aad2b5285ea2c776aa8cd366

Change-Id: I1293f52e9b5255d30faf2dd4c2537831ff05062d
Reviewed-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

Fill AccountId and Peer field of outgoing and incoming data transfers.

Change-Id: I772e9c4560fb63c30e33c341cd296cacd6a45df6
Reviewed-by: Anthony Léonard <anthony.leonard@savoirfairelinux.com>