GitLab

Add override marker to explicit from where functions come from

Issue: #80598
Change-Id: I957afd713de22016220786145471d87c211064c8

Issue: #80355
Change-Id: I8d0a1c0391aa33b9c01e3cd1f1ed315e1a68fe14

This patchset adds information about jitter buffer used in rtpdec.
The first patch prints as warning when jitter buffer is full.
The second patch prints as verbose jitter buffer size set by default in
libav headers or by application.
The third patch prints as waring when max delay on jitter buffer is
reached

Those traces are helpful to know the origin of decoding issues.
Indeed a jitter buffer full or a max delay reached will lead to packet
reordering failure and then to video decoding failure.

Issue: #80483
Change-Id: I7f123f04fe67c279391f153db5ea6f472759f8b2

This patchset adds information about jitter buffer used in rtpdec.
The first patch prints as warning when jitter buffer is full.
The second patch prints as verbose jitter buffer size set by default in
libav headers or by application.
The third patch prints as waring when max delay on jitter buffer is
reached

Those traces are helpful to know the origin of decoding issues.
Indeed a jitter buffer full or a max delay reached will lead to packet
reordering failure and then to video decoding failure.

Issue: #80483
Change-Id: I1351e9b607fd2ffa1223209389cfdb6162c9c93b

Add of audio and video codecs selection in config

Issue: #80498
Change-Id: Ic10a6f2894cec9732b7fbbe3a76ccdd3c4bb858a

This patchset allows ring application to tune 2 parameters of
libav jitter buffer:
- buffer size: maximal amount of packets to be queued
- packet delay: maximal amount of time a packet can be queued

Tuning those values allows correct handling of packet reordering issues
and network jitter.
Notice that for the moment default libav values are set.

Issue: #80311
Change-Id: Ife4be65a12a01e381bc952b07741104f9a969213

Use a config file (test_config.ini) to configure test environnement
test_config.ini is provided as example

Issue: #80498
Change-Id: If0613d2264412af50e42f0a0eb151ecf741cbab4

Refactor of automatic call test tool
Now do ./dringctrl --help : all test name will be listed
./dringctrl --test <testName> to execute a test

Issue: #80498
Change-Id: I86d16e7d96f04f040133f16856ba9ca8a061374d

Default trace level is ERROR. In order to investigate
video decoding issues, I change it to WARNING
After stabilisation, we should reset it to ERROR.

Issue: #79686
Change-Id: I2e77e1759e46748ddbef6f6a60c6cba55c4d0a41

RTCP RR packets are parsed and information is stored in
RtcpInfo struct.

Issue: #78983
Change-Id: I07538e08f5dd4e2635ea94070e16e286f879b358
Signed-off-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

Restricting to one causes problems on Android, where it is sometimes necessary
to restart the daemon during the same execution runtime.

Issue: #77994
Change-Id: I36bd27c82dd627f7b0645eb8620850ff6c0c9fe8

Issue: #80355
Change-Id: I79b5a51549c30f0af14889d4e1d79ff32685de5c

Was not working with the NDK tool chain

Issue: #78221
Change-Id: I7b8fd4eaebce410b41efe955b0fa800cf8319d4c
Signed-off-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

- removes functions to create XML uri list, which are no longer used
- without these functions, lib expat is no longer required

Issue: #79618
Change-Id: I8511d09dc707f3244700f4d396c7f81a01176982

jitter buffer size is by default equal to 10.
We see often packets reordering (on internet) that can not be managed
by jitter buffer sized to 10. We increase the jitter buffer size to 30.

Notice that it would lead to more latency and thus potentially to
desynchronisation

Issue: #80311
Change-Id: I8e6ba6faea2be74602c5e63fded1b0d896c7a847

This supports both simple and multipart content types.

*WARNING* the daemon API has not changed; however the previous
implementation was not RFC compliant and thus messages sent from or
received by a previous version of the daemon will not be interpreted
correctly. Additionally the behaviour of the API has slightly changed.
It will no longer split multiple message pairs received in the
map<string, string> into multiple, separate SIP messages if they do not
all fit into one. If there is only one pair in the map, then a message
with a single content-type will be created and sent. If multiple pairs
exist, then a multipart/mixed type message will be created. If the
created message is too large to be sent, then no parts will be sent.

Support for storing the URI of the original sender is dropped for now as it
was not being used by the clients and the implementation was buggy.

The APIs for creating XML recipient lists as defined by RFC 5365 remains
but is no longer used for now.

Issue: #79657
Change-Id: I2b00cbd797fbb423ee0a7eb24748d2362e9f9ff8
Signed-off-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

Macros (C relica) are easly transformed into C++ using constexpr.
Using template provides type-safe.

RING_ARRAYSIZE becomes arraySize.
CONST_PJ_STR has been also moved into sip_utils.

Issue: #79703
Change-Id: Ic197f53bbfeba363f0609908fa680f18529f8075

When bitrate is changed, new RTP session created must rely
on RTP sequence of previous RTP session in order to provide
continous sequence numbers.
This patchset ensures to keep last RTP sequence updated correctly
ensuring that no new packet will be sent when bitrate change is performed.

Issue: #80058
Change-Id: Ia7fbecd19aa0ec648327307de3ce3f8eace163a0
Signed-off-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

This patch tries to fix read errors on system socket when
no data available.

Issue: #80094
Change-Id: I7306bb32402983a939e9eca6cc4dbcc4d854685c

Decrease default video bitrate from 800 to 250 to adapt to slow connections

Issue: #79686
Change-Id: I5db1a8de025073a617ae5a2ff37c199a14354476

RTP packet maximum size must rely on maximum MTU size.
Networks such as ADSL include PPPoE header that reduce maximum
payload size.
Notice that packets higher than MTU would lead to fragmentation
by routers. With high bitrates in video, we want to avoid that.

This patch proposes to reduce the maximum UDP payload size allowed
to RTP to a value safe for PPPoE MTU.

This value has been computed as follow:

Ethernet MTU          = 1500 bytes
PPPoE headers        -= 8
IP headers           -= 24
UDP headers          -= 8
----------------------------------
Total for RTP payload = 1460 bytes

Issue: #80080
Change-Id: Ibc8d5943017f3cea3ac6e1f17f90a85f06755ebe

FILE_NAME is not const char*, it cannot be concatenated with the format
string at compile time, do it at runtime.

Issue: #79812
Change-Id: I9a0a3da4c0cbd66b23d32440509fc26cce0a0265

This patch fixes buildinfo data computation
in case of git failures.

Issue: #79930
Change-Id: Iccce40bb724ebfef73c068b96bfd59b7effbf777

- remove unused #defines
- forward declare pjsip_inv_session

Issue: #79618
Change-Id: I17c5c140919096511b481914eb5ae5146e4305c0

ff_srtp_encrypt is statefull. In case of ebusy, the encryption does not
give the same packet. Now we must do it only one time

Issue: #80019
Change-Id: Id3619b0f00fa7cacd1a85557f37412059562d7fb

This was introduced by changes a8013d76, but it's a mistake as
we need to keep control on returned value.

Issue: #78264
Change-Id: Ibb5bf8d5e40bf4a5963170f293cb3ea15f80fdab

This change provides a better way to find which sources are used
at runtime.

Issue: #79930
Change-Id: Icd505230269c4ba11e7d64e02471febcf68777a0

This is not used by the daemon and the clients save IMs via LRC.
There is no need for this function and it only pollutes the daemon
dir with im files.

Issue: #79618
Change-Id: Ibab3f83a3c6a966f0d602017c50aeb7cd7a4567f

This good practice prevents against silent API changes that cause
wrong method resolution.

Issue: #79703
Change-Id: Ic71e3d6e590106cfae439c4db3a874c5e51ec7d0

Issue: #79703
Change-Id: I403df97717df718b8931a0ecbf9f2b69053d5eb0

missing header <functional>, change introduced in
989e9bdb

Issue: #78983
Change-Id: I0f8e3a57d13d85e982a9fcd8a38e57b9f19afc8a

Some codecs, as h264, use a default keyframe rate based on frame count.
As example, on h264 this rate is one IFrame each 250 frames.
So this rate is sensible to fps changes, that ofen happens with
output type (images, frame size, screen casting, etc).
Using a rate based on fps seems more viable solution.

Moreover, in order to handle video artifacts in case of missed packets,
we want to send more keyframes so that artifacts will be seen for
a shorter period.

Note: the drawback of this solution is an average bitrate higher than
before as I frames are bigger than P frames.

Issue: #79690
Change-Id: I0b9daef8723c84b5998c9eb156d1e73538e8abed
Signed-off-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

IO events were handled by a unique thread owned by IceTransportFactory.
This patch changes that by creating a thread per IceTransport instance.

This improves a bit (on multiple-threaded architectures at least)
events handling as not all events handler run at the same speed
(SIP events are slow, Media IOs need low overhead).

Issue: #79692
Change-Id: Ie742373176f9447a14286910e6af562427cecdbd

Issue: #79690
Change-Id: I953925048763a97eb58c2502164e2377405ee8d8
Signed-off-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

Introduced by commit c974ad81

Issue: #79584
Change-Id: Ia4c16d9dee2bcd2fc32b3494f1b2417b8dca87f6

Remove a trace warning that pjsip return EBUSY because it adds useless
display processing.

Issue: #79686
Change-Id: I64a328ff90c46df85c911af7f7f049f1c47e0035

This patch parses optional display name that can be seen in From
and Contact SIP headers, for incoming calls.
Fallback on Contact header is made if From header is empty.

This also send the local display name in From header for outgoing
calls.

Issue: #77375
Change-Id: Iaef5e0e728a74427f3ced7efd947d09be91c0ac3

This patchset allows to send RTCP packets.
Ice callbacks are used to read RTP and RTCP packets.
Synchronisation mechanism is added between libav reading callbacks
and ice callbacks

Issue: #78983
Change-Id: Iafef224551fec1d2794b0ef3b2ee885d9ca75fb5
Signed-off-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

Issue: #79584
Change-Id: Ie4183de7cd8b26b7ee38d7ecad5197937bf57c75

Issue: #79584
Change-Id: Ib0d225357c6c478f31e4b8c8b1534aadb0eb5a40