1. 20 Mar, 2017 1 commit
    • Guillaume Roguez's avatar
      Fix DhParams copy-assignment and copy-constructor · a17755c6
      Guillaume Roguez authored
      DhParams copy-assignement was implemented as non-op operator.
      This is weird for a copy to do nothing!
      No intends are indicated to help.
      Seems only done to help MSVC compiler, but this is WRONG
      and cause a SECURITY FAILURE as the DhParam is not set
      as supposed to be.
      Consequence observed on UWP daemon: the anonymous connection
      cannot be done and the certificate is always send in cleartext.
      
      The fix consists in using the dedicated gnutls API
      to copy correctly the internal dh_params C structure.
      This is used to implement copy-assignement and copy-constructor
      methods
      Reviewed-by: Andreas Traczyk's avatarAndreas Traczyk <andreas.traczyk@savoirfairelinux.com>
      Change-Id: I49d3a3fd2c0a2ed5fde0bd251efbad589c830c70
      a17755c6
  2. 16 Mar, 2017 1 commit
  3. 15 Mar, 2017 4 commits
  4. 10 Mar, 2017 2 commits
    • Adrien Béraud's avatar
      trust request: implement synchronization · ebb16c18
      Adrien Béraud authored
      Change-Id: I9c054f9e3f35f973cf7df168292b9c43b896fa6d
      Tuleap: #1522
      ebb16c18
    • Adrien Béraud's avatar
      device revocation: refuse loading revoked device · 26ad3277
      Adrien Béraud authored
      The missing piece for working device revocation.
      * cert store: always use certificate chain match to check
        parent certificate.
        We used to allow a certificate if the parent certificate
        was explicitly allowed. This doesn't check for revoked
        device certificate. Instead, always check certificates
        using the standard certificate chain method except if
        the certificate itself is whitelisted.
      * ringaccount: check the account own device certificate chain
        This cause a revoked account to fail loading and propose
        the user to generate a new device from the archive
        through the standard account migration procedure.
      * ringaccount: check device loaded from disc using
        the common routine to discard devices revoked since the last
        save.
      
      Tuleap: #1457
      Change-Id: I03f015e78d1d14f5f2e9f99a6d3dd47a6f2c5bfe
      26ad3277
  5. 09 Mar, 2017 2 commits
  6. 08 Mar, 2017 2 commits
  7. 02 Mar, 2017 1 commit
  8. 01 Mar, 2017 1 commit
  9. 28 Feb, 2017 1 commit
  10. 27 Feb, 2017 5 commits
  11. 24 Feb, 2017 1 commit
    • Guillaume Roguez's avatar
      sip: fix sip call crash · 89ba505b
      Guillaume Roguez authored
      MTU discovery was only implemented into TLS secured ICE transport,
      not in other sip transport.
      This wasn't taken in account and causes crashes when SIP call (TLS or not)
      are made.
      We fix the problem by detecting the transport type at various stage
      and calling correct API (or use default values as in the case of MTU).
      
      Change-Id: Id256a718ca8265a7295085fab8db9cf8e4c99683
      89ba505b
  12. 22 Feb, 2017 3 commits
    • Guillaume Roguez's avatar
      coreaudio: modern C++ · f3d677fb
      Guillaume Roguez authored
      - replace malloc by C++ vector or new[]
      - use unique_ptr for dynamic allocations
      - use C++ cast than C cast
      - do not copy, use const&, & or move-idiom
      - replace NULL by nullptr
      - AAA rule
      - general coding rules
      
      Change-Id: I8a62ca9ef59b0807d5abeb0a5090521843dbb9ca
      f3d677fb
    • Guillaume Roguez's avatar
      call: fix audio tones generation · 72ee06ef
      Guillaume Roguez authored
      Ringing and busy tones have disappeared for an obscure reason.
      This patch reverts this situation by asking manager to play
      them at the right call state event.
      
      Change-Id: Ida6c3c946df553811b7b88b8a64e6a347fa3dfa4
      Reviewed-by: Andreas Traczyk's avatarAndreas Traczyk <andreas.traczyk@savoirfairelinux.com>
      72ee06ef
    • Guillaume Roguez's avatar
      jack: fix missing include · 3ceb9d73
      Guillaume Roguez authored
      Since a recent patch manager.h doesn't provide non-related headers
      like audioloop.h.
      This causes some build error in .cpp files missing to include
      correctly their dependencies.
      This patch fixes such case for jacklayer.cpp
      
      Change-Id: Ic33bc83026749676e4c34b7989fc61efd459231c
      3ceb9d73
  13. 21 Feb, 2017 6 commits
  14. 20 Feb, 2017 2 commits
  15. 17 Feb, 2017 4 commits
  16. 16 Feb, 2017 1 commit
  17. 15 Feb, 2017 3 commits
    • Guillaume Roguez's avatar
      manager: fix newOutgoingCall method · e4a96e79
      Guillaume Roguez authored
      Manager::newOutgoingCall() does not handle case where
      a valid account is found (no prefered given) but not usable,
      and many accounts are possible.
      They are not tested.
      This patch fixes this situation and also reduce cyclomatic
      complexity by factoring the account search loop.
      
      Change-Id: I505d082f4ca5d7756fe1f257e1767696dc41a2bf
      e4a96e79
    • Guillaume Roguez's avatar
      manager: refactor of joinParticipant method · 5cab4fa7
      Guillaume Roguez authored
      - decrease cyclomatic complexity of joinParticipant by
      factoring conference binding code and removing
      unneeded createConference method.
      
      - move the ConferenceCreated signal at the right place
      in the flow (i.e. last in sequence).
      
      Based on a proposition from zinspierre <zins.pierre@gmail.com>
      and al. in part of the course LOG8430 (Polytechnique Montreal).
      
      Thanks to them.
      
      Change-Id: I55203cc400496cd679c4f157d765aee0dec9c4f8
      Reviewed-by: Andreas Traczyk's avatarAndreas Traczyk <andreas.traczyk@savoirfairelinux.com>
      5cab4fa7
    • Guillaume Roguez's avatar
      increase keyframes request at stream begin · 6fe87e09
      Guillaume Roguez authored
      Increasing the number of keyframes sent at the begining
      of a video stream upto 4 (was 1).
      Even if the bytes flow is increased (only temporarily)
      sending more keyframes at stream begin let a chance to
      have a nice video looking in case of possible network
      packet drop. It's often the case at the stream begin
      due to high traffic caused by the calling establishment
      process.
      
      Change-Id: I2636727422ca641d8af9d83c59b9d487aff606d5
      Reviewed-by: Andreas Traczyk's avatarAndreas Traczyk <andreas.traczyk@savoirfairelinux.com>
      6fe87e09