1. 27 Feb, 2017 3 commits
  2. 24 Feb, 2017 1 commit
    • Guillaume Roguez's avatar
      sip: fix sip call crash · 89ba505b
      Guillaume Roguez authored
      MTU discovery was only implemented into TLS secured ICE transport,
      not in other sip transport.
      This wasn't taken in account and causes crashes when SIP call (TLS or not)
      are made.
      We fix the problem by detecting the transport type at various stage
      and calling correct API (or use default values as in the case of MTU).
      
      Change-Id: Id256a718ca8265a7295085fab8db9cf8e4c99683
      89ba505b
  3. 22 Feb, 2017 3 commits
    • Guillaume Roguez's avatar
      coreaudio: modern C++ · f3d677fb
      Guillaume Roguez authored
      - replace malloc by C++ vector or new[]
      - use unique_ptr for dynamic allocations
      - use C++ cast than C cast
      - do not copy, use const&, & or move-idiom
      - replace NULL by nullptr
      - AAA rule
      - general coding rules
      
      Change-Id: I8a62ca9ef59b0807d5abeb0a5090521843dbb9ca
      f3d677fb
    • Guillaume Roguez's avatar
      call: fix audio tones generation · 72ee06ef
      Guillaume Roguez authored
      Ringing and busy tones have disappeared for an obscure reason.
      This patch reverts this situation by asking manager to play
      them at the right call state event.
      
      Change-Id: Ida6c3c946df553811b7b88b8a64e6a347fa3dfa4
      Reviewed-by: Andreas Traczyk's avatarAndreas Traczyk <andreas.traczyk@savoirfairelinux.com>
      72ee06ef
    • Guillaume Roguez's avatar
      jack: fix missing include · 3ceb9d73
      Guillaume Roguez authored
      Since a recent patch manager.h doesn't provide non-related headers
      like audioloop.h.
      This causes some build error in .cpp files missing to include
      correctly their dependencies.
      This patch fixes such case for jacklayer.cpp
      
      Change-Id: Ic33bc83026749676e4c34b7989fc61efd459231c
      3ceb9d73
  4. 21 Feb, 2017 6 commits
  5. 20 Feb, 2017 2 commits
  6. 17 Feb, 2017 4 commits
  7. 16 Feb, 2017 1 commit
  8. 15 Feb, 2017 4 commits
    • Guillaume Roguez's avatar
      manager: fix newOutgoingCall method · e4a96e79
      Guillaume Roguez authored
      Manager::newOutgoingCall() does not handle case where
      a valid account is found (no prefered given) but not usable,
      and many accounts are possible.
      They are not tested.
      This patch fixes this situation and also reduce cyclomatic
      complexity by factoring the account search loop.
      
      Change-Id: I505d082f4ca5d7756fe1f257e1767696dc41a2bf
      e4a96e79
    • Guillaume Roguez's avatar
      manager: refactor of joinParticipant method · 5cab4fa7
      Guillaume Roguez authored
      - decrease cyclomatic complexity of joinParticipant by
      factoring conference binding code and removing
      unneeded createConference method.
      
      - move the ConferenceCreated signal at the right place
      in the flow (i.e. last in sequence).
      
      Based on a proposition from zinspierre <zins.pierre@gmail.com>
      and al. in part of the course LOG8430 (Polytechnique Montreal).
      
      Thanks to them.
      
      Change-Id: I55203cc400496cd679c4f157d765aee0dec9c4f8
      Reviewed-by: Andreas Traczyk's avatarAndreas Traczyk <andreas.traczyk@savoirfairelinux.com>
      5cab4fa7
    • Guillaume Roguez's avatar
      increase keyframes request at stream begin · 6fe87e09
      Guillaume Roguez authored
      Increasing the number of keyframes sent at the begining
      of a video stream upto 4 (was 1).
      Even if the bytes flow is increased (only temporarily)
      sending more keyframes at stream begin let a chance to
      have a nice video looking in case of possible network
      packet drop. It's often the case at the stream begin
      due to high traffic caused by the calling establishment
      process.
      
      Change-Id: I2636727422ca641d8af9d83c59b9d487aff606d5
      Reviewed-by: Andreas Traczyk's avatarAndreas Traczyk <andreas.traczyk@savoirfairelinux.com>
      6fe87e09
    • Olivier SOLDANO's avatar
      Path MTU discovery implementation · 29ae5d8a
      Olivier SOLDANO authored
      This implementation uses gnutls dtls heartbeat API to test path MTU.
      heartbeat allowing messages with automated response in a datagram,
      the application is able to guess the MTU via a timeout in the heartbeat.
      (timeout on packet sent and no response, implies that the MTU is lower
      than the lost payload.)
      To minimize false positives (a response is lost for example), each attempt
      triggers one retry on the first timeout.
      This version ensures a minimal MTU of 512 bytes will be returned in
      case of any failure in the procedure.
      For retrocompatibility with non heartbeat capable clients,
      a fallback MTU is set at 1280.
      
      Change-Id: Ib9a7f63a70e8bdad239d8fc103779a0f2c387e87
      Reviewed-by: Andreas Traczyk's avatarAndreas Traczyk <andreas.traczyk@savoirfairelinux.com>
      29ae5d8a
  9. 13 Feb, 2017 1 commit
    • atraczyk's avatar
      build(UWP): fix patching for UWP · b5e2496c
      atraczyk authored
      - Commit 184178da applied a patch
        before decompressing the ffmpeg tarball. This patch applies the
        patch after decompressing the archive.
      
      - remove extra lines that were preventing a pjproject patch from
        being applied correctly.
      
      - remove patching to openssl, as a recent update to VS makes the
        patch prevent store compatibility.
      
      Change-Id: Id5e8576c5df8a08a2974d9bf71ccf31fb5b2c513
      Tuleap: #790
      b5e2496c
  10. 10 Feb, 2017 2 commits
  11. 09 Feb, 2017 2 commits
    • atraczyk's avatar
      build(UWP): add x264 support · 184178da
      atraczyk authored
      - Adds x264 as a UWP dependency and patches it to pass the WACK
        test.
      
      - Configures ffmpeg to build with x264 support
      
      Change-Id: I3de4a45ba0df73b9217b0a73d8f006b631f71e00
      Tuleap: #790
      184178da
    • Nicolas Jager's avatar
      migration : fix migrateAccount() · 51009e0d
      Nicolas Jager authored
      - bug : if readArchive() line 1410 throw an exception, migrateAccount()
      will return without emiting any signal.
      
      - you can reproduce it by passing a wrong password to readArchive().
      
      - this patch fix the try catch by adding a signal before the return.
      
      - fix a missing else line 1421. Whitout it, whenever if
      updateCertificates return true, a Migration::State::INVALID signal is
      emited. Wich also leads when updateCertificates is true to emit two
      opposite signals.
      
      Change-Id: Id3bdbe6ef852095793af7802c75559d033b9f890
      Reviewed-by: Guillaume Roguez's avatarGuillaume Roguez <guillaume.roguez@savoirfairelinux.com>
      51009e0d
  12. 08 Feb, 2017 3 commits
  13. 07 Feb, 2017 1 commit
  14. 06 Feb, 2017 2 commits
  15. 03 Feb, 2017 2 commits
  16. 02 Feb, 2017 1 commit
    • Guillaume Roguez's avatar
      sip: factorize dialog and invite session creation · a3a5311f
      Guillaume Roguez authored
      SIP dialog and invite session creation code is duplicated
      in SIPAccount and RingAccount call creation code.
      This patch factorizes this code by moving identical parts
      into SIPAccountBase base class.
      The new common method is now CreateClientDialogAndInvite().
      
      By the way notice that previous duplicated code was locked
      the dialog. This extra lock it uneeded and wrong:
      - wrong because pjsip_dlg_inc_lock() was used, but it should
      be used only temporarily [1]
      - uneeded as the dialog session counter is increased by the invite
      session itself
      The correct way is to call pjsip_dlg_inc_session if we need long
      lock, that not our case here as we manage the invite session.
      
      [1] http://www.pjsip.org/pjsip/docs/html/group__PJSIP__DIALOG.htm#ga5d87304615303ffbe20a09e0a3ff59df)
      
      Change-Id: I8c2042b4c0278315cf76ea38affa8b90cab5cc7f
      Tuleap: #64
      a3a5311f
  17. 01 Feb, 2017 2 commits
    • atraczyk's avatar
      build: change to archive downloads only on UWP build · 3ae6811c
      atraczyk authored
      - Changes fetch scripts urls to archived tarballs if possible to
        facilitate caching of the contrib source on the UWP Jenkins
        build machine.
      
      Change-Id: I51eac783eea964bfe08727baf1ad7b9e08a5096d
      Tuleap: #790
      3ae6811c
    • Guillaume Roguez's avatar
      add docker config files · 8ceeb8b4
      Guillaume Roguez authored
      These Dockerfiles are preset docker configuration
      to give an easy way to setup build environment.
      
      This patch starts with Windows MingW configuration.
      More to come...
      
      Change-Id: Idf923038622ef2ac2e76b2407e969ad83b4eb83b
      8ceeb8b4