GitLab

Change-Id: Ifac53c178d59434027d162be0400070c01144e81

Update libupnp to version 1.8.4.

For windows, the IPV6 preprocessor must be undefined. Or else
libupnp won't initialize. Added visual studio 2017 support
via one patch for windows that also combines previous windows
patches.

UPnPController: Class that the jami classes use to control the
opening and closing of ports. Every  service has it's own upnp
controller. The controller does it's actions by using the upnp
context class. Also refactored the functions used to add
mappings. Instead of using two different functions with
different types of parameters, we now use one function with
parameters that have default values. The logic stays the same
but the function call is more clear.

UPnPContext: Class that holds a (linked) list of discovered IGDs
and their corresponding protocols (which discovered them).
Whenever the controller wants to add or remove a mapping, the
context picks a valid IGD in it's list and uses the correct
protocol to complete the required action. This class also has
the ability to swap protocols for an IGD that was discovered
by more then one protocol.

UPnPProtocol: Virtual base class that defines the functions
needed by the context to use the corresponding protocol.

PUPnP: UPnPProtocol derived class that represents a upnp client
that uses the portable upnp library (libupnp). Every time the
client discovers a new IGD it uses a callback to add it to the
context's main IGD linked list. It also has an internal list of
IGDs that it discovered. Added features to this class include:
	- IGD event subscription.
	- Use UpnpInit2 function instead of deprecated UpnpInit
	  function. It's also supposed to support IPv6.

NatPmp: UPnPProtocol derived class that represents a upnp client
that uses the NAT-PMP library (libnatpmp). Unlike libupnp,
libnatpmp only supports discovering one IGD. Also uses callbacks
to add the IGD it finds to the context's main IGD class.

Also inclided debug warning prints whenever a controller opens
and closes the ports. That way we can keep track of whenever
the application opens and closes ports on the internet
gateway device.

Gitlab: #96

Change-Id: I199271edac2c6d93dc60c24e2e2aefe36de7950c

Change-Id: I9b440d96fc34e9442b7856e428190cc8110f6bfa

Part of the discovery event handling for libupnp was to delete
all port mappings associated with the local ip address of the
application. I can only assume this was done to close pre-
existing ports that were not properly closed when the application
terminated. The problem with this logic is that since
advertisements and discovery events are treated with the same
switch case (fall through), the application was trying to close
all the ports on the internet gateway everytime it got an
advertisement. However, the application would then try to reopen
the ports every time after closing them. And this would happen
every five to ten seconds (i.e. whenever the application would
catch and advertisement or discovery event from the internet
gateway.)

To fix this quickly, I modified the way the event handling treats
discovery and advertisement events. Instead of having a list based
on the URL of the internet gateway, I use a list of it's unique
service ID. That way, as soon as the event occurs, we check if
we don't already have this service ID in our list. If we don't,
then we proceed as usual. If we do, we exit the event handling
since it's already been processed.

The advertisement bye bye event has also been implemented. When
this event occurs, the corresponding internet gateway devices are
deleted from the lists.

Gitlab: #96

Change-Id: Idd8023eba319b431b3a9328ebe648e75d61b1dc8

Change-Id: If34adb4833dff7ea71175bb7f465f48cb3758d55

P2P file transfer should support UPnP as a NAT traversal technique.

Change-Id: I62f9990fd646c874f611d3dba7277bef54caeb46
Gitlab: #86

* rename namespace from ring to jami
* rename logs methods from RING_* to JAMI_*
* rename RING_VIDEO to ENABLE_VIDEO

Change-Id: Ic98498652d7059fafe58a96220d565bcdfa53658

Change-Id: I04de6bb39925c48665cf234f3a714167d9f6ef7c

Change-Id: Ia4ed75d04a284efa0763c917aeaa2f08863a87cb

Change-Id: Ifbc5f3792a7019dcfa8249eb30afe2a64cbeb57c
Reviewed-by: Sebastien Blin <sebastien.blin@savoirfairelinux.com>

Change-Id: Ifc84b3f16a57e4d1aa23ef5453d5c2065fb27784

As contributed by Uwe Kleine-König <uwe@kleine-koenig.org>:
 - https://bugs.debian.org/884249

The compat code needs atleast upnp 1.6.25

Change-Id: Ia5e50dc362a64b4acd252dac5137e2aba4795064

Change-Id: I1ef88bc640f79790aad2b5285ea2c776aa8cd366

Blocking function (sleep) called when inside locked region.
This patch uses a move-in-temporary idiom to prevent that.
Was detected by Coverity scan.

Change-Id: I7ab74001c3d9de11e1d95b5e4a1c1bd0a8dce8c9
Reviewed-by: Olivier SOLDANO <olivier.soldano@savoirfairelinux.com>

Change-Id: I1d315ed93adf4b58dada2721278b209d87216e0e
Tuleap: #790

Change-Id: I6dbc51dd41c1f44d1446fe7365026af037bc86d9
Reviewed-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>

Fix and enable VPX on Android.
Since the Android build moved to clang and libc++,
it's no longer necessary to redefine some common
standard C++ methods.

Change-Id: I3488633782ded31bc260c5a234802ebd6f251377

Change-Id: Ia59165ea7d200c7c7cde666edb3918517119f199
Reviewed-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

The Microsoft compiler will include the common header <intrin.h>
regardless of the use of quotes. The file "intrin.h" should be renamed,
and all references to it changed, as well as defining the UNUSED macro
to nothing on the Windows platform.

Change-Id: Id04d36e70d149746be8d78eed09aa963514b2810
Tuleap: #801

Change-Id: I439bec2be0978e991511e42af464da765939d593
Tuleap: #805

Will properly check for a valid PMP IGD,
clear and reopen ports in case of connectivity change.

Change-Id: I47acfa9027217f5ba9f6c6c5b99d46abf5908e31
Tuleap: #805
Tuleap: #841

* add optional dependency to libnatpmp
* can run with or without UPnP
* transparently replaces UPnP when available

Change-Id: I1bbded421833cdc2506b42106e30cc8b3dde4c2d
Tuleap: #805

This allows the clients to notify the daemon when the conenctivity
(ie: network status) has changed. The daemon will then try to detect
the new IGD (UPnP) and re-connect all enabled accounts.

Change-Id: I5c8fc57f75e48d86eda5d195b0586c61a26134ad
Tuleap: #841

This reverts commit 150035a8.

reasons of the revert:
- doesn't link on Mac
- doesn't build on IOS
- build and link on linux, but the shared library is not found in rpath

Change-Id: Ie2eb1fe587adea1b607fde727abe6c641762495b
Notes: libnatpmp is not used on Android

* add optional dependency to libnatpmp
* can run with or without UPnP
* transparently replaces UPnP when available

Change-Id: I8477f3d91d8185f7872a3e00600daa7755ac0eee
Tuleap: #805

Ring no longer builds without GnuTLS and/or without openDHT, nor
are we planning to support building Ring without them, so these
should not exist as configuration options.

The related preprocessor conditionals have also been removed.

Change-Id: I8416ecc48f13a3fb77d9eb7d349b81f226e863f1
Tuleap: #739

tools/update-copyright script used for that

Change-Id: I89b13300d9ccbdbcd47dba679ba64be82499e83d
Tuleap: #454

IPv6 is enabled in libupnp which ships with ubuntu 16.04, but the
ipv6 init fails.

Change-Id: I94a652b4b6270a4b50e237e103445df9c23f3abe
Tuleap: #442

- remove OpenSSL exception
- fix Savoir-faire Linux naming
- fix common Author: representation

Issue: #80663
Change-Id: I6c3b2ca1ed48ed474a0ecd5a30fe793526e11b00

This commit bumps OpenDHT to make use of the related
connectivityChanged() method of the dht.


Issue: #78262
Change-Id: I64ea7b745cfc0653a09e8f6fb2d23b2d3fc6db4e

- this patch bump opendht (needed a header not installed)

- still use std::random_device on linux

Issue: #76261
Change-Id: Ie8a5c26b74b00900f55576384c2db0605903e3e1

Issue: #78144
Change-Id: I7dbcbcef5c81c7f3284759a8ad8dd13ed22ef345

Refs #71910

Change-Id: Iab724e6c9b9f6e412623a125a5bb076d3c78a57e

- bump contrib pcre to 8.36
- add missing C++ std functions
- add missing inclusions

Refs #70084

Change-Id: Idd0f94d07d53b0b89dfb03b97c5b467a83b3ff83
Signed-off-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

Refs #68986

Change-Id: Ia95b140e4f4d6625d1df12d52a40414482b2e773

Refs #68205

Change-Id: I32270124d4b2d6e407465150a4d53f819e118557
Signed-off-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

Refs #67575

Change-Id: I2db092065ed0c975e7a7b0e9df309739bac5b473

Refs #67228

Change-Id: Iddaa84dc05b0ea1b732d2e94d0e62d3fd205c754

* Add timeout parameter to hasValidIGD to let caller decide
  if he want to block or not and how long.
* Change callers to support this timout.
* replace extra search mutex/cv by exiting validIGD mutex and add
a validIGD cv.

Refs #67319

Change-Id: If743aa6df9aa21c0a542d489615c9b032e2b5fa7

Refs #66919

Note: fix compiler warning by the way...

Change-Id: I1e8f6d2839400245685e84dca016621464f7175d