Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
J
jami-lrc
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 23
    • Issues 23
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Requirements
    • Requirements
    • List
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • savoirfairelinux
  • jami-lrc
  • Issues
  • #400

Closed
Open
Opened Oct 21, 2018 by Hugo Lefeuvre@hlefeuvreDeveloper

account (un)register: bad daemon method used, setAccountActive never called

The setAccountActive() method from the daemon API is not used by the new LRC.

220 void
221 NewAccountModel::enableAccount(const std::string& accountId, bool enabled)
222 {
223     auto accountInfo = pimpl_->accounts.find(accountId);
224     if (accountInfo == pimpl_->accounts.end()) {
225         throw std::out_of_range("NewAccountModel::getAccountConfig, can't find " + accountId);
226     }
227     accountInfo->second.enabled = enabled;
228 }

Instead, the account is registered and unregistered via setAccountdetails(). Obviously, this is not a very good idea. It might even be the root of our issues with the register/unregister feature.

Edited Oct 21, 2018 by Hugo Lefeuvre
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: savoirfairelinux/ring-lrc#400