Contributions, suggestions and review of Ring project's status as free software
Issue generated from Tuleap's migration script. Originally submitted by: Adonay Felipe Nogueira (adfeno)
Important notes:
a. I'm not a lawyer, and I'm confident that I can make mistakes. So I'm also accepting corrections.
b. As a volunteer, I'm no way writing this messages to sound aggressive, or to appear as an aggressive money maker that misuses copyleft licenses (ala Oracle). I just want to help making Ring a better free software project, even if I'm able to do so just with words (because I'm not a programmer).
So, let's start discussing the real thing...
To start this review, I made a directory somewhere in my system and asked git to clone "ring-project" repository recursively by doing:
git clone --recursive "https://gerrit-ring.savoirfairelinux.com/ring-project"
Note: I didn't review "ring-client-uwp" due to my lack of [human] memory (I forgot to clone it to redo the report).
Note: Most paths where skipped due to not belonging to the Ring project, being their own source, or being simple improvisations. The complete (uncut) list of paths can be obtained by running:
find -exec file --mime '{}' ';'
.. while working in the "ring-project" directory.
The following paths have either one of the following problems:
a. Don't have their complete corresponding source, in accordance with GPLv3, section 1.
b. If they come from a different project, and weren't adapted by the Ring project: they don't have proper indication as to which license they're under and there's no attribution to the original project or where to get the corresponding source from the original project. If this information can't be provided, then item/option a applies.
The following paths are affected:
./client-android/ring-android/app/src/main/assets/fonts/Roboto-Thin.ttf: application/x-font-ttf; charset=binary
./client-android/ring-android/app/src/main/assets/ringtones/konga.ul: application/octet-stream; charset=binary
./daemon/ringtones/default.wav: audio/x-wav; charset=binary
./daemon/ringtones/konga.ul: application/octet-stream; charset=binary
If, and only if, Roboto Thin font ("./client-android/ring-android/app/src/main/assets/fonts/Roboto-Thin.ttf") wasn't changed/adapted by the Ring project, I might be able to help by putting correct attribution in the "README-like" files (separated informative files). In any case, I might also do so, but instead inform the user/reader that the font was changed/adapted. I can aid on doing so because I have heard of Roboto Thin font's origin.
As a suggestion for the previous issue, and if the paths mentioned weren't adapted by the Ring project, I think we shouldn't bundle these in the Ring project directly (we can of course reference to repositories that have the source files of the paths mentioned).
The following paths are affected by the following issues:
a. Are functional data (in this case: scripts), with non-free license (Creative Commons Attribution-No Derivative Works 3.0 Unported). Please ignore this item if the paths come from a different project, and if, and only if, weren't adapted by the Ring project.
The following paths are affected:
./daemon/tools/build-system/launchpad/mozilla-telify-sflphone/debian/mozilla-telify-sflphone/usr/share/telify/chrome/content/telify.js: text/plain; charset=utf-8
As a suggestion for the previous issue, and if the paths mentioned weren't adapted by the Ring project, I think we shouldn't bundle these in the Ring project directly (we can of course reference to repositories that have the source files of the paths mentioned).
This ends this review.
*Additionally*, I just want to know if the following path:
./client-android/ring-android/app: inode/directory; charset=binary
... is the complete and corresponding source of:
./client-android/ring-android/gradle/wrapper/gradle-wrapper.jar: application/zip; charset=binary
... ?
This question is additional both because:
a. It's OK to keep both.
b. I can't check that by myself.
Respectfully, Adonay.