smartlist: fix crash when searching

Change-Id: Id83ff61029299d77d9661f935f3c1d4d41980700

ring-android/app/src/main/java/cx/ring/viewholders/SmartListViewHolder.java

@@ -38,6 +38,7 @@ import cx.ring.databinding.ItemSmartlistBinding;
 import cx.ring.databinding.ItemSmartlistHeaderBinding;
 import cx.ring.utils.ResourceMapper;
 import cx.ring.views.AvatarDrawable;
+import io.reactivex.rxjava3.core.Observable;
 import io.reactivex.rxjava3.disposables.CompositeDisposable;
 
 public class SmartListViewHolder extends RecyclerView.ViewHolder {
@@ -65,10 +66,10 @@ public class SmartListViewHolder extends RecyclerView.ViewHolder {
 
         if (binding != null) {
             itemView.setOnClickListener(v -> clickListener.onItemClick(smartListViewModel));
-            compositeDisposable.add(smartListViewModel.getSelected().subscribe(selected -> {
-                Log.w("SmartListViewHolder", "selected " + selected + " " + smartListViewModel.getContactName());
-                binding.itemLayout.setActivated(selected);
-            }));
+            Observable<Boolean> selected = smartListViewModel.getSelected();
+            if (selected != null) {
+                compositeDisposable.add(smartListViewModel.getSelected().subscribe(binding.itemLayout::setActivated));
+            }
             itemView.setOnLongClickListener(v -> {
                 clickListener.onItemLongClick(smartListViewModel);
                 return true;

ring-android/libringclient/src/main/java/net/jami/model/Conversation.java

@@ -344,10 +344,15 @@ public class Conversation extends ConversationHistory {
         if (interaction.getContact() == null) {
             if (mContacts.size() == 1)
                 interaction.setContact(mContacts.get(0));
-            else
+            else {
+                if (interaction.getAuthor() == null)  {
+                    Log.e(TAG, "Can't set interaction properties: no author for type:" + interaction.getType() + " id:" + interaction.getId() + " status:" + interaction.mStatus);
+                } else {
                     interaction.setContact(findContact(Uri.fromString(interaction.getAuthor())));
                 }
             }
+        }
+    }
 
     public Contact findContact(Uri uri) {
         for (Contact contact : mContacts)  {