camera: catch codec exception, fix leaks

Change-Id: I6e0690d4f590474c2c0ebf9c7c414c04c2ec5471

ring-android/app/src/main/java/cx/ring/services/CameraService.java

@@ -512,7 +512,10 @@ public class CameraService {
                 }
             } catch (Exception e) {
                 Log.e(TAG, "Can't open codec", e);
+                if (codec != null) {
+                    codec.release();
                     codec = null;
+                }
                 if (encoderInput != null) {
                     encoderInput.release();
                     encoderInput = null;
@@ -771,8 +774,12 @@ public class CameraService {
                                         @Override
                                         public void onCaptureStarted(@NonNull CameraCaptureSession session, @NonNull CaptureRequest request, long timestamp, long frameNumber) {
                                             if (frameNumber == 1) {
+                                                try {
                                                     codec.first.start();
                                                     codecStarted[0] = true;
+                                                } catch (Exception e) {
+                                                    listener.onError();
+                                                }
                                             }
                                         }
                                     } : null, handler);
@@ -820,13 +827,20 @@ public class CameraService {
                     Log.w(TAG, "onClosed");
                     if (previewCamera == camera)
                         previewCamera = null;
-                    if (codec != null && codec.first != null) {
+                    if (codec != null) {
+                        if (codec.first != null) {
                             if (codecStarted[0])
                                 codec.first.signalEndOfInputStream();
                             codec.first.release();
                             if (codec.first == currentCodec)
                                 currentCodec = null;
                         }
+                        if (codec.second != null)
+                            codec.second.release();
+                    }
+                    if (reader != null) {
+                        reader.close();
+                    }
                     s.release();
                 }
             }, handler);

ring-android/app/src/main/java/cx/ring/services/HardwareServiceImpl.java

@@ -478,6 +478,10 @@ public class HardwareServiceImpl extends HardwareService implements AudioManager
 
     @Override
     public void startCapture(@Nullable String camId) {
+        if (mIsScreenSharing) {
+            cameraService.stopScreenSharing();
+            mIsScreenSharing = false;
+        }
         mShouldCapture = true;
         if (mIsCapturing && mCapturingId != null && mCapturingId.equals(camId)) {
             return;
@@ -544,6 +548,10 @@ public class HardwareServiceImpl extends HardwareService implements AudioManager
         Log.d(TAG, "stopCapture: " + cameraService.isOpen());
         mShouldCapture = false;
         endCapture();
+        if (mIsScreenSharing) {
+            cameraService.stopScreenSharing();
+            mIsScreenSharing = false;
+        }
     }
 
     public void requestKeyFrame() {