Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
jami-client-qt
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
savoirfairelinux
jami-client-qt
Commits
197fd62f
Commit
197fd62f
authored
3 years ago
by
Sébastien Blin
Committed by
Andreas Traczyk
3 years ago
Browse files
Options
Downloads
Patches
Plain Diff
conference: fix show minimize button
Change-Id: I104215284272b4d1fdec38b6d715f92184b3c711 GitLab:
#367
parent
3f476205
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
src/mainview/components/CallOverlay.qml
+2
-11
2 additions, 11 deletions
src/mainview/components/CallOverlay.qml
src/mainview/components/ParticipantOverlay.qml
+4
-3
4 additions, 3 deletions
src/mainview/components/ParticipantOverlay.qml
with
6 additions
and
14 deletions
src/mainview/components/CallOverlay.qml
+
2
−
11
View file @
197fd62f
...
...
@@ -87,12 +87,6 @@ Rectangle {
||
pH
<
(
distantRenderer
.
height
-
distantRenderer
.
getYOffset
()
*
2
-
1
))
}
// returns true if participant takes renderer's width
function
showMinimize
(
pX
,
pW
)
{
return
(
pX
-
distantRenderer
.
getXOffset
()
===
0
&&
pW
>=
distantRenderer
.
width
-
distantRenderer
.
getXOffset
()
*
2
-
1
)
}
function
handleParticipantsInfo
(
infos
)
{
// TODO: in the future the conference layout should be entirely managed by the client
// Hack: truncate and ceil participant's overlay position and size to correct
...
...
@@ -132,11 +126,9 @@ Rectangle {
participantOverlays
[
p
].
y
,
participantOverlays
[
p
].
width
,
participantOverlays
[
p
].
height
)
showMin
=
showMinimize
(
participantOverlays
[
p
].
x
,
participantOverlays
[
p
].
width
)
participantOverlays
[
p
].
setMenu
(
participant
.
uri
,
participant
.
bestName
,
participant
.
isLocal
,
showMax
,
showM
in
)
participant
.
isLocal
,
participant
.
active
,
showM
ax
)
if
(
participant
.
videoMuted
)
participantOverlays
[
p
].
setAvatar
(
participant
.
avatar
)
else
...
...
@@ -177,10 +169,9 @@ Rectangle {
}
showMax
=
showMaximize
(
hover
.
x
,
hover
.
y
,
hover
.
width
,
hover
.
height
)
showMin
=
showMinimize
(
hover
.
x
,
hover
.
width
)
hover
.
setMenu
(
infos
[
infoVariant
].
uri
,
infos
[
infoVariant
].
bestName
,
infos
[
infoVariant
].
isLocal
,
showMax
,
showM
in
)
infos
[
infoVariant
].
isLocal
,
infos
[
infoVariant
].
active
,
showM
ax
)
if
(
infos
[
infoVariant
].
videoMuted
)
hover
.
setAvatar
(
infos
[
infoVariant
].
avatar
)
else
...
...
This diff is collapsed.
Click to expand it.
src/mainview/components/ParticipantOverlay.qml
+
4
−
3
View file @
197fd62f
...
...
@@ -42,10 +42,10 @@ Rectangle {
arg
(
shapeWidth
)
property
string
uri
:
overlayMenu
.
uri
property
bool
participantIsActive
:
false
property
bool
participantIsHost
:
false
property
bool
participantIsModerator
:
false
property
bool
participantIsMuted
:
false
property
bool
participantIsLocalMuted
:
false
property
bool
participantIsModeratorMuted
:
false
property
bool
participantMenuActive
:
false
...
...
@@ -59,7 +59,7 @@ Rectangle {
}
}
function
setMenu
(
newUri
,
bestName
,
isLocal
,
showMax
,
showM
in
)
{
function
setMenu
(
newUri
,
bestName
,
isLocal
,
isActive
,
showM
ax
)
{
overlayMenu
.
uri
=
newUri
overlayMenu
.
bestName
=
bestName
...
...
@@ -68,6 +68,7 @@ Rectangle {
var
isModerator
=
CallAdapter
.
isCurrentModerator
()
participantIsHost
=
CallAdapter
.
participantIsHost
(
overlayMenu
.
uri
)
participantIsModerator
=
CallAdapter
.
isModerator
(
overlayMenu
.
uri
)
participantIsActive
=
isActive
overlayMenu
.
showSetModerator
=
isHost
&&
!
isLocal
&&
!
participantIsModerator
overlayMenu
.
showUnsetModerator
=
isHost
&&
!
isLocal
&&
participantIsModerator
...
...
@@ -82,7 +83,7 @@ Rectangle {
overlayMenu
.
showModeratorMute
=
isModerator
&&
!
isModeratorMuted
overlayMenu
.
showModeratorUnmute
=
isModerator
&&
isModeratorMuted
overlayMenu
.
showMaximize
=
isModerator
&&
showMax
overlayMenu
.
showMinimize
=
isModerator
&&
showMin
overlayMenu
.
showMinimize
=
isModerator
&&
participantIsActive
overlayMenu
.
showHangup
=
isModerator
&&
!
isLocal
&&
!
participantIsHost
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment