Attaching file & switching to another contact attaches file to the new contact

[Bug report]

Problem: When attaching a file for a particular contact, if we select a different contact in our contacts list, the attached file will go to the selected contact instead of the designated recipient. If you click on "send", the file will be sent to the selected contact.

• Platform: macOS

• OS version: Ventura 13.0.1 (22A400)

• Jami version: 202408211151

• Can you reproduce the bug: at will

Steps to reproduce (STR):

1. We want to share a file with contact A. We attach the desired file in the chat for contact A.
2. From the contacts list, we click on another contact (contact B) for reasons such as checking the messages they sent, etc.
3. The file we attached for contact A gets transferred to the chatbox for contact B. If we click on "send", the attached file will be sent to contact B.

• Actual result: The attached file for a designated recipient will be transferred to another contact's chatbox if the user opens the chat with another contact. Clicking on "send" will send the attached file to the other contact rather than the original recipient. The file stays in the chatbox, regardless of which contact we choose, until the file is sent or removed.

• Expected result: The file we attach for a designated recipient should stay in the chatbox for the other recipient. When clicking on another contact before sending the attached file to the designated recipient, the chatbox for the other contact should be empty (should NOT contain the file we attached for the designated recipient). When we shift back from the chat with other contact to the chat with designated recipient, the file we attached should exist in their chatbox. In other words, each file attached for a designated recipient should stay in their chatbox (NOT move to another contact) until the file is sent or deleted, regardless of how many times we switch between different contacts.

Relevant logs, screenshots or video :

1. Attaching file for designated recipient:
2. Switching to another contact - the attached file gets transferred to the new contact:
3. Clicking "send" will actually send the file to the newly selected contact:

assigned to @ahatziiliou

mentioned in commit cb829676

closed