Space between `Enable hardware acceleration` and `Screen Sharing`

In Audio and Video Settings there is a space between Enable hardware acceleration and Screen Sharing as shown in the image below.

Toggling Enable hardware acceleration makes the space disappear as shown in the image below

It seems to be only on devices with No video device. Perhaps the space is the space for the video preview?

Can this please be fixed?

Thank you

Linux Mint 20.2 Cinnamon
jami-client-qt Version: 202112012137 deb edition from jami.net

cc: @agsantos

Hi,

in fact there is no empty space between hw accel and screen sharing. If you put your Jami to light mode you will see the text "Preview unavailable". In any case the text can be removed if no video devices.

https://review.jami.net/c/jami-client-qt/+/19904

In fac the label should be colored and readable

color: JamiTheme.primaryForegroundColor

mentioned in commit 218aa35e

assigned to @agsantos

added SprintDone label

closed

I generate a new nightly tonight

Verified fixed, Version: 202112022044, thank you

Trusting that Preview unavailable is translatable.

For the translations, a quick way to know, in the code you will have qsTr() around the string (eg here: https://git.jami.net/savoirfairelinux/jami-client-qt/-/blob/master/src/constant/JamiStrings.qml#L178) the rest is linked to the translation pipeline and pretty automatic

Thank you for the link.

Changed the locale, restart computer and verified fixed as shown in image below, thank you

removed SprintDone label

reopened

@agsantos I had to revert your patch. This introduces some big regressions

changed title from Space between Enable hardwar{-d-} acceleration and Screen Sharing to Space between Enable hardwar{+e+} acceleration and Screen Sharing

mentioned in commit 9ee7c083

closed