Settings, General, Appearance, Theme with options: System, Light, Dark

1. Rename Enable dark theme to Style
2. Change the enable/disable toggle to a dropdown with the options: System, Light theme, Dark theme
3. Set the default value for the dropdown to System; the default style of Jami will respect the user's system's configuration. This would also be consistent with the default value for Jami's User interface language which is System.

Inspiration from Ubuntu as shown in the image below:

What do you think?

Thank you

changed the description

added BacklogLow label

for Ubuntu - https://review.jami.net/c/jami-client-qt/+/22296

mentioned in commit ec1d664b

added 1 deleted label

added 1 deleted label

For GNU/Linux, it's now supported on master (so will be there in next version).

Other platforms need some code.

Is the System option the first item in the drop-down list? Thank you

added good-first-issue label

assigned to @agsantos

https://review.jami.net/c/jami-client-qt/+/23063

https://review.jami.net/c/jami-client-qt/+/23066

mentioned in commit 4b6c4b8a

mentioned in commit 956b7f7d

removed 1 deleted label

mentioned in commit e2d5da81

1. Theme = System doesn't work as shown in the image below.

2. Should System be first to be consistent with User interface language?

Thank you

Linux Mint 21.1 Cinnamon

What gives

gsettings get org.gnome.desktop.interface gtk-color-scheme
gsettings get org.gnome.desktop.interface color-scheme    
gsettings get org.gnome.desktop.interface gtk-theme       

It will only pass in "Dark" if one of the 3 commands return something containing "dark" or "black" (e.g. Adwaita:Dark, Yaru-Dark on my 2 systems)

There is no default method to get the correct preference.

Also for me Jami does not respect the System option. I get

• gsettings get org.gnome.desktop.interface gtk-color-scheme ''
• gsettings get org.gnome.desktop.interface color-scheme 'prefer-dark'
• gsettings get org.gnome.desktop.interface gtk-theme 'adw-gtk3-dark'

The Dark option works by the way. This is on Fedora 38, Jami from Flathub with version 20230429.1.21b5c95e

Flatpak is containerized and not maintained by us. For Flatpak, you will need to override the themes https://itsfoss.com/flatpak-app-apply-theme/ probably. But this is out of scope.

Ah.. I remember - I think, you once explained, that Fedora Media writer does some heavy lifting in this regard. Sorry..

It probably won't help, but I just realized, that also Kile from Flathub respects the system settings.

Thanks for your Terminal commands.

$ gsettings get org.gnome.desktop.interface gtk-color-scheme
''
$ gsettings get org.gnome.desktop.interface color-scheme
'default'
$ gsettings get org.gnome.desktop.interface gtk-theme
'Mint-Y-Aqua'

Seems like an error with Linux Mint, issue created at https://github.com/linuxmint/linuxmint/issues/585

Thank you once again

#1144 (closed)

changed title from Setting{- Enable dark theme → Styl-}e with options System, Light{- theme-}, Dark{- theme-} to {++}Setting{+s, General, Appearance, Them+}e with options System, Light, Dark

changed title from {--}Settings{--}, {--}General{--}, {--}Appearance{--}, {--}Theme{--} with options System, Light, Dark to Settings, General, Appearance, Theme with options System, Light, Dark

changed title from Settings, General, Appearance, Theme with options {--}System{--}, {--}Light{--}, {--}Dark{--} to Settings, General, Appearance, Theme with options: System, Light, Dark

mentioned in issue #1144 (closed)

added platformmacos label

removed 1 deleted label

closed