Edit message - ↑ (up arrow) keyboard shortcut to select the last sent message for editing

Sometimes (or perhaps frequently) when sending a message, there are typos in the last sent message.

Please enable the ↑ (up arrow) keyboard shortcut to select the last message for editing (i.e. without using the mouse) and fill the message composition field with the last message. When the message is sent, instead of sending a new message, the last message is updated with the change.

Press ↑ (up arrow) key on the keyboard select the last sent message sent by the owner of that message (you can't edit the message from someone else) if and only if:

1. Focus is (and cursor is showing) in the message composition field
   
2. Message composition field has no text. Once there is text or emoji in the message composition field the arrow should traverse the data.
3. There is a message which has been sent. If there has never been a message sent, there is no last message sent and Jami should not crash.

Thank you

This small edit message improvement has inspiration from Skype.

mentioned in issue #870 (closed)

changed title from Edit message - small improvement to Edit message - ↑ (up arrow) keyboard shortcut to select the last sent message for editing

changed the description

Pressing the Esc key on the keyboard cancels the last message edition.

assigned to @agsantos

added SprintIn progress label

https://review.jami.net/c/jami-client-qt/+/23242

added SprintTo review label and removed SprintIn progress label

added SprintDone label and removed SprintTo review label

mentioned in commit 50888a28

will be released tomorrow I guess

closed

removed SprintDone label

The Esc key seems equivalent to the Cancel button to cancel the current action.

Can you please advise why Ctrl + Esc is used instead of just Esc (Escape) to Cancel message edition?

Thank you

Hi @ovari ,

It was my first intention to use only Escape to cancel the edition, however i was not able to make it work, then the fall back to Ctrl+Escape.

Thank you

mentioned in commit 8d35ad73

↑ (up arrow) keyboard shortcut does not work with Jami 202212201424 running on Linux Mint 21.1 Cinnamon.

Hi @ovari,

Fix is in review: https://review.jami.net/c/jami-client-qt/+/23509

Please, when a feature does not work as expected, please open a new ticket instead of reopening one.

reopened

closed