Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • release/202005
  • release/202001
  • release/201912
  • release/201911
  • release/releaseWindowsTestOne
  • release/windowsReleaseTest
  • release/releaseTest
  • release/releaseWindowsTest
  • release/201910
  • release/qt/201910
  • release/windows-test/201910
  • release/201908
  • release/201906
  • release/201905
  • release/201904
  • release/201903
  • release/201902
  • release/201901
  • release/201812
  • 4.0.0
  • 2.2.0
  • 2.1.0
  • 2.0.1
  • 2.0.0
  • 1.4.1
  • 1.4.0
  • 1.3.0
  • 1.2.0
  • 1.1.0
30 results

peer_connection.cpp

  • Sébastien Blin's avatar
    6f27b766
    peer_connection: fix notify_one() crash · 6f27b766
    Sébastien Blin authored and Adrien Béraud's avatar Adrien Béraud committed
    This is a bit a hacky patch. The real fix will be to remove underlyingIce()
    But tls must be checked before shutdown to avoid to use a non existing object.
    Imho what really happen is that the ice is moved in IceSocketEndpoint::shutdown()
    so when  TlsSocketEndpoint::Impl is detroyed, the callback is not reset, tls
    become nullptr and then we try to shutdown this non existing tls.
    However, removing underlyingIce is not straight forward as every shutdown event
    must close all layers of the socket, so at first, just fix this issue.
    
    Change-Id: Ifd9c3733e175787b97a48f3c3e282287963018bb
    6f27b766
    History
    peer_connection: fix notify_one() crash
    Sébastien Blin authored and Adrien Béraud's avatar Adrien Béraud committed
    This is a bit a hacky patch. The real fix will be to remove underlyingIce()
    But tls must be checked before shutdown to avoid to use a non existing object.
    Imho what really happen is that the ice is moved in IceSocketEndpoint::shutdown()
    so when  TlsSocketEndpoint::Impl is detroyed, the callback is not reset, tls
    become nullptr and then we try to shutdown this non existing tls.
    However, removing underlyingIce is not straight forward as every shutdown event
    must close all layers of the socket, so at first, just fix this issue.
    
    Change-Id: Ifd9c3733e175787b97a48f3c3e282287963018bb
Code owners
Assign users and groups as approvers for specific file changes. Learn more.