corelayer.cpp

8 years ago

coreaudio: fix buffer overflow on silence writing · b9869856

Anthony Léonard authored 8 years ago and

Guillaume Roguez committed 8 years ago


The count argument passed to std::fill_n was in bytes instead of
element's count (which are of Float32 type) so zeroes were written
outside the scope of the audio buffer.

This was causing crashes not on this instruction but anywhere in the
application when a malloc call was checking for memory sanity (which
isn't done on every allocation).

Change-Id: Iec6fa9d3b00b828c6bf798c77419b8bad970d6e1
Reviewed-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

b9869856

History

coreaudio: fix buffer overflow on silence writing

Anthony Léonard authored 8 years ago and

Guillaume Roguez committed 8 years ago


The count argument passed to std::fill_n was in bytes instead of
element's count (which are of Float32 type) so zeroes were written
outside the scope of the audio buffer.

This was causing crashes not on this instruction but anywhere in the
application when a malloc call was checking for memory sanity (which
isn't done on every allocation).

Change-Id: Iec6fa9d3b00b828c6bf798c77419b8bad970d6e1
Reviewed-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

Code owners

Assign users and groups as approvers for specific file changes. Learn more.