Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • release/202005
  • release/202001
  • release/201912
  • release/201911
  • release/releaseWindowsTestOne
  • release/windowsReleaseTest
  • release/releaseTest
  • release/releaseWindowsTest
  • release/201910
  • release/qt/201910
  • release/windows-test/201910
  • release/201908
  • release/201906
  • release/201905
  • release/201904
  • release/201903
  • release/201902
  • release/201901
  • release/201812
  • 4.0.0
  • 2.2.0
  • 2.1.0
  • 2.0.1
  • 2.0.0
  • 1.4.1
  • 1.4.0
  • 1.3.0
  • 1.2.0
  • 1.1.0
30 results

connectionmanager.cpp

  • Sébastien Blin's avatar
    c3f9ea3d
    connectivity: avoid TLS handshake loop · c3f9ea3d
    Sébastien Blin authored 
    Two points are changed in this patch:
+ In peer_channel, the wait return broken_pipe (because if stopped
it's like the write operation, the socket behind is being removed).
Moreover, sending E_INTERRUPTED while in the handshake will cause
gnutls to loop in server_hello.
+ In ConnectionManager, if the ICE is negotiated and started (which
can be the case for a server because the client will start to negotiate
and send the answer on the DHT, so negotiation can finish before getting
remote peers) we cancel the waitForResponse timer to avoid any cancellation
while in the handshake.

GitLab: #519
Change-Id: I530d9eba47aa918c90b6a151061556f4af636fb5
    c3f9ea3d
    History
    connectivity: avoid TLS handshake loop
    Sébastien Blin authored 
    Two points are changed in this patch:
+ In peer_channel, the wait return broken_pipe (because if stopped
it's like the write operation, the socket behind is being removed).
Moreover, sending E_INTERRUPTED while in the handshake will cause
gnutls to loop in server_hello.
+ In ConnectionManager, if the ICE is negotiated and started (which
can be the case for a server because the client will start to negotiate
and send the answer on the DHT, so negotiation can finish before getting
remote peers) we cancel the waitForResponse timer to avoid any cancellation
while in the handshake.

GitLab: #519
Change-Id: I530d9eba47aa918c90b6a151061556f4af636fb5
Code owners
Assign users and groups as approvers for specific file changes. Learn more.