Revert "plugins: don't activate if plugins are disabled"

This reverts commit 17f9bda8.

Reason for revert: major design issue. When plugin are disabled, every plugin will be disabled, then every plugin are unloaded, so no handler can remain after disabling plugin.

Change-Id: Icd393d179b45866e46dd4cc3d902174699ac2d98

src/client/plugin_manager_interface.cpp

@@ -186,10 +186,6 @@ void
 setPluginsEnabled(bool state)
 {
     jami::Manager::instance().pluginPreferences.setPluginsEnabled(state);
-    jami::Manager::instance()
-        .getJamiPluginManager()
-        .getCallServicesManager()
-        .pauseRestartMediaHandlers(state);
     jami::Manager::instance().saveConfig();
 }
 } // namespace DRing

src/plugin/callservicesmanager.cpp

@@ -83,19 +83,6 @@ CallServicesManager::createAVSubject(const StreamData& data, AVSubjectSPtr subje
     }
 }
 
-void
-CallServicesManager::pauseRestartMediaHandlers(bool isPluginEnabled)
-{
-    auto calls = Manager::instance().callFactory.getAllCalls();
-    for (auto& call : calls) {
-        if (call->getState() == Call::CallState::ACTIVE) {
-            auto callId = call->getCallId();
-            for (const auto& toggledMediaHandlerPair : mediaHandlerToggled_[callId])
-                toggleCallMediaHandler(toggledMediaHandlerPair.first, callId, isPluginEnabled);
-        }
-    }
-}
-
 void
 CallServicesManager::clearAVSubject(const std::string& callId)
 {
@@ -271,7 +258,6 @@ CallServicesManager::toggleCallMediaHandler(const uintptr_t mediaHandlerId,
 {
     auto& handlers = mediaHandlerToggled_[callId];
     bool applyRestart = false;
-    auto isPluginEnabled = jami::Manager::instance().pluginPreferences.getPluginsEnabled();
 
     for (auto subject : callAVsubjects_[callId]) {
         auto handlerIt = std::find_if(callMediaHandlers_.begin(),
@@ -282,13 +268,11 @@ CallServicesManager::toggleCallMediaHandler(const uintptr_t mediaHandlerId,
 
         if (handlerIt != callMediaHandlers_.end()) {
             if (toggle) {
-                if (isPluginEnabled)
                 notifyAVSubject((*handlerIt), subject.first, subject.second);
-                if (isAttached((*handlerIt)) || !isPluginEnabled)
+                if (isAttached((*handlerIt)))
                     handlers[mediaHandlerId] = true;
             } else {
                 (*handlerIt)->detach();
-                if (isPluginEnabled)
                 handlers[mediaHandlerId] = false;
             }
             if (subject.first.type == StreamType::video && isVideoType((*handlerIt)))

src/plugin/callservicesmanager.h

@@ -127,13 +127,6 @@ public:
      */
     void clearCallHandlerMaps(const std::string& callId);
 
-    /**
-     * @brief used to stop/restart plugins when jami preference is changed mid call.
-     *
-     * @param isPluginEnabled
-     */
-    void pauseRestartMediaHandlers(bool isPluginEnabled);
-
 private:
     /**
      * @brief Exposes MediaHandlers' life cycle managers services to the main API.

src/plugin/chatservicesmanager.cpp

@@ -112,7 +112,7 @@ ChatServicesManager::getChatHandlers()
 void
 ChatServicesManager::publishMessage(pluginMessagePtr& message)
 {
-    if (message->fromPlugin || !jami::Manager::instance().pluginPreferences.getPluginsEnabled())
+    if (message->fromPlugin)
         return;
     std::pair<std::string, std::string> mPair(message->accountId, message->peerId);
     auto& handlers = chatHandlerToggled_[mPair];