Skip to content
Snippets Groups Projects
Commit 265c5b74 authored by Tristan Matthews's avatar Tristan Matthews
Browse files

gnome: don't crash if device is plugged/unplugged

Widgets in the preferences dialog were being modified by incoming
D-Bus signals. For now, a warning is issued and the signal is ignored
in this case. In the future, this signal should only be connected while the
preferences window exists.

Refs #49540

Change-Id: I2058b169af6c9732cc7f63ee25050d04cea0e01c
parent 2f848d6b
No related branches found
No related tags found
No related merge requests found
...@@ -547,6 +547,8 @@ videocodecs_box(account_t *acc) ...@@ -547,6 +547,8 @@ videocodecs_box(account_t *acc)
static void static void
reset_combo_box(GtkComboBoxText *combo, gchar **entries, const gchar *preferred) reset_combo_box(GtkComboBoxText *combo, gchar **entries, const gchar *preferred)
{ {
g_assert(GTK_IS_WIDGET(combo));
guint index = 0; /* first one if not found */ guint index = 0; /* first one if not found */
/* Temporarily deactivate the "changed" signal to clear the list */ /* Temporarily deactivate the "changed" signal to clear the list */
...@@ -673,6 +675,8 @@ combo_box_rate_changed_cb(G_GNUC_UNUSED GtkComboBoxText *combo, gpointer data) ...@@ -673,6 +675,8 @@ combo_box_rate_changed_cb(G_GNUC_UNUSED GtkComboBoxText *combo, gpointer data)
void void
video_device_event_cb(G_GNUC_UNUSED DBusGProxy *proxy, G_GNUC_UNUSED gpointer foo) video_device_event_cb(G_GNUC_UNUSED DBusGProxy *proxy, G_GNUC_UNUSED gpointer foo)
{ {
/* FIXME: get rid of these global widgets */
g_return_if_fail(GTK_IS_WIDGET(v4l2Device));
fill_devices(); fill_devices();
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment