* #24789: dbus: hangupCall/Conference returns a boolean

daemon/src/dbus/callmanager-introspec.xml

@@ -81,6 +81,11 @@
                 The callID.
               </tp:docstring>
             </arg>
+            <arg type="b" name="isHungUp" direction="out">
+              <tp:docstring>
+                Returns true is the call has been hungup. False otherwise.
+              </tp:docstring>
+            </arg>
         </method>
 
         <method name="hangUpConference" tp:name-for-bindings="hangUpConference">
@@ -93,6 +98,11 @@
                 The unique conference ID.
               </tp:docstring>
             </arg>
+            <arg type="b" name="isHungUp" direction="out">
+              <tp:docstring>
+                Returns true is the conference has been hungup. False otherwise.
+              </tp:docstring>
+            </arg>
         </method>
 
         <method name="hold" tp:name-for-bindings="hold">

daemon/src/dbus/callmanager.cpp

@@ -96,16 +96,16 @@ CallManager::accept(const std::string& callID)
     Manager::instance().answerCall(callID);
 }
 
-void
+bool
 CallManager::hangUp(const std::string& callID)
 {
-    Manager::instance().hangupCall(callID);
+    return Manager::instance().hangupCall(callID);
 }
 
-void
+bool
 CallManager::hangUpConference(const std::string& confID)
 {
-    Manager::instance().hangupConference(confID);
+    return Manager::instance().hangupConference(confID);
 }
 
 void

daemon/src/dbus/callmanager.h

@@ -78,7 +78,7 @@ class CallManager
 
         void refuse(const std::string& callID);
         void accept(const std::string& callID);
-        void hangUp(const std::string& callID);
+        bool hangUp(const std::string& callID);
         void hold(const std::string& callID);
         void unhold(const std::string& callID);
         void transfer(const std::string& callID, const std::string& to);
@@ -94,7 +94,7 @@ class CallManager
         void addMainParticipant(const std::string& confID);
         void detachParticipant(const std::string& callID);
         void joinConference(const std::string& sel_confID, const std::string& drag_confID);
-        void hangUpConference(const std::string& confID);
+        bool hangUpConference(const std::string& confID);
         void holdConference(const std::string& confID);
         void unholdConference(const std::string& confID);
         std::vector<std::string> getConferenceList();

gnome/src/dbus/callmanager-introspec.xml

@@ -81,6 +81,11 @@
                 The callID.
               </tp:docstring>
             </arg>
+            <arg type="b" name="isHungUp" direction="out">
+              <tp:docstring>
+                Returns true is the call has been hungup. False otherwise.
+              </tp:docstring>
+            </arg>
         </method>
 
         <method name="hangUpConference" tp:name-for-bindings="hangUpConference">
@@ -93,6 +98,11 @@
                 The unique conference ID.
               </tp:docstring>
             </arg>
+            <arg type="b" name="isHungUp" direction="out">
+              <tp:docstring>
+                Returns true is the conference has been hungup. False otherwise.
+              </tp:docstring>
+            </arg>
         </method>
 
         <method name="hold" tp:name-for-bindings="hold">

gnome/src/dbus/dbus.c

@@ -972,8 +972,10 @@ dbus_stop_recorded_file_playback(const gchar *filepath)
 }
 
 static void
-hang_up_reply_cb(G_GNUC_UNUSED DBusGProxy *proxy, GError *error, G_GNUC_UNUSED gpointer userdata)
+hang_up_reply_cb(G_GNUC_UNUSED DBusGProxy *proxy, gboolean is_hung_up, GError *error, G_GNUC_UNUSED gpointer userdata)
 {
+    if (!is_hung_up)
+        g_warning("Did not hang up properly");
     check_error(error);
 }