build: fix compilation with clang

Refs #69759

Change-Id: I31cc7ab37a756f8750d84829e187ca81aa159701

src/rational.h

@@ -31,6 +31,8 @@
 
 #pragma once
 
+#include <cstdlib> // std::abs
+
 namespace ring {
 
 /**

src/ringdht/ringaccount.cpp

@@ -81,7 +81,7 @@ static constexpr int ICE_INIT_TIMEOUT {5};
 static constexpr int ICE_NEGOTIATION_TIMEOUT {60};
 
 constexpr const char * const RingAccount::ACCOUNT_TYPE;
-constexpr const std::pair<uint16_t, uint16_t> RingAccount::DHT_PORT_RANGE;
+/* constexpr */ const std::pair<uint16_t, uint16_t> RingAccount::DHT_PORT_RANGE {4000, 8888};
 
 RingAccount::RingAccount(const std::string& accountID, bool /* presenceEnabled */)
     : SIPAccountBase(accountID), via_addr_()

src/ringdht/ringaccount.h

@@ -79,7 +79,7 @@ class RingAccount : public SIPAccountBase {
         constexpr static const char * const ACCOUNT_TYPE = "RING";
         constexpr static const in_port_t DHT_DEFAULT_PORT = 4222;
         constexpr static const char * const DHT_DEFAULT_BOOTSTRAP = "bootstrap.ring.cx";
-        constexpr static const std::pair<uint16_t, uint16_t> DHT_PORT_RANGE {4000, 8888};
+        /* constexpr */ static const std::pair<uint16_t, uint16_t> DHT_PORT_RANGE;
 
         const char* getAccountType() const {
             return ACCOUNT_TYPE;

src/sip/sipaccountbase.cpp

@@ -276,6 +276,7 @@ uint16_t
 SIPAccountBase::acquirePort(uint16_t port)
 {
     getPortsReservation()[port / 2] = true;
+    return port;
 }
 
 void