Skip to content
Snippets Groups Projects
Commit 451854b2 authored by Sébastien Blin's avatar Sébastien Blin Committed by Adrien Béraud
Browse files

jamiaccount: make getIceOptions async and resolve ips

storeActiveIpAddress is done for each connectivityChange(), but
this logic is incorrect, because the ISP can change the IP of the
router without any connectivityChange(). This means that if no
connectivityChange() the address in the candidates will be incorrect
if the public ip is changed by the ISP.
The idea here is to get the public IP as soon as the IceOptions are
generated.
This changes the signature of getIceOptions() and removes it from
Account. After all, the account has no need to always manage ICE
the same way (maybe one day we will have accounts without ICE).

GitLab: #534
Change-Id: I56613e9ce48ef21f66dcf188d33334802aae601b
parent d97121c4
Branches
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment