contacts: remove unlocked saveTrustRequests

GitLab: #942
Change-Id: Ifdd50fc15695123f5ec41cb3eabb3a23b79e85dc

src/jamidht/account_manager.cpp

@@ -103,7 +103,6 @@ AccountManager::onSyncData(DeviceSync&& sync, bool checkDevice)
                                         false,
                                         tr.second.conversationId,
                                         {});
-    info_->contacts->saveTrustRequests();
 }
 
 dht::crypto::Identity
@@ -359,7 +358,6 @@ AccountManager::startSync(const OnNewDeviceCb& cb, const OnDeviceAnnouncedCb& dc
                             JAMI_WARNING("Accept with old convId: {}", conversationId);
                         }
                         sendTrustRequestConfirm(peer_account, conversationId);
-                        info_->contacts->saveTrustRequests();
                     }
             });
         return true;

src/jamidht/contact_list.cpp

@@ -254,6 +254,7 @@ ContactList::saveContacts() const
 void
 ContactList::saveTrustRequests() const
 {
+    // mutex_ MUST BE locked
     std::ofstream file(path_ / "incomingTrustRequests",
                        std::ios::trunc | std::ios::binary);
     msgpack::pack(file, trustRequests_);

src/jamidht/contact_list.h

@@ -128,9 +128,6 @@ public:
     bool acceptTrustRequest(const dht::InfoHash& from);
     bool discardTrustRequest(const dht::InfoHash& from);
 
-    /** Should be called only after onTrustRequest */
-    void saveTrustRequests() const;
-
     /* Devices */
     const std::map<dht::PkId, KnownDevice>& getKnownDevices() const { return knownDevices_; }
     void foundAccountDevice(const dht::PkId& device,
@@ -169,6 +166,9 @@ private:
 
     void loadKnownDevices();
     void saveKnownDevices() const;
+
+    /** Should be called only after onTrustRequest */
+    void saveTrustRequests() const;
 };
 
 } // namespace jami