* #15717: gnome: remove "start-hidden" option

Checking it meant that the GUI would stay permanently invisible.

gnome/data/org.sflphone.SFLphone.gschema.xml

@@ -45,11 +45,6 @@
             <summary>Instant messaging is enabled</summary>
             <description>Instant messaging is enabled.</description>
         </key>
-        <key name="start-hidden" type="b">
-            <default>false</default>
-            <summary>Start hidden</summary>
-            <description>Start hidden.</description>
-        </key>
         <key name="message-tab-height" type="i">
             <default>20</default>
             <summary>Message tab height</summary>

gnome/src/config/preferencesdialog.c

@@ -65,7 +65,6 @@
  */
 static GtkWidget * history_value;
 
-static GtkWidget *starthidden;
 static GtkWidget *popupwindow;
 static GtkWidget *neverpopupwindow;
 
@@ -85,13 +84,6 @@ static gboolean history_enabled = TRUE;
 // instant messaging preference parameters
 static gboolean instant_messaging_enabled = TRUE;
 
-static void
-start_hidden(GtkWidget *widget UNUSED, GSettings *settings)
-{
-    const gboolean currentstate = g_settings_get_boolean(settings, "start-hidden");
-    g_settings_set_boolean(settings, "start-hidden", !currentstate);
-}
-
 static void
 set_popup_mode(GtkToggleButton *widget, GSettings *settings)
 {
@@ -139,7 +131,6 @@ void showstatusicon_cb(GtkToggleButton *widget, GSettings *settings)
     // Update the widget states
     gtk_widget_set_sensitive(GTK_WIDGET(popupwindow), currentstatus);
     gtk_widget_set_sensitive(GTK_WIDGET(neverpopupwindow), currentstatus);
-    gtk_widget_set_sensitive(GTK_WIDGET(starthidden), currentstatus);
 
     currentstatus ? show_status_icon(settings) : hide_status_icon();
 
@@ -222,19 +213,9 @@ create_general_settings(GSettings *settings)
         GTK_TOGGLE_BUTTON(neverpopupwindow),
         TRUE);
 
-    starthidden = gtk_check_button_new_with_mnemonic(
-                      _("Hide SFLphone window on _startup"));
-
-    gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(starthidden),
-                                 g_settings_get_boolean(settings, "start-hidden"));
-    g_signal_connect(G_OBJECT(starthidden) , "clicked" , G_CALLBACK(start_hidden), settings);
-    gtk_table_attach(GTK_TABLE(table), starthidden, 0, 1, 3, 4, GTK_EXPAND
-                     | GTK_FILL, GTK_EXPAND | GTK_FILL, 0, 5);
-
     // Update the widget states
     gtk_widget_set_sensitive(GTK_WIDGET(popupwindow),statusicon);
     gtk_widget_set_sensitive(GTK_WIDGET(neverpopupwindow),statusicon);
-    gtk_widget_set_sensitive(GTK_WIDGET(starthidden),statusicon);
 
     // HISTORY CONFIGURATION
     gnome_main_section_new_with_table(_("Calls History"), &frame, &table, 3, 1);

gnome/src/main.c

@@ -142,11 +142,6 @@ main(int argc, char *argv[])
 
     create_main_window(settings);
 
-    if (show_status && g_settings_get_boolean(settings, "start-hidden")) {
-        gtk_widget_hide(GTK_WIDGET(get_main_window()));
-        set_minimized(TRUE);
-    }
-
     status_bar_display_account();
 
     sflphone_fill_history_lazy();