* #6596: AudioSymmetricSession shouldn't self-delete

This lead to a dead-lock in its destructor. Instead, AudioRtpFactory
must delete it.

sflphone-common/src/audio/audiortp/AudioRtpFactory.cpp

@@ -172,6 +172,7 @@ void AudioRtpFactory::stop (void)
         }
 
         _rtpSession->stopRtpThread();
+        delete _rtpSession;
 
         _rtpSession = NULL;
     } catch (...) {

sflphone-common/src/audio/audiortp/AudioRtpSession.cpp

@@ -302,14 +302,13 @@ int AudioRtpSession::startRtpThread (AudioCodec* audiocodec)
 
 void AudioRtpSession::stopRtpThread ()
 {
+    _queue->disableStack();
     if (_type != Zrtp) {
         AudioSymmetricRtpSession *self = dynamic_cast<AudioSymmetricRtpSession*>(this);
         assert(self);
         _debug ("AudioSymmetricRtpSession: Stopping main thread");
         self->stopSymmetricRtpThread();
     }
-
-    _queue->disableStack();
 }
 
 

sflphone-common/src/audio/audiortp/AudioSymmetricRtpSession.cpp

@@ -62,9 +62,6 @@ AudioSymmetricRtpSession::~AudioSymmetricRtpSession()
 void AudioSymmetricRtpSession::final()
 {
     delete _rtpThread;
-
-    // See: http://www.parashift.com/c++-faq-lite/freestore-mgmt.html#faq-16.15
-    delete this;
 }
 
 AudioSymmetricRtpSession::AudioRtpThread::AudioRtpThread (AudioSymmetricRtpSession *session) : running (true), rtpSession (session)
@@ -74,7 +71,6 @@ AudioSymmetricRtpSession::AudioRtpThread::AudioRtpThread (AudioSymmetricRtpSessi
 
 AudioSymmetricRtpSession::AudioRtpThread::~AudioRtpThread()
 {
-    ost::Thread::terminate();
     _debug ("AudioSymmetricRtpSession: Delete rtp thread");
 }
 

sflphone-common/src/audio/audiortp/AudioSymmetricRtpSession.h

@@ -55,7 +55,6 @@ using std::ptrdiff_t;
 namespace sfl
 {
 
-// class AudioSymmetricRtpSession : protected ost::Thread, public ost::TimerPort, public AudioRtpRecordHandler, public ost::TRTPSessionBase<ost::DualRTPUDPIPv4Channel,ost::DualRTPUDPIPv4Channel,ost::AVPQueue>
 class AudioSymmetricRtpSession : public ost::TimerPort, public ost::SymmetricRTPSession, public AudioRtpSession
 {
     public:
@@ -69,9 +68,6 @@ class AudioSymmetricRtpSession : public ost::TimerPort, public ost::SymmetricRTP
 
         virtual void final ();
 
-        // Thread associated method
-        // virtual void run ();
-
         virtual bool onRTPPacketRecv (ost::IncomingRTPPkt& pkt) { return AudioRtpSession::onRTPPacketRecv(pkt); }
 
         int startSymmetricRtpThread (void) {