Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
jami-daemon
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Locked files
Deploy
Releases
Model registry
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
savoirfairelinux
jami-daemon
Commits
a0d9e61e
Commit
a0d9e61e
authored
13 years ago
by
Alexandre Savard
Browse files
Options
Downloads
Patches
Plain Diff
#6183: Fix icons inconsistencies in history for conference hang up
parent
afe5e78a
Branches
Branches containing commit
Tags
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
sflphone-client-gnome/src/contacts/calltree.c
+28
-17
28 additions, 17 deletions
sflphone-client-gnome/src/contacts/calltree.c
with
28 additions
and
17 deletions
sflphone-client-gnome/src/contacts/calltree.c
+
28
−
17
View file @
a0d9e61e
...
...
@@ -921,19 +921,26 @@ calltree_update_call (calltab_t* tab, callable_obj_t * c, GtkTreeIter *parent)
}
}
else
if
(
tab
==
history
)
{
switch
(
c
->
_history_state
)
{
case
INCOMING
:
pixbuf
=
gdk_pixbuf_new_from_file
(
ICONS_DIR
"/incoming.svg"
,
NULL
);
break
;
case
OUTGOING
:
pixbuf
=
gdk_pixbuf_new_from_file
(
ICONS_DIR
"/outgoing.svg"
,
NULL
);
break
;
case
MISSED
:
pixbuf
=
gdk_pixbuf_new_from_file
(
ICONS_DIR
"/missed.svg"
,
NULL
);
break
;
default:
WARN
(
"History - Should not happen!"
);
}
if
(
parent
==
NULL
)
{
// parent is NULL this is not a conference participant
switch
(
c
->
_history_state
)
{
case
INCOMING
:
pixbuf
=
gdk_pixbuf_new_from_file
(
ICONS_DIR
"/incoming.svg"
,
NULL
);
break
;
case
OUTGOING
:
pixbuf
=
gdk_pixbuf_new_from_file
(
ICONS_DIR
"/outgoing.svg"
,
NULL
);
break
;
case
MISSED
:
pixbuf
=
gdk_pixbuf_new_from_file
(
ICONS_DIR
"/missed.svg"
,
NULL
);
break
;
default:
WARN
(
"History - Should not happen!"
);
}
}
else
{
// parent is not NULL this is a conference participant
pixbuf
=
gdk_pixbuf_new_from_file
(
ICONS_DIR
"/current.svg"
,
NULL
);
}
calltree_display_call_info
(
c
,
DISPLAY_TYPE_HISTORY
,
NULL
,
&
description
);
...
...
@@ -963,7 +970,7 @@ calltree_update_call (calltab_t* tab, callable_obj_t * c, GtkTreeIter *parent)
void
calltree_add_call
(
calltab_t
*
tab
,
callable_obj_t
*
c
,
GtkTreeIter
*
parent
)
{
DEBUG
(
"CallTree: Add call to calltree id: %s, peer name: %s"
,
c
->
_callID
,
c
->
_peer_name
);
DEBUG
(
"
-----------------------------------------------
CallTree: Add call to calltree id: %s, peer name: %s"
,
c
->
_callID
,
c
->
_peer_name
);
if
(
tab
==
history
)
{
calltree_add_history_entry
(
c
,
parent
);
...
...
@@ -1082,7 +1089,7 @@ void calltree_add_call (calltab_t* tab, callable_obj_t * c, GtkTreeIter *parent)
void
calltree_add_history_entry
(
callable_obj_t
*
c
,
GtkTreeIter
*
parent
)
{
DEBUG
(
"CallTree: Calltree add history entry %s"
,
c
->
_callID
);
DEBUG
(
"
-------------------------------------------------
CallTree: Calltree add history entry %s"
,
c
->
_callID
);
if
(
!
eel_gconf_get_integer
(
HISTORY_ENABLED
))
return
;
...
...
@@ -1099,9 +1106,11 @@ void calltree_add_history_entry (callable_obj_t *c, GtkTreeIter *parent)
gtk_tree_store_prepend
(
history
->
store
,
&
iter
,
parent
);
if
(
parent
==
NULL
)
{
DEBUG
(
"---------------------------------------- PARENT NULL, THIS IS NOT A CONFERENCE PARTICIPANT"
);
// this is a first level call not participating to a conference
switch
(
c
->
_history_state
)
{
case
INCOMING
:
DEBUG
(
"--------------------------------------- INCOMING"
);
pixbuf
=
gdk_pixbuf_new_from_file
(
ICONS_DIR
"/incoming.svg"
,
NULL
);
break
;
case
OUTGOING
:
...
...
@@ -1115,6 +1124,7 @@ void calltree_add_history_entry (callable_obj_t *c, GtkTreeIter *parent)
}
}
else
{
DEBUG
(
"--------------------------------------------- PARENT IS NOT NULL, THIS IS A CONFERENCE PARTICIPANT"
);
// participant to a conference
pixbuf
=
gdk_pixbuf_new_from_file
(
ICONS_DIR
"/current.svg"
,
NULL
);
}
...
...
@@ -1319,10 +1329,11 @@ void calltree_add_conference (calltab_t* tab, conference_obj_t* conf)
g_object_unref
(
G_OBJECT
(
pixbuf
));
}
/*
if(tab == history) {
return;
}
*/
conference_participant
=
conf
->
participant_list
;
if
(
conference_participant
)
{
...
...
@@ -1441,7 +1452,7 @@ void calltree_add_history_conference(conference_obj_t *conf)
ERROR
(
"CallTree: Error conference is NULL"
);
}
DEBUG
(
"CallTree: Add conference %s to history"
,
conf
->
_confID
);
DEBUG
(
"
----------------------------------------------------------
CallTree: Add conference %s to history"
,
conf
->
_confID
);
gtk_tree_store_prepend
(
history
->
store
,
&
iter
,
NULL
);
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment