Skip to content
Snippets Groups Projects
Commit a294e484 authored by Guillaume Roguez's avatar Guillaume Roguez Committed by gerrit2
Browse files

ringdht: fix big parameter passed by value

Fix definition of RingAccount::createIceTransport
to pass by reference and not by value as ICE option
structure is not small (more than 200 bytes).

coverity CID #1369566

Change-Id: I41f17a266384e28e1cab9a17e17c8436f07a22d4
Tuleap: #909
parent e1081be4
Branches
Tags
No related merge requests found
...@@ -114,7 +114,7 @@ parseRingUri(const std::string& toUrl) ...@@ -114,7 +114,7 @@ parseRingUri(const std::string& toUrl)
*/ */
template <class... Args> template <class... Args>
std::shared_ptr<IceTransport> std::shared_ptr<IceTransport>
RingAccount::createIceTransport(Args... args) RingAccount::createIceTransport(const Args&... args)
{ {
// We need a public address in case of NAT'ed network // We need a public address in case of NAT'ed network
// Trying to use one discovered by DHT service // Trying to use one discovered by DHT service
......
...@@ -414,7 +414,7 @@ class RingAccount : public SIPAccountBase { ...@@ -414,7 +414,7 @@ class RingAccount : public SIPAccountBase {
pjsip_transport* via_tp_ {nullptr}; pjsip_transport* via_tp_ {nullptr};
template <class... Args> template <class... Args>
std::shared_ptr<IceTransport> createIceTransport(Args... args); std::shared_ptr<IceTransport> createIceTransport(const Args&... args);
}; };
} // namespace ring } // namespace ring
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment