conversation: verify conversationId before cloning

This patch validates the conversationId before proceeding with
cloning. Otherwise, an empty conversationId could lead to
accidental removal of the entire conversations directory.

https://git.jami.net/savoirfairelinux/jami-client-qt/-/issues/1982
Change-Id: I428247498bb7533b12dadb8a479779e228e6dfb6

src/jamidht/conversationrepository.cpp

@@ -2635,6 +2635,12 @@ ConversationRepository::cloneConversation(
     const std::string& conversationId,
     std::function<void(std::vector<ConversationCommit>)>&& checkCommitCb)
 {
+    // Verify conversationId is not empty to avoid deleting the entire conversations directory
+    if (conversationId.empty()) {
+        JAMI_ERROR("[Account {}] Clone conversation with empty conversationId", account->getAccountID());
+        return nullptr;
+    }
+
     auto conversationsPath = fileutils::get_data_dir() / account->getAccountID() / "conversations";
     dhtnet::fileutils::check_dir(conversationsPath);
     auto path = conversationsPath / conversationId;