Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
jami-daemon
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Locked files
Deploy
Releases
Model registry
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
savoirfairelinux
jami-daemon
Commits
ba8e1cf4
Commit
ba8e1cf4
authored
5 years ago
by
Kateryna Kostiuk
Browse files
Options
Downloads
Patches
Plain Diff
conference macOS: use previously selected format
Change-Id: If84669cd16bd912ed0db92c50252159db43b95a3
parent
ec56378d
Branches
Branches containing commit
No related tags found
No related merge requests found
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
src/media/video/video_mixer.cpp
+4
-3
4 additions, 3 deletions
src/media/video/video_mixer.cpp
src/media/video/video_mixer.h
+2
-1
2 additions, 1 deletion
src/media/video/video_mixer.h
src/media/video/video_rtp_session.cpp
+7
-3
7 additions, 3 deletions
src/media/video/video_rtp_session.cpp
with
13 additions
and
7 deletions
src/media/video/video_mixer.cpp
+
4
−
3
View file @
ba8e1cf4
...
...
@@ -142,7 +142,7 @@ VideoMixer::process()
VideoFrame
&
output
=
getNewFrame
();
try
{
output
.
reserve
(
AV_PIX_FMT_YUV422P
,
width_
,
height_
);
output
.
reserve
(
format_
,
width_
,
height_
);
}
catch
(
const
std
::
bad_alloc
&
e
)
{
JAMI_ERR
(
"VideoFrame::allocBuffer() failed"
);
return
;
...
...
@@ -217,12 +217,13 @@ VideoMixer::render_frame(VideoFrame& output, const VideoFrame& input,
}
void
VideoMixer
::
set
Dimension
s
(
int
width
,
int
height
)
VideoMixer
::
set
Parameter
s
(
int
width
,
int
height
,
AVPixelFormat
format
)
{
auto
lock
(
rwMutex_
.
write
());
width_
=
width
;
height_
=
height
;
format_
=
format
;
// cleanup the previous frame to have a nice copy in rendering method
std
::
shared_ptr
<
VideoFrame
>
previous_p
(
obtainLastFrame
());
...
...
@@ -268,6 +269,6 @@ VideoMixer::getHeight() const
AVPixelFormat
VideoMixer
::
getPixelFormat
()
const
{
return
AV_PIX_FMT_YUYV422
;
}
{
return
format_
;
}
}}
// namespace jami::video
This diff is collapsed.
Click to expand it.
src/media/video/video_mixer.h
+
2
−
1
View file @
ba8e1cf4
...
...
@@ -43,7 +43,7 @@ public:
VideoMixer
(
const
std
::
string
&
id
);
~
VideoMixer
();
void
set
Dimension
s
(
int
width
,
int
height
);
void
set
Parameter
s
(
int
width
,
int
height
,
AVPixelFormat
format
=
AV_PIX_FMT_YUV422P
);
int
getWidth
()
const
override
;
int
getHeight
()
const
override
;
...
...
@@ -70,6 +70,7 @@ private:
const
std
::
string
id_
;
int
width_
=
0
;
int
height_
=
0
;
AVPixelFormat
format_
=
AV_PIX_FMT_YUV422P
;
std
::
list
<
std
::
unique_ptr
<
VideoMixerSource
>>
sources_
;
rw_mutex
rwMutex_
;
...
...
This diff is collapsed.
Click to expand it.
src/media/video/video_rtp_session.cpp
+
7
−
3
View file @
ba8e1cf4
...
...
@@ -300,7 +300,13 @@ VideoRtpSession::enterConference(Conference* conference)
if
(
send_
.
enabled
or
receiveThread_
)
{
videoMixer_
=
conference
->
getVideoMixer
();
videoMixer_
->
setDimensions
(
localVideoParams_
.
width
,
localVideoParams_
.
height
);
#if defined(__APPLE__) && TARGET_OS_MAC
videoMixer_
->
setParameters
(
localVideoParams_
.
width
,
localVideoParams_
.
height
,
av_get_pix_fmt
(
localVideoParams_
.
pixel_format
.
c_str
()));
#else
videoMixer_
->
setParameters
(
localVideoParams_
.
width
,
localVideoParams_
.
height
);
#endif
setupConferenceVideoPipeline
(
*
conference_
);
}
}
...
...
@@ -574,5 +580,3 @@ VideoRtpSession::getPonderateLoss(float lastLoss)
}}
// namespace jami::video
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment