Skip to content
Snippets Groups Projects
Commit c1fae971 authored by Rafaël Carré's avatar Rafaël Carré
Browse files

yamlnode: use const references when possible (still some left to do)

parent 9abe8557
No related branches found
No related tags found
No related merge requests found
...@@ -95,13 +95,13 @@ void MappingNode::addNode (YamlNode *node) ...@@ -95,13 +95,13 @@ void MappingNode::addNode (YamlNode *node)
map.insert (it, std::pair<std::string, YamlNode *> (tmpKey, node)); map.insert (it, std::pair<std::string, YamlNode *> (tmpKey, node));
} }
void MappingNode::setKeyValue (std::string key, YamlNode *value) void MappingNode::setKeyValue (const std::string &key, YamlNode *value)
{ {
Mapping::iterator it = map.end(); Mapping::iterator it = map.end();
map.insert (it, std::pair<std::string, YamlNode *> (key, value)); map.insert (it, std::pair<std::string, YamlNode *> (key, value));
} }
void MappingNode::removeKeyValue (std::string key) void MappingNode::removeKeyValue (const std::string &key)
{ {
Mapping::iterator it = map.find (key); Mapping::iterator it = map.find (key);
...@@ -109,7 +109,7 @@ void MappingNode::removeKeyValue (std::string key) ...@@ -109,7 +109,7 @@ void MappingNode::removeKeyValue (std::string key)
} }
YamlNode *MappingNode::getValue (std::string key) YamlNode *MappingNode::getValue (const std::string &key)
{ {
Mapping::iterator it = map.find (key); Mapping::iterator it = map.find (key);
...@@ -122,7 +122,7 @@ YamlNode *MappingNode::getValue (std::string key) ...@@ -122,7 +122,7 @@ YamlNode *MappingNode::getValue (std::string key)
} }
} }
void MappingNode::getValue (std::string key, bool *b) void MappingNode::getValue (const std::string &key, bool *b)
{ {
ScalarNode *node = (ScalarNode*)getValue(key); ScalarNode *node = (ScalarNode*)getValue(key);
if (!node) if (!node)
...@@ -132,7 +132,7 @@ void MappingNode::getValue (std::string key, bool *b) ...@@ -132,7 +132,7 @@ void MappingNode::getValue (std::string key, bool *b)
*b = v == "true"; *b = v == "true";
} }
void MappingNode::getValue (std::string key, int *i) void MappingNode::getValue (const std::string &key, int *i)
{ {
ScalarNode *node = (ScalarNode*)getValue(key); ScalarNode *node = (ScalarNode*)getValue(key);
if (!node) if (!node)
...@@ -142,7 +142,7 @@ void MappingNode::getValue (std::string key, int *i) ...@@ -142,7 +142,7 @@ void MappingNode::getValue (std::string key, int *i)
*i = atoi(v.c_str()); *i = atoi(v.c_str());
} }
void MappingNode::getValue (std::string key, std::string *v) void MappingNode::getValue (const std::string &key, std::string *v)
{ {
ScalarNode *node = (ScalarNode*)getValue(key); ScalarNode *node = (ScalarNode*)getValue(key);
if (!node) if (!node)
......
...@@ -143,14 +143,14 @@ class MappingNode : public YamlNode ...@@ -143,14 +143,14 @@ class MappingNode : public YamlNode
tmpKey = key; tmpKey = key;
} }
void setKeyValue (std::string key, YamlNode *value); void setKeyValue (const std::string &key, YamlNode *value);
void removeKeyValue (std::string key); void removeKeyValue (const std::string &key);
YamlNode *getValue (std::string key); YamlNode *getValue (const std::string &key);
void getValue (std::string key, bool *b); void getValue (const std::string &key, bool *b);
void getValue (std::string key, int *i); void getValue (const std::string &key, int *i);
void getValue (std::string key, std::string *s); void getValue (const std::string &key, std::string *s);
virtual void deleteChildNodes (void); virtual void deleteChildNodes (void);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment