Skip to content
Snippets Groups Projects
Commit ca4fb50b authored by Tristan Matthews's avatar Tristan Matthews
Browse files

* #9979: cleanup

parent 88832a4d
No related branches found
No related tags found
No related merge requests found
...@@ -37,7 +37,7 @@ class Alaw : public sfl::AudioCodec { ...@@ -37,7 +37,7 @@ class Alaw : public sfl::AudioCodec {
public: public:
// 8 PCMA A 8000 1 [RFC3551] // 8 PCMA A 8000 1 [RFC3551]
Alaw(int payload = 8) : sfl::AudioCodec(payload, "PCMA") { Alaw() : sfl::AudioCodec(8, "PCMA") {
clockRate_ = 8000; clockRate_ = 8000;
frameSize_ = 160; // samples, 20 ms at 8kHz frameSize_ = 160; // samples, 20 ms at 8kHz
channel_ = 1; channel_ = 1;
...@@ -131,7 +131,7 @@ class Alaw : public sfl::AudioCodec { ...@@ -131,7 +131,7 @@ class Alaw : public sfl::AudioCodec {
// cppcheck-suppress unusedFunction // cppcheck-suppress unusedFunction
extern "C" sfl::Codec* create() extern "C" sfl::Codec* create()
{ {
return new Alaw(8); return new Alaw;
} }
// cppcheck-suppress unusedFunction // cppcheck-suppress unusedFunction
......
...@@ -41,7 +41,7 @@ ...@@ -41,7 +41,7 @@
class G722 : public sfl::AudioCodec { class G722 : public sfl::AudioCodec {
public: public:
G722(int payload = 9) : sfl::AudioCodec(payload, "G722"), decode_state_(), encode_state_() { G722() : sfl::AudioCodec(9, "G722"), decode_state_(), encode_state_() {
clockRate_ = 16000; clockRate_ = 16000;
frameSize_ = 320; // samples, 20 ms at 16kHz frameSize_ = 320; // samples, 20 ms at 16kHz
channel_ = 1; channel_ = 1;
...@@ -765,7 +765,7 @@ class G722 : public sfl::AudioCodec { ...@@ -765,7 +765,7 @@ class G722 : public sfl::AudioCodec {
// cppcheck-suppress unusedFunction // cppcheck-suppress unusedFunction
extern "C" sfl::Codec* create() extern "C" sfl::Codec* create()
{ {
return new G722(9); return new G722;
} }
// cppcheck-suppress unusedFunction // cppcheck-suppress unusedFunction
......
...@@ -31,6 +31,7 @@ ...@@ -31,6 +31,7 @@
#include "audiocodec.h" #include "audiocodec.h"
#include "sfl_types.h"
#include "noncopyable.h" #include "noncopyable.h"
#include <cassert> #include <cassert>
#include <stdexcept> #include <stdexcept>
...@@ -47,7 +48,7 @@ class Gsm : public sfl::AudioCodec { ...@@ -47,7 +48,7 @@ class Gsm : public sfl::AudioCodec {
public: public:
// _payload should be 3 // _payload should be 3
Gsm(int payload=3) : sfl::AudioCodec(payload, "GSM"), decode_gsmhandle_(NULL), encode_gsmhandle_(NULL) { Gsm() : sfl::AudioCodec(3, "GSM"), decode_gsmhandle_(NULL), encode_gsmhandle_(NULL) {
clockRate_ = 8000; clockRate_ = 8000;
frameSize_ = 160; // samples, 20 ms at 8kHz frameSize_ = 160; // samples, 20 ms at 8kHz
channel_ = 1; channel_ = 1;
...@@ -61,12 +62,14 @@ class Gsm : public sfl::AudioCodec { ...@@ -61,12 +62,14 @@ class Gsm : public sfl::AudioCodec {
throw std::runtime_error("ERROR: encode_gsm_create\n"); throw std::runtime_error("ERROR: encode_gsm_create\n");
} }
virtual ~Gsm() { virtual ~Gsm()
{
gsm_destroy(decode_gsmhandle_); gsm_destroy(decode_gsmhandle_);
gsm_destroy(encode_gsmhandle_); gsm_destroy(encode_gsmhandle_);
} }
virtual int decode(short * dst, unsigned char * src, size_t buf_size) { virtual int decode(SFLDataFormat * dst, unsigned char * src, size_t buf_size)
{
assert(buf_size == 33); assert(buf_size == 33);
if (gsm_decode(decode_gsmhandle_, (gsm_byte*) src, (gsm_signal*) dst) < 0) if (gsm_decode(decode_gsmhandle_, (gsm_byte*) src, (gsm_signal*) dst) < 0)
...@@ -75,7 +78,8 @@ class Gsm : public sfl::AudioCodec { ...@@ -75,7 +78,8 @@ class Gsm : public sfl::AudioCodec {
return frameSize_; return frameSize_;
} }
virtual int encode(unsigned char * dst, short * src, size_t buf_size) { virtual int encode(unsigned char * dst, SFLDataFormat * src, size_t buf_size)
{
assert(buf_size >= 33); assert(buf_size >= 33);
gsm_encode(encode_gsmhandle_, (gsm_signal*) src, (gsm_byte*) dst); gsm_encode(encode_gsmhandle_, (gsm_signal*) src, (gsm_byte*) dst);
return 33; return 33;
...@@ -90,7 +94,7 @@ class Gsm : public sfl::AudioCodec { ...@@ -90,7 +94,7 @@ class Gsm : public sfl::AudioCodec {
// cppcheck-suppress unusedFunction // cppcheck-suppress unusedFunction
extern "C" sfl::Codec* create() extern "C" sfl::Codec* create()
{ {
return new Gsm(3); return new Gsm;
} }
// cppcheck-suppress unusedFunction // cppcheck-suppress unusedFunction
......
...@@ -36,8 +36,7 @@ ...@@ -36,8 +36,7 @@
class Ulaw : public sfl::AudioCodec { class Ulaw : public sfl::AudioCodec {
public: public:
// 0 PCMU A 8000 1 [RFC3551] // 0 PCMU A 8000 1 [RFC3551]
Ulaw(int payload=0) Ulaw() : sfl::AudioCodec(0, "PCMU") {
: sfl::AudioCodec(payload, "PCMU") {
clockRate_ = 8000; clockRate_ = 8000;
frameSize_ = 160; // samples, 20 ms at 8kHz frameSize_ = 160; // samples, 20 ms at 8kHz
channel_ = 1; channel_ = 1;
...@@ -126,7 +125,7 @@ class Ulaw : public sfl::AudioCodec { ...@@ -126,7 +125,7 @@ class Ulaw : public sfl::AudioCodec {
// cppcheck-suppress unusedFunction // cppcheck-suppress unusedFunction
extern "C" sfl::Codec* create() extern "C" sfl::Codec* create()
{ {
return new Ulaw(0); return new Ulaw;
} }
// cppcheck-suppress unusedFunction // cppcheck-suppress unusedFunction
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment