security: fix resource leaks in TlsVAlidator

This patch fix two calls to strdup() without any free().

Change-Id: I8619794e71d4165c154ba6ddd89bf6237e444a67
Tuleap: #906

src/security/tlsvalidator.cpp

@@ -846,9 +846,9 @@ TlsValidator::CheckResult TlsValidator::privateKeyDirectoryPermissions()
     if (privateKeyPath_.empty())
        return TlsValidator::CheckResult(CheckValues::UNSUPPORTED, "");
 
-    char* dup = strdup(privateKeyPath_.c_str());
 #ifndef WIN32_NATIVE
-    const char* dir = dirname(dup);
+    auto path = std::unique_ptr<char, decltype(free)&> (strdup(privateKeyPath_.c_str()), free);
+    const char* dir = dirname(path.get());
 #else
     char* dir;
     _splitpath(certificatePath_.c_str(), nullptr, dir, nullptr, nullptr);
@@ -869,9 +869,9 @@ TlsValidator::CheckResult TlsValidator::privateKeyDirectoryPermissions()
 
 TlsValidator::CheckResult TlsValidator::publicKeyDirectoryPermissions()
 {
-    char* dup = strdup(certificatePath_.c_str());
 #ifndef WIN32_NATIVE
-    const char* dir = dirname(dup);
+    auto path = std::unique_ptr<char, decltype(free)&>(strdup(certificatePath_.c_str()), free);
+    const char* dir = dirname(path.get());
 #else
     char* dir;
     _splitpath(certificatePath_.c_str(), nullptr, dir, nullptr, nullptr);