Change-Id: I1ef88bc640f79790aad2b5285ea2c776aa8cd366

Philippe Gorley authored 7 years ago and Guillaume Roguez committed 7 years ago

Change-Id: I1293f52e9b5255d30faf2dd4c2537831ff05062d
Reviewed-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

Fill AccountId and Peer field of outgoing and incoming data transfers.

Change-Id: I772e9c4560fb63c30e33c341cd296cacd6a45df6
Reviewed-by: Anthony Léonard <anthony.leonard@savoirfairelinux.com>

This certificate is know after a successful connect().

Change-Id: Ie8a351a1c6b97ec65c7d92b8ef4432d412f357eb
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

Compare only public Id is not secure enough to ensure
certificate comparaison.
Use a byte-comparaison to verify the peer certificate
during TLS certificate checkings.

Change-Id: Ic90877ba3722e69d833f3adf841b3ebde8e44d9f
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

Add AccountId and PeerUri to DataTransfertInfo structure.

Change-Id: I6cf3661d7d7f451da713a036c66c4aa5a1c671d8
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

Adrien Béraud authored 7 years ago and Philippe Gorley committed 7 years ago

Change-Id: I2794c1d374654870985a655a42ac647ff66c97a1
Reviewed-by: Philippe Gorley <philippe.gorley@savoirfairelinux.com>

Used to read the "enabled" property instead of "active".

Change-Id: I8d9751f55b5c68ae857a15887536d866c42a0982

Change-Id: Ic59bdd5104d3516f6aadf66b6b92d63a7f0dd561

Anthony Léonard authored 7 years ago and Andreas Traczyk committed 7 years ago

Incorrect condition was leading to bad pixel format conversion before
sending frames to client on macOS (BGR instead of correct RGB).

Change-Id: Ie76a488c4151d00249ed1adb5b0b02e43d2972eb
Reviewed-by: Andreas Traczyk <andreas.traczyk@savoirfairelinux.com>

Adrien Béraud authored 7 years ago and Philippe Gorley committed 7 years ago

Set EAGAIN if rxQueue_ is empty to avoid reading
an invalid queue front.

Change-Id: I10790755a32a8fe7f26afea19691aa2ff6fa63be
Reviewed-by: Philippe Gorley <philippe.gorley@savoirfairelinux.com>

Philippe Gorley authored 7 years ago and Adrien Béraud committed 7 years ago

Change-Id: Iacf37f3b6fc7016b3225066e164046b3db45c138

For debug purposes, all transfers were accepted by the daemon.

The request for validation of incoming file transfers is now active.
It relies on the accept method from IncomingFileTransfer that sets the
local path of the downloaded file, and starts the transfer.

Change-Id: Ib6ee870355604e3cec539ee138017ac79e3a818b
Reviewed-by: Anthony Léonard <anthony.leonard@savoirfairelinux.com>

Falling back from hardware to software decoding requires only a
reinitialization of the AVCodecContext. Hardware decoding failure is no
longer bubbled up to the RTP session, which makes it much faster.

Change-Id: I79fdfcfa41f822b3299d74ac654146789fcfd97b

- adds a slightly altered version of the android video implementation,
  as a swift AVFoundation implementation will be used in the ios client
  to enumerate the video input devices.

Change-Id: I7c16fc39c5d22e54fb146881150b6cbcfddb7806

Philippe Gorley authored 7 years ago and Adrien Béraud committed 7 years ago

Replaces empty methods and std::bind calls with lambdas.

Change-Id: I0d9c876a9ba0bbdc6a77a85e0e2d75766312f952

Change-Id: I5f92b0477817ed085b4a6073880d7872d53b460e
Reviewed-by: Nicolas Jäger <nicolas.jager@savoirfairelinux.com>

* modifying the API name of bytes progression
* add bytes progression reporting for incoming file transfer
* D-Bus binding adapted

Change-Id: Ife397ce7d13f248ed1df4338e62361ddbc9e2027
Reviewed-by: Anthony Léonard <anthony.leonard@savoirfairelinux.com>

File total byte size information was missing for incoming transfer.

Change-Id: I4aadc0d6ae2baced02a93c208d7476cf71609945
Reviewed-by: Anthony Léonard <anthony.leonard@savoirfairelinux.com>

"override" keyword missing for a method in TlsSession class declaration.

Change-Id: Ie8e98da6bd9a20246464593460b058200ee1c08b
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

Expose more data transfer API to D-Bus binding:
* acceptFileTransfer
* cancelDataTransfer

Change-Id: Ida42caf775d1a411ac640276140ac6d69b6eebc7
Reviewed-by: Anthony Léonard <anthony.leonard@savoirfairelinux.com>

fix crash occuring during data transfer destruction due to nullptr access
when the turn transport is destroyed.

list of changes:
* fix Turn/PJSIP callbacks registration (was a NPA due to unique_ptr dtor implementation)
* add a shutdown method to GenericSocket.
* implement shutdown into TlsSession and TurnTransport.
* use shutdown to unlock PeerConnection blocked into a read.
* do not call blocking methods that raises CtrlMsg into the eventloop.
* destroy clients/servers before turn socket .
* fix Turn pool cache destruction causing bad mem free.

Change-Id: I9995ce9419e8af965def9328a5de4a8973a4334f
Reviewed-by: Anthony Léonard <anthony.leonard@savoirfairelinux.com>

io error in endpoint write operation was not handled.
Add this by this patch and fixes write issues (ex, when peer disconnect).

Change-Id: I24dada649f4d9f9627d2d2ff8efcea2b2d44b4ad
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

Add API to obtain the list of known datatransfer.
libring and DBus API included.

Change-Id: I4e1a46c132f99bd36b4a531035dbc83261061093
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

Maxim Cournoyer authored 7 years ago and Guillaume Roguez committed 7 years ago

* CODING: Update wiki URLs and refresh content.
* ChangeLog: Fix typo.
* README: Likewise, and use HTTPS for URLs.
* doc/README: Rephrase.
* man/README.manpages: Fix typo.

Change-Id: I9d320ae2e5bdfacc84293001f08abb442da35fb5
Reviewed-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

Add ConfigurationManager::dataTransferBytesSent() DBus method access.

Change-Id: I74fc22f42faeb5c352059831150b6c8b7e813fd8
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

Mutex deadlock occuring during file transfer creation.
Exchanging some calls to fix the situation.

Change-Id: I2f0108e63e89a13e3f6f2c1b1e096fbf9a6a1290
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

static constexpr in class/struct need to be redeclared in namespace
scope until C++17 (at which point it will be deprecated).

Change-Id: I27f0448edd65f9d7d51ad5eb7263c76d17563072
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

add annotation type to fix Qt usage for the custom-type
added by the DBus dataTransferInfo method.

Change-Id: I62b8d13171d25c73850c6120a1e5fec8fda07e72
Reviewed-by: Anthony Léonard <anthony.leonard@savoirfairelinux.com>

Doxygen keywords must be backslashed, not slashed.

Change-Id: I625e1241981c46da2d5a17da4daf4b9a571f3a35
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

First implementation of Reliable Data Transfer feature in Ring.

This implementation is a draft, comes with a Python script
tools/dringctrl/sendfile.py to play with and doesn't
implement all the API as described into "datatransfer: API proposal"
commit.
This version uses TLS over TCP-TURN sockets to encrypt data.

Transfers require a TURN server with TCP peer connections
as described by the RFC-6062.

Testing: Currently only sendFile API is implemented and data are
saved into a temporary file saved in "/tmp/ring_XXXXXX",
where XXXXXX are replace by mkstemp() command.

Change-Id: I5b8f48432edd58df5046e368a99f58ea44046dcd
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

Or at least independant of underlaying transport...

To make TlsSession able to handle both TLS and DTLS
this patch removes the ICE dependency and replace is
by the generic network ABC class 'GenericTransport'.
As a first step this class is declared in tls_session.h.
Side effects of this change are:

* refactoring of PMTUD procedure: 'MTU' for gnutls has the meaning
  on 'payload-for-gnutls' so this information is now drived by
  the generic transport and not hardcoded anymore.
  The minimal value of probing remains hardcoded, as is a minimum
  given by RFC's documentation and it's based on an IPv4 packet
  associated with UDP protocol.

* getMtu() is now maxPayload() and represent correctly what
  the application must have.

* TlsSession implements itself GenericTransport: we can chain
  GenericTransport instances to construct an overlayed transport
  protocol.

* TlsSession is now considered as non thread-safe for its public API.
  Caller must bring itself this property.
  This permit to remove a redundant mutex in send() operation.
  Note: and it's the case in the only user (SipsIceTransport),
  that why the mutex is redundant in 100% of cases.

Notice the benefit of this genericity refactoring let us
write a unit-test for this TlsSession class without having
an heavy ICE transport to mock-up.

Also ICE transport gained of this by adding a new IceSocketTransport
to replace IceSocket in a near future (need async IO in GenericSocket,
but not required for the moment).

Change-Id: I6f4591ed6c76fa9cb5519c6e9296f8fc3a6798aa
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

Move all JNI file sources to the daemon. Ring Android client will use
this files to generate the final libring.so including the
ring_wrapper.cpp

Change-Id: I4e800bb1d33b5905c715054d1718c0bdb3fc1d55
Reviewed-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

fix for patch:
0f524801 PJSIP support to std::error_code and std::system_error

pj_strerror crashes on due to wrong given string size.

Change-Id: I8d68b885ce0d587b27e8b361c9ad60019ed355fb

Some practical C++ additions:
* class PjsipErrorCategory as error category for std::error_code.
* class PjsipFailure inheriting from std::system_error exception.

Change-Id: I957cd36d06cf49ae98cb6634f5e4d5dcac666be8

Debian Testing doesn't use the contribs, so bump down the FFmpeg
requirements in the configure.ac as well as making RING_ACCEL dependant
on a certain version of libavutil.

Reviewed-by: Alexandre Viau <alexandre.viau@savoirfairelinux.com>
Change-Id: I1f9d0de44e5f9d0bbb69b20d73a396de7e5d64b4

Guillaume Roguez authored 7 years ago and Philippe Gorley committed 7 years ago

fix nullptr access during incoming call on ringaccount
due to a missplaced method call.

Change-Id: Ia226d9d8e53ae8143b42d9b08814b5448c8be95d
Reviewed-by: Philippe Gorley <philippe.gorley@savoirfairelinux.com>

libavutil now covers the simple cases for creating and managing devices.
As Ring does not need to fine-tune these processes, most of the accel
code can be and has been removed.

Most hardware decoders output NV12, so skip extra conversions by
outputting NV12. Said pixel format is supported by everything that isn't
excessively old.

Change-Id: I10c440026fc3b289dbba7ecbca47e55c57147207
Reviewed-by: Anthony Léonard <anthony.leonard@savoirfairelinux.com>

Philippe Gorley authored 7 years ago and Kateryna Kostiuk committed 7 years ago

Bumps FFmpeg to match the other platforms. Modifies the acceleration
code to work under the new API.

Enables bitstream filters, as some of libavcodec's components, such as
VideoToolbox, use them.

Change-Id: I3a6cee2cf06881bba4602c0ed635ff45908e7b85
Reviewed-by: Kateryna Kostiuk <kateryna.kostiuk@savoirfairelinux.com>

Guillaume Roguez authored 7 years ago and Andreas Traczyk committed 7 years ago

When IP2IP account is created only AccountsChanged signal is emited.
But doRegister() method is called and this kind of account must succeed
on such (as there is no registration) and must call
setRegistrationState(RegistrationState::REGISTERED) to make aware the client
on this event.
This was not done. This patch adds this call.

Change-Id: Ic5b8a31d9e2b98dd96ed394247f77bbfa3d8cdde
Reviewed-by: Andreas Traczyk <andreas.traczyk@savoirfairelinux.com>