Skip to content
Snippets Groups Projects
New look: Off

Crash due to out-of-range FD_SET

    • Open Issue created by François-Simon Fauteux-Chapleau @ffauteux-chapleau

    We've had (and fixed) similar issues in the past, e.g. dhtnet#23 (closed) from a few months ago, but this one occurred recently, on the 20240716 nightly.

    [1721274296.735|9158] NAT-PMP: Request for mapping JAMI-TCP:14715 on 192.168.68.1 succeeded
[1721274296.735|9158] Number of 'available' TCP mappings in the local list: 5 (0 open + 0 pending + 5 in progress)
[1721274296.735|9158] Number of 'available' UDP mappings in the local list: 8 (8 open + 0 pending + 0 in progress)
[1721274296.735|9158] [ice:0x7fab24d3ac60] UPNP mapping request failed!
[1721274296.735|9158] [ice:0x7fab24d3ac60] Add srflx reflexive candidates [192.168.68.60:9 : 76.71.241.126:9] for comp 1
[1721274296.735|9158] added turn server '144.217.83.140', port 3478
[1721274296.737|9158] Store DHT public IPv4 address: 76.71.241.126
[1721274296.737|9158] [ice:0x7fab24dba3d0] Creating IceTransport session for ""
[1721274296.737|9158] [ice:0x7fab24dba3d0] Initializing the session - comp count 1 - as a slave
[1721274296.737|9158] Desired port is not set, will provide the first available port for [TCP]
[1721274296.737|9158] Request mapping JAMI-TCP:12053 using protocol [NAT-PMP] IGD [192.168.68.1]
[1721274296.753|9872] [ice:0x7fab24d3ac60] TCP initialization success
[1721274296.753|9872] [ice:0x7fab24d3ac60] as slave
[1721274296.753|9872] [ice:0x7fab24d3ac60] (local) ufrag=5a9e1bf0, pwd=45f2c8153e02522044c7b5d6
[1721274296.753|9334] [device bc642e81a0cb0f054dd04e6ec301ab59ecec2052167c9addffd6856d7d86f2ec] Added local ICE candidate Hc0a8443c 1 TCP 2130706431 192.168.68.60 42531 typ host tcptype passive
[1721274296.753|9334] [device bc642e81a0cb0f054dd04e6ec301ab59ecec2052167c9addffd6856d7d86f2ec] Added local ICE candidate Hc0a8443c 1 TCP 2130706175 192.168.68.60 9 typ host tcptype active
[1721274296.753|9334] [device bc642e81a0cb0f054dd04e6ec301ab59ecec2052167c9addffd6856d7d86f2ec] Added local ICE candidate H860057a1 1 TCP 2130706431 fe80::6e80:c038:943e:18d3 56417 typ host tcptype passive
[1721274296.753|9334] [device bc642e81a0cb0f054dd04e6ec301ab59ecec2052167c9addffd6856d7d86f2ec] Added local ICE candidate H860057a1 1 TCP 2130706175 fe80::6e80:c038:943e:18d3 9 typ host tcptype active
[1721274296.753|9334] [device bc642e81a0cb0f054dd04e6ec301ab59ecec2052167c9addffd6856d7d86f2ec] Added local ICE candidate Sc0a8443c 1 TCP 1694498303 76.71.241.126 9 typ srflx tcptype active
[1721274296.753|9334] [device bc642e81a0cb0f054dd04e6ec301ab59ecec2052167c9addffd6856d7d86f2ec] Added local ICE candidate R90d9538c 1 TCP 16777215 144.217.83.140 22978 typ relay tcptype passive
[1721274296.753|9334] [device bc642e81a0cb0f054dd04e6ec301ab59ecec2052167c9addffd6856d7d86f2ec] Sending connection request
[1721274296.860|9154] [device 734a80c81611966547118533340be23c87b273514169817336e9c8e9243236e7] Answer to connection request: put encrypted ok
[1721274296.877|9158] NAT-PMP: Request for mapping JAMI-TCP:12053 on 192.168.68.1 succeeded
[1721274296.877|9158] Number of 'available' TCP mappings in the local list: 5 (0 open + 0 pending + 5 in progress)
[1721274296.877|9158] Number of 'available' UDP mappings in the local list: 8 (8 open + 0 pending + 0 in progress)
[1721274296.877|9158] [ice:0x7fab24dba3d0] UPNP mapping request failed!
[1721274296.877|9158] [ice:0x7fab24dba3d0] Add srflx reflexive candidates [192.168.68.60:9 : 76.71.241.126:9] for comp 1
[1721274296.877|9158] added turn server '144.217.83.140', port 3478
* bit out of range 0 - FD_SETSIZE on fd_set *: terminated
Abandon (core dumped)

    Designs

      Child items ...

      2. Activity

      • François-Simon Fauteux-Chapleau added natureto determine severityhigh typebug labels

        added natureto determine severityhigh typebug labels

      • François-Simon Fauteux-Chapleau added natureintermittent label and removed natureto determine label

        added natureintermittent label and removed natureto determine label

      • François-Simon Fauteux-Chapleau
        François-Simon Fauteux-Chapleau @ffauteux-chapleau ·
        Author Developer

        I encountered this bug again a few weeks ago:

        [1738265794.260|1770] [ice:0x79ced276afd0] Add srflx reflexive candidates [192.168.0.234:10769 : 192.168.50.211:10769] for comp 1
[1738265794.260|1770] [ice:0x79ced276afd0] Add srflx reflexive candidates [192.168.0.234:9 : 208.88.110.46:9] for comp 1
[1738265794.260|1770] Added TURN server '144.217.83.140', port 3478
[1738265794.730|30591] [ice:0x79ced276afd0] TCP initialization success
[1738265794.730|30591] [ice:0x79ced276afd0] as master
[1738265794.740|30591] [ice:0x79ced276afd0] (local) ufrag=2193baa9, pwd=56ee2fdd0746f3fd1b03a6f9
[1738265794.740|30420] [ice:0x79ced276afd0] Add remote candidate: Hc0a832ab 1 TCP 2130706431 192.168.50.171 44399 typ host tcptype passive
[1738265794.740|30420] [ice:0x79ced276afd0] Add remote candidate: Hc0a832ab 1 TCP 2130706175 192.168.50.171 9 typ host tcptype active
[1738265794.740|30420] [ice:0x79ced276afd0] Add remote candidate: H463f0592 1 TCP 2130706431 2607:fad8:4:6:6b76:74eb:1f68:bd7 59331 typ host tcptype passive
[1738265794.740|30420] [ice:0x79ced276afd0] Add remote candidate: H463f0592 1 TCP 2130706175 2607:fad8:4:6:6b76:74eb:1f68:bd7 9 typ host tcptype active
[1738265794.740|30420] [ice:0x79ced276afd0] Add remote candidate: H9bffe6c1 1 TCP 2130705919 2607:fad8:4:6:7086:d7ff:fe9f:d3fc 59331 typ host tcptype passive
[1738265794.740|30420] [ice:0x79ced276afd0] Add remote candidate: H9bffe6c1 1 TCP 2130705663 2607:fad8:4:6:7086:d7ff:fe9f:d3fc 9 typ host tcptype active
[1738265794.740|30420] [ice:0x79ced276afd0] Add remote candidate: H39432263 1 TCP 2130705407 2605:8d80:44:532a:c994:7316:ccd9:524d 59331 typ host tcptype passive
[1738265794.740|30420] [ice:0x79ced276afd0] Add remote candidate: H39432263 1 TCP 2130705151 2605:8d80:44:532a:c994:7316:ccd9:524d 9 typ host tcptype active
[1738265794.740|30420] [ice:0x79ced276afd0] Add remote candidate: H3d072fd1 1 TCP 2130704895 2605:8d80:505:8ea:f35d:3846:6d45:b18c 59331 typ host tcptype passive
[1738265794.750|30420] [ice:0x79ced276afd0] Add remote candidate: H3d072fd1 1 TCP 2130704639 2605:8d80:505:8ea:f35d:3846:6d45:b18c 9 typ host tcptype active
[1738265794.750|30420] [ice:0x79ced276afd0] Add remote candidate: Sc0a832ab 1 TCP 1694498303 208.88.110.46 9 typ srflx tcptype active
[1738265794.750|30420] [ice:0x79ced276afd0] Add remote candidate: R90d9538c 1 TCP 16777215 144.217.83.140 11616 typ relay tcptype passive
[1738265794.750|30420] [device 5173b4094c25bcdf8c21f309218e082b8e189511f964100dddfad1e125457807] Connection accepted, DHT reply
[1738265794.750|30420] [ice:0x79ced276afd0] Negotiation starting 12 remote candidate(s)
[1738265794.364|1696] NAT-PMP: Renewal request for mapping JAMI-UDP:24828 on 192.168.0.1 succeeded
[1738265794.364|1696] Successfully registered controller 0x79ced0210e60
*** bit out of range 0 - FD_SETSIZE on fd_set ***: terminated
*** bit out of range 0 - FD_SETSIZE on fd_set ***: terminated

        The crash most likely occurs in either PJPROJECT or libnatpmp. We could consider patching these libraries so that they use poll instead of select, like we did in our own code in commit dhtnet@4cf587e6.

        The fact that we're going past the FD_SETSIZE limit may indicate that we're leaking file descriptors (this has happened in the past, see dhtnet@72704fc2), so we should check if that's the case and fix the issue if there is one.

      Please register or sign in to reply