The build system ignores system argon2 library and tries to download its own's during the build process unconditionally.

Maing it awkward to package jami-daemon in a distro.

What OS are you using? For Arch Linux I have opened a bug report.

Gentoo. Ah right, it's broken there as well. After fixing it manually it tries to download dbus-c++, and dbus-c++ is also already installed, and has the correct version in .pc.

You can select the packages to build manually, like Arch Linux does (see PKGBUILD):

  ../bootstrap \
      --disable-downloads \
      --disable-all \
      --enable-pjproject

Or uncomment this block in ./contrib/src/dbus-cpp/rules.mak:

# Package forced as bugged on GCC7
#ifeq ($(call need_pkg,"dbus-c++-1 >= 0.9.0"),)
#PKGS_FOUND += dbus-cpp
#endif

Don't know why it is commented out.

Generally you should not build argon2

In rules.mak:

ifeq ($(call need_pkg,'libargon2 > 20161029'),)
PKGS_FOUND += argon2
endif

if argon2 is on the system and need_pkg return a version > 20161029 the version from the system will be used.

On Fedora, debian and ubuntu this is what I have:

 amarok@atlas  ~/Projects/jami/daemon/contrib/native   master  make list              
Distribution-provided packages:
  argon2 fmt gnutls iconv jsoncpp msgpack nettle opus speex speexdsp
  uuid x264 yaml-cpp zlib

And argon2 is not built. If it's the case, the package of your distrib is probably wrong and should be fixed (like @Vladimir did for arch).

For dbus-cpp, gcc7 is anyway unsupported so this should be re-added. Will cahnge that

I removed the commented detection for dbus-cpp as it's correctly detected on all distrib we support eg:

$ make list
Distribution-provided packages:
  argon2 dbus-cpp ...

So for this issue in our sources there is nothing more to do.

closed