Skip to content
Snippets Groups Projects
Commit ec92cc36 authored by ovari's avatar ovari Committed by Adrien Béraud
Browse files

developer/new-developers/submitting-your-first-patch.md: seealso

Change-Id: Ib602887b3c2fea76d6af29fd91c5db3c85574f31
parent 667509ca
No related branches found
No related tags found
No related merge requests found
# Submitting your first patch # Submitting your first patch
## Setting up Git and SSH ```{seealso}
Set up Git and SSH to work smoothly with Gerrit.
(**To work smoothly with Gerrit.**) First see [Creating a gerrit review](working-with-gerrit).
```
First see:
* [Creating a gerrit review](working-with-gerrit)
### SSH setup ### SSH setup
<https://review.jami.net/Documentation/user-upload.html#ssh> <https://review.jami.net/Documentation/user-upload.html#ssh>
1. Generate a personal dedicated public/private key set. 1. Generate a personal, dedicated public/private key set.
```bash ```bash
ssh-keygen -f ~/.ssh/jami_gerrit_review` ssh-keygen -f ~/.ssh/jami_gerrit_review`
``` ```
...@@ -20,32 +17,32 @@ ssh-keygen -f ~/.ssh/jami_gerrit_review` ...@@ -20,32 +17,32 @@ ssh-keygen -f ~/.ssh/jami_gerrit_review`
Your identification has been saved in `jami_gerrit_review`. Your identification has been saved in `jami_gerrit_review`.
Your public key has been saved in `jami_gerrit_review.pub`. Your public key has been saved in `jami_gerrit_review.pub`.
2. Tell Gerrit your public key 2. Tell Gerrit your public key.
1. Login to [Gerrit](https://review.jami.net) via your GitLab account (Sign-in → OAuth GitLab) 1. Log in to [Gerrit](https://review.jami.net) via your GitLab account (Sign-in → OAuth GitLab).
2. Follow the SSH key instructions found from (your) user options [settings](https://review.jami.net/settings/) 2. Follow the SSH key instructions found in (your) user options [settings](https://review.jami.net/settings/).
3. Set up your local SSH (via `ssh-add` or in `~/.ssh/config`).
3. Set up your local SSH (via `ssh-add` or in `~/.ssh/config`) 4. Test all of the above (SSH on the service or just try to clone a repo on Gerrit via SSH).
4. Test all of the above (SSH on the service or just try to clone a repo on Gerrit via SSH)
### Your Repository ### Your repository
```{important}
This *assumes* you have moved any existing project clone out of the way. This *assumes* you have moved any existing project clone out of the way.
```
1. Clone a (fresh) copy of the project. `git clone ssh://USERNAME@review.jami.net:29420/PROJECT_NAME_GOES_HERE.git`; e.g. `git clone ssh://foo@review.jami.net:29420/jami-project.git`. 1. Clone a (fresh) copy of the project, `git clone ssh://USERNAME@review.jami.net:29420/PROJECT_NAME_GOES_HERE.git`; e.g., `git clone ssh://foo@review.jami.net:29420/jami-project.git`.
2. Configure this clones local .git/config (optional) 2. Configure this clone's local .git/config (optional).
3. Generate commit Change-Ids 3. Generate commit Change-Ids.
aka: commit-msg hook script Also known as commit-msg hook script.
A shell script, to be installed to .git/hooks/commit-msg. A shell script to be installed to .git/hooks/commit-msg.
The script creates a unique Change_Id:hash for each commit made from your repository. The script creates a unique Change_Id:hash for each commit made from your repository.
* The first time you attempt a _push_ to review `git push origin HEAD:refs/for/master`, * The first time you attempt a _push_ to review `git push origin HEAD:refs/for/master`, Gerrit will notice a lack of Change-Id.
gerrit will notice a lack of Change-Id.
* Gerrit will also present a secure copy (scp) string. * Gerrit will also present a secure copy (scp) string.
Use *that* to download a copy of .git/hooks/commit-msg. Use *that* to download a copy of .git/hooks/commit-msg.
## References ## References
+ [Some Gritty Details](https://review.jami.net/Documentation/user-upload.html#_gritty_details) * [Some Gritty Details](https://review.jami.net/Documentation/user-upload.html#_gritty_details)
\ No newline at end of file \ No newline at end of file
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment